From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Randy Taylor Newsgroups: gmane.emacs.bugs Subject: bug#61006: 29.0.60; Wrong indentation in go-ts-mode Date: Thu, 26 Jan 2023 02:39:46 +0000 Message-ID: References: <4e1f92dc54d94cf4860490c643b5fd565deb0e1a.camel@gmail.com> <3aLr20wUmwH_Z8sYXoG4FACIHNCCJlDFFAdFCUNNe5FTsaozqHRxHhZ6fwtVXlRZMmfA_7PDN_rE-YfxrhtEtq5SOMnd0S2LeMgCNGQlyco=@rjt.dev> <94c6de01accfebc10cd7a0377e0c1087fdae5086.camel@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39113"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 61006@debbugs.gnu.org To: sskostyaev@gmail.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 26 03:41:21 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pKsCW-0009yw-IQ for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 26 Jan 2023 03:41:20 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pKsCI-0006Tu-0w; Wed, 25 Jan 2023 21:41:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pKsCF-0006Is-2v for bug-gnu-emacs@gnu.org; Wed, 25 Jan 2023 21:41:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pKsCE-0007lf-F9 for bug-gnu-emacs@gnu.org; Wed, 25 Jan 2023 21:41:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pKsCD-0005j9-Rb for bug-gnu-emacs@gnu.org; Wed, 25 Jan 2023 21:41:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Randy Taylor Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 26 Jan 2023 02:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61006 X-GNU-PR-Package: emacs Original-Received: via spool by 61006-submit@debbugs.gnu.org id=B61006.167470080421937 (code B ref 61006); Thu, 26 Jan 2023 02:41:01 +0000 Original-Received: (at 61006) by debbugs.gnu.org; 26 Jan 2023 02:40:04 +0000 Original-Received: from localhost ([127.0.0.1]:60310 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pKsBH-0005hk-Lh for submit@debbugs.gnu.org; Wed, 25 Jan 2023 21:40:04 -0500 Original-Received: from mail-4022.proton.ch ([185.70.40.22]:53965) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pKsBD-0005h5-O5 for 61006@debbugs.gnu.org; Wed, 25 Jan 2023 21:40:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev; s=protonmail2; t=1674700792; x=1674959992; bh=zp6IgCyTnwAtJn2jbx0Y7HuUFkDkgP01NcfcSdqTWL0=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=qP/G7Dook4TXunmkGmGSyNcckIPAvSU7KQY/McNg0gmJHWHh0X9xoyLRhdaEqfsxf Gzg1TEolpSlpx3RdsxeY+/u6iUyrxL1/0qRjfGLSiB8WHHi7SlG+GKW7vc5ShBtB3p zezHggwBGjxb0jbOWLDkqd7EVE0gYYnwkhbaWiXwoUhn3+nbF9NUc7UJL0EqrBBk95 AHqzTONdictBz36sbbxLr4u7GxnURxPXzgSKndaV0VAyGTG4ZAVzHjXM/7zf/D2r3w PsrEYMpaUJ1w5vAX+A9srJF6dzM927/EXgZhXKZ1H4c/Jd/8v2kSPA4TbTU95R/yBz tiVSHU4N5FrHA== In-Reply-To: <94c6de01accfebc10cd7a0377e0c1087fdae5086.camel@gmail.com> Feedback-ID: 44397038:user:proton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:254164 Archived-At: On Tuesday, January 24th, 2023 at 23:06, sskostyaev@gmail.com wrote: >=20 > Thank you! >=20 > Fixed now. Thanks for testing. Can someone install the patch to emacs-29? >=20 > =D0=92 =D0=A1=D1=80, 25/01/2023 =D0=B2 02:46 +0000, Randy Taylor =D0= =BF=D0=B8=D1=88=D0=B5=D1=82: >=20 > > On Tuesday, January 24th, 2023 at 21:35, Randy Taylor dev@rjt.dev > > wrote: > >=20 > > > On Sunday, January 22nd, 2023 at 05:00, > > > sskostyaev@gmail.com sskostyaev@gmail.com wrote: > > >=20 > > > > Hi. Thank you all for great work. > > > > In go-ts-mode indentation breaks in function or method definition > > > > if > > > > arguments placed on separate lines like this: > > > > `func transform( s string, ) string {` > > > > This code should be indented like this: > > > > `func transform( s string, ) string {` > > >=20 > > > Thanks for the report. I've attached a patch that fixes this. > > >=20 > > > > Also `go-ts-mode-indent-offset' should be 8 by default. In go > > > > world there is gofmt which is a real standart for code > > > > indentation. It would be great if emacs will provide the same > > > > indentation out of the box. > > >=20 > > > And addresses this. > > >=20 > > > > There is also other issue - sometimes go-ts-mode syntax > > > > highliting breaks when I actively use it with `lsp-mode`- > > > > refactorings, auto formatting etc. But I can't reproduce it > > > > with`eglot`. > > >=20 > > > Seems like an `lsp-mode` problem then? I only use `eglot` and > > > haven't noticed anything amiss. > >=20 > > Addendum to my last patch: added indentation support for interfaces > > as it was missing. Everything else is the same.