unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: Lars Ingebrigtsen <larsi@gnus.org>, Juri Linkov <juri@linkov.net>
Cc: "46882@debbugs.gnu.org" <46882@debbugs.gnu.org>
Subject: bug#46882: 26.3; Let `dired-omit-mode' match lines, as well as file names
Date: Tue, 21 Jun 2022 14:33:02 +0000	[thread overview]
Message-ID: <SJ0PR10MB5488F2FB14733B96C60656A8F3B39@SJ0PR10MB5488.namprd10.prod.outlook.com> (raw)
In-Reply-To: <8735fy1ekl.fsf@gnus.org>

> > Its counterpart variable is `dired-omit-files' that is a regexp.
> > Shouldn't the new variable be named with the same naming scheme
> > for consistency?  I.e. just `dired-omit-lines'.  Even so that
> > it's not just a regexp, but can be a symbol of a function name.
                                                ^^^^^^^^^^^^^^^^^^
Ah, so you _didn't_ use the code I sent, which
supports a symbol as a _variable_, whose value
is a regexp.  Too bad.

And what kind of function are we talking about?
A function that returns a regexp?  A function
that does something else?

> Makes sense; now renamed.

Too bad.  Guess that changes this from "done"
to "won't fix".

Guess this is hidden behind your "I've now
pushed to Emacs 29 (with some changes)."
                    ^^^^^^^^^^^^^^^^^

Guess I'll have to keep the original option
`diredp-omit-lines-regexp' around.  I was
hoping Emacs would absorb it, so renaming
`diredp-' to `dired-' would suffice.

For your "consistency" maybe you'll now want
to change `dired-omit-files' to also support
a function symbol...  I mean, _consistency_,
right?

And while you're at it, for "consistency"
consider renaming `dired-garbage-files-regexp'.
Oh, and add support for it to be a function
symbol...  Consistency.

Consistency is a wonderful, hobgoblinny thing.





      reply	other threads:[~2022-06-21 14:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-03  0:39 bug#46882: 26.3; Let `dired-omit-mode' match lines, as well as file names Drew Adams
2021-03-03 18:10 ` Drew Adams
2022-06-19 23:49 ` Lars Ingebrigtsen
2022-06-20 16:49   ` Juri Linkov
2022-06-20 19:36     ` Drew Adams
2022-06-21 10:44     ` Lars Ingebrigtsen
2022-06-21 14:33       ` Drew Adams [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SJ0PR10MB5488F2FB14733B96C60656A8F3B39@SJ0PR10MB5488.namprd10.prod.outlook.com \
    --to=drew.adams@oracle.com \
    --cc=46882@debbugs.gnu.org \
    --cc=juri@linkov.net \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).