From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#46882: 26.3; Let `dired-omit-mode' match lines, as well as file names Date: Tue, 21 Jun 2022 14:33:02 +0000 Message-ID: References: <87k09crz6p.fsf@gnus.org> <865ykvo4kl.fsf@mail.linkov.net> <8735fy1ekl.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23292"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "46882@debbugs.gnu.org" <46882@debbugs.gnu.org> To: Lars Ingebrigtsen , Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jun 21 16:34:15 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o3exJ-0005kd-0L for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 21 Jun 2022 16:34:13 +0200 Original-Received: from localhost ([::1]:46362 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o3exH-0005dV-LF for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 21 Jun 2022 10:34:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48866) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o3ex9-0005cW-0X for bug-gnu-emacs@gnu.org; Tue, 21 Jun 2022 10:34:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39168) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o3ex8-0004oF-OF for bug-gnu-emacs@gnu.org; Tue, 21 Jun 2022 10:34:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o3ex8-0000xE-Hg for bug-gnu-emacs@gnu.org; Tue, 21 Jun 2022 10:34:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 21 Jun 2022 14:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46882 X-GNU-PR-Package: emacs Original-Received: via spool by 46882-submit@debbugs.gnu.org id=B46882.16558219943609 (code B ref 46882); Tue, 21 Jun 2022 14:34:02 +0000 Original-Received: (at 46882) by debbugs.gnu.org; 21 Jun 2022 14:33:14 +0000 Original-Received: from localhost ([127.0.0.1]:33065 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o3ewM-0000w9-59 for submit@debbugs.gnu.org; Tue, 21 Jun 2022 10:33:14 -0400 Original-Received: from mx0a-00069f02.pphosted.com ([205.220.165.32]:45662) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o3ewK-0000vx-CO for 46882@debbugs.gnu.org; Tue, 21 Jun 2022 10:33:13 -0400 Original-Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 25LEI7bl031207; Tue, 21 Jun 2022 14:33:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2021-07-09; bh=CmJ/sMG53KB5w8he2ZSIWiV+uSQqRORgvT4YrDnOH2M=; b=0orfUJ3H3TfY2lN9ADKbHTgGDoV0+2/57t+FY9qiiNMMklL4vWvuQoD47ih5r3WqRJX1 4mhwv8CHt31zVhizR5bTJrobiUch4rCqBD5t/6CeXN6bJVWxQq49rZUYb3dkfJGuVvbT 2dTD5b8OeI4cmDW0mol3q/6YEFcIq4LpMk797oAzKZT1U73+5admAzXiv/Pl9A2NFdn8 wJ0TSwD5YWFezvrCp+CDZmOHDvlWodTHHVI8rohutln1qKnj/8wN9jLACDXeL+ZZ1vvh E5u+dVs8xMaXZ0pKGlbcpwsI89tt651n/gKa3c96BmqV8McSoAgxFEu+lD6Ck0bqud1C mg== Original-Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3gs6kf5pjt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 21 Jun 2022 14:33:09 +0000 Original-Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.16.1.2/8.16.1.2) with SMTP id 25LEGgfY026685; Tue, 21 Jun 2022 14:33:04 GMT Original-Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2168.outbound.protection.outlook.com [104.47.59.168]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com with ESMTP id 3gtg5ueatn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 21 Jun 2022 14:33:04 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TmUKJ0WxvN3PC6ue9SruWjhV5q6ymintVI+BudowqFeNXBxpb8cvpO23JlN/BnyEt8y62bgZM3/5+WGGcQkKC0LWECHEz1YA1lHOWV1TgkaNf7kW8M0M4bG0QG84XJu18LvuYHIm8weE57aZk95+k6+q4R4DeS3SiIX4m60QQnJQUCXB8OZJHnW11SJug1zCkXihOHGcL9/CuKwxz7QQuRib20gVW9vW3lR50WZFI2gguS6LnChkbH7WJGZ0H/WqSi+3wRupedD+zWSHAAjLYgBjuSd5qTiy0kUhwwRBDOKtvIcrCnSDfJwhMGEmT0iHs8CZ+vkPm+ANRpfK0SSPCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CmJ/sMG53KB5w8he2ZSIWiV+uSQqRORgvT4YrDnOH2M=; b=gJ7ulvu+Y8tHZnKmjwtto9R2EGrpGGnSwuEut+Pf+kRp2fuqbOpTAPLnKA2RIuPJQIEwZRjRXd2k/Lnvpu6PZJqiGhsKb0F2B+N/6XuX/70+wjiFvu17gN/RbFsnvu70ByD8sQfp2dJ7W7RDvM1qz4fiPojY98FztpJLijZNDdBSAfR8H8puLIXdps/4I+IXK16NNRJf3hQW+soX8Vx0E1VRIh3Gu32XNivjyJSF6SSdsmx26PunsvmOWpDstjxyOb9496JOahAZn/VAF1uDCkmnd7VQhWiYZgJBlt1bzbg7QhLlpWXLYuJbzfoB8/fLH1Q1Up6R6KJoJOgFIZkDRw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CmJ/sMG53KB5w8he2ZSIWiV+uSQqRORgvT4YrDnOH2M=; b=ygkWqpgRBvLBVyP9t3w+67Uudn4X4zdSxoU7fR0d76Jaza9Dkmv08Wt673s67Mc2XZorlAVWhcTKPsHG+Tia7NBH+N9EKK3G+Hvgz8f4JfPR5Z8TvA2VFocxyULwyDrPbXMhjUEwaAArMQrWY7iZBMuTAEbVLFfFRSE+UQ6zV/E= Original-Received: from SJ0PR10MB5488.namprd10.prod.outlook.com (2603:10b6:a03:37e::19) by DS7PR10MB5231.namprd10.prod.outlook.com (2603:10b6:5:3b1::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.16; Tue, 21 Jun 2022 14:33:02 +0000 Original-Received: from SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::cccb:35bd:9922:dcf5]) by SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::cccb:35bd:9922:dcf5%7]) with mapi id 15.20.5353.022; Tue, 21 Jun 2022 14:33:02 +0000 Thread-Topic: [External] : Re: bug#46882: 26.3; Let `dired-omit-mode' match lines, as well as file names Thread-Index: AdcPxIr27GpHH5ZsSHmtuzgts+D7811l1QMSAAdqhmA= In-Reply-To: <8735fy1ekl.fsf@gnus.org> Accept-Language: en-US Content-Language: en-US x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b89818a4-07a9-4d5d-0104-08da5392f2a2 x-ms-traffictypediagnostic: DS7PR10MB5231:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: N6vPxGRLPv+AzjtNMRZup4uQYhsRTHBgAUkay0jWnDSxN/e6kzlAd62eQUCLMdG4mXfw18evDGCudHWtCwtzqOvdnjRVawkFavb9JsbPRBl3nUAYDFSJKu6qb70tPbl/ylN2DZ/4tER8Lj8R7Yr3LRCudlFTTis/KaC3tb6U1sFmpUin8u1UvWlH7AeKxg02jsR/+mj+2xSUZv6bbvSe9vXq1fmdWSBfKRpybP+BnFQhTZcbMwGPOOaZygL3aTh10jajJpjVKuEWhurxs5pABNiJkbf3mMmSvMnMLeEb3rkFFMM8RQWau50aZq+sNpUu1d9qO4VYi46CSZJVtWKbuTceoBNWNP6Hq/JPiC/XkJSEdoAapbaEOBqWXd7ReD0yQvAIRUzEC0ZLK5CDNwprt6guIHWEAjrxRmNuML7B+GZ24VbGpG2UFE7GufR8av+q4d9x5Mc0/HhdQM+ebbl3Puy20qD69ir/a935C4gz0V9PTe5IN8pRi0rtkkVJuD0M+NN1vAbWiJGsVQYtMW5kugeDS0lgnb9igRXf938+T2qti9sJAhoAX7MdOKURiQW8d9jiaSm3PoM2GM+K1jnHHkhZw21/UpjklI3PBdVBJaCOswUVP9yqu/p5aeHzpGr2Jy262pgz9/c1JaS/5noELihesYvwE4wUatghTlYLZY0sPn0LkuAtt3jD4BWrmMURIUSOuMud4PY7qAWrcg6e7P8c7/+zpHr2CSpWLSFDUbo= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR10MB5488.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(396003)(376002)(366004)(39860400002)(346002)(136003)(66476007)(64756008)(186003)(66946007)(76116006)(5660300002)(66556008)(4326008)(66446008)(2906002)(38070700005)(52536014)(44832011)(86362001)(38100700002)(8676002)(9686003)(55016003)(122000001)(7696005)(71200400001)(26005)(33656002)(6506007)(41300700001)(8936002)(110136005)(316002)(478600001)(81973001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: BV0OEniiTnDR7BtYrwDEY6+RFyJGan8e/0cU0aDwYQoVtBWhNZjg7Sf/d62zLudkeEAjK0PuzhI05OODqNyAaFZG7nuoRopYWjtxO9rjU1sg0vxNbE9ccr1LwKJB7+J6RsqGA4NlS16L7cFnnXSocD6z+fi0iFXXE2VlrYv9C2yc1t3hlRDuug4yWAsN0oICRI3NjOWKX3UD81rjSrcwI3vTd7FgkjRXvxnU458bax/3wAjaeDt5+rXQyobLe6Og1jtd9TERopv1pugyyCB4fSmxqiZE/+Wc3mJ6do3Arx55MS4Kua17/tVONszZJsyklQScRze88jX0CGRvWSqSCJua3BNbfoa2Xd/s5bcXE+f0IlgXzb4OjDCPRGBr5s7ZhJrSXLMSnMlfFFDE/ZNzgDcsHvELqogdiQaD7+U9DWpuI/yKzdmVbPwDwFTKcvNzaV8QF8qJRUQHlmGqPvz1g9ufZpGvL0TwCejdLTSu1e8QWlaTh4mLTZXu08WfZheTbgJ5J1sXuz9lTtRODPCnq/uIB8YdB58lDYene73lBMlxLTGAYMZSl52hpqWlKAoAHT9GzTevDCEMv4ri+mQCpwKuQmrE8LO600aZOBOksFXI2ebqkGeBRECEsZy9VgHGQjAApWYcZ1PiFu6r3XfVdMk01w/Raal2MSgseNu57yj4wOb8E+cVsY8z6DRHMP3jiN4lju2vX0JCwhyN6jWZUj1cz8Y8zpdOH/5v8OwowWouBVDxQdZ6kt0JKD E0tU4Uo0fTda32DYnLYOCnf//VpAZix+KJmvSWkYF6uXRSXonNmsbw87RMjVX63mqUqpAIQBI84w88czUfzBVl/i6JbbroVwch X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB5488.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b89818a4-07a9-4d5d-0104-08da5392f2a2 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jun 2022 14:33:02.7224 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 4/cdTCpIzMT2/kHv/5uws/SrVB/YlGzH2WA/ZWaO3i7ocbCG9ANLVftewMX5S4FiAj+t6M/OOHZY/C3pOxqF/w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB5231 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517, 18.0.883 definitions=2022-06-21_07:2022-06-21, 2022-06-21 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 malwarescore=0 mlxlogscore=999 bulkscore=0 phishscore=0 suspectscore=0 spamscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2204290000 definitions=main-2206210063 X-Proofpoint-ORIG-GUID: Jc5CY0bnuah5D8IkRAXKKcSdz-ZJUNYg X-Proofpoint-GUID: Jc5CY0bnuah5D8IkRAXKKcSdz-ZJUNYg X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:234965 Archived-At: > > Its counterpart variable is `dired-omit-files' that is a regexp. > > Shouldn't the new variable be named with the same naming scheme > > for consistency? I.e. just `dired-omit-lines'. Even so that > > it's not just a regexp, but can be a symbol of a function name. ^^^^^^^^^^^^^^^^^^ Ah, so you _didn't_ use the code I sent, which supports a symbol as a _variable_, whose value is a regexp. Too bad. And what kind of function are we talking about? A function that returns a regexp? A function that does something else? > Makes sense; now renamed. Too bad. Guess that changes this from "done" to "won't fix". Guess this is hidden behind your "I've now pushed to Emacs 29 (with some changes)." ^^^^^^^^^^^^^^^^^ Guess I'll have to keep the original option `diredp-omit-lines-regexp' around. I was hoping Emacs would absorb it, so renaming `diredp-' to `dired-' would suffice. For your "consistency" maybe you'll now want to change `dired-omit-files' to also support a function symbol... I mean, _consistency_, right? And while you're at it, for "consistency" consider renaming `dired-garbage-files-regexp'. Oh, and add support for it to be a function symbol... Consistency. Consistency is a wonderful, hobgoblinny thing.