unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: "51927-done@debbugs.gnu.org" <51927-done@debbugs.gnu.org>
Subject: bug#51927: [External] : Re: bug#51927: 27.2; Rename `highlight-nonselected-windows'
Date: Thu, 18 Nov 2021 16:44:42 +0000	[thread overview]
Message-ID: <SJ0PR10MB5488EAC160834E4082693C69F39B9@SJ0PR10MB5488.namprd10.prod.outlook.com> (raw)
In-Reply-To: <83y25mx8j0.fsf@gnu.org>

> > This variable seems poorly named, in more ways than one.  Could we
> > consider renaming it (by aliasing and perhaps deprecating the old name)?
> 
> This variable exists since Emacs 19.  Renaming it after all that time
> would make no sense at all.

I'm aware that it's an old name.
Renaming it makes a lot of sense.
There's no problem letting the old
name remain as an alias.

> > 1. This var has no effect if `transient-mark-mode' is disabled.
> 
> That is inaccurate: it has no effect if the region is inactive (you
> can have an active region even with transient-mark-mode disabled).  I
> added the caveat to the doc string.

I disagree.  The notion of "active" mark
or region has no meaning outside of
transient-mark-mode.  It was (naturally)
introduced precisely to describe t-m-mode
behavior.  There was no need for it before
then, and there's no need (or use) now, to
refer to it outside t-m-mode.  It has no
meaning, no user-visible or code-visible
behavior outside t-m-mode.

> > 2. This is not really about highlighting windows.  (Yes, the
> > highlighting occurs in windows, of course.  But it's the active region
> > that's highlighted.)
> 
> The doc string says that.

The enhancement request / bug report is
about the poor, inaccurate, misleading
_option name_.  Look for the option that
does what this does, and you won't find it.
Apropos, etc. can't help, because the name
is so inappropriate.  You may know of the
option, but have forgotten its name, and
you just won't find it.

> > 3. The name says nothing about what's most important: "region".  This is
> > about showing (highlighting) the _active region_ in _all_ windows.
> 
> See above: that ship sailed long ago.

See above, and the bug report.  There's
no problem keeping the old name as well
as a new, helpful, name.

Almost any name with "region" in it would
be an improvement.

> > 4. The doc should explain the alternative behavior, when the var is nil:
> > the active region is highlighted only in the selected window.
> 
> Added.  And with that, I'm closing this bug.

Yet another won't-fix.





  reply	other threads:[~2021-11-18 16:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-17 21:03 bug#51927: 27.2; Rename `highlight-nonselected-windows' Drew Adams
2021-11-18  6:49 ` Eli Zaretskii
2021-11-18 16:44   ` Drew Adams [this message]
2021-11-18 16:58     ` bug#51927: [External] : " Eli Zaretskii
2021-11-18 17:28       ` Drew Adams
2021-11-18 18:44         ` Eli Zaretskii
2021-11-18 17:20 ` Juri Linkov
2021-11-18 17:51   ` bug#51927: [External] : " Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SJ0PR10MB5488EAC160834E4082693C69F39B9@SJ0PR10MB5488.namprd10.prod.outlook.com \
    --to=drew.adams@oracle.com \
    --cc=51927-done@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).