From: Drew Adams <drew.adams@oracle.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>, Eli Zaretskii <eliz@gnu.org>
Cc: "michael_heerdegen@web.de" <michael_heerdegen@web.de>,
"philipk@posteo.net" <philipk@posteo.net>,
"66187@debbugs.gnu.org" <66187@debbugs.gnu.org>,
"joseph@breatheoutbreathe.in" <joseph@breatheoutbreathe.in>
Subject: bug#66187: read-file-name unexpected behavior when MUSTMATCH is a function
Date: Fri, 6 Oct 2023 14:08:51 +0000 [thread overview]
Message-ID: <SJ0PR10MB5488BA53706149817D6B9FC3F3C9A@SJ0PR10MB5488.namprd10.prod.outlook.com> (raw)
In-Reply-To: <jwvzg0vucnr.fsf-monnier+emacs@gnu.org>
> (we've had `require-match` for more than 30 years
> and it's only last year that we decided it was
> worth generalizing it to a function)
^^^^^^^^^^^^
It was decided with very little discussion, FWIW.
The 29.1 behavior is not at all more general than
the longstanding previous behavior. Just the
opposite. It confuses different things, co-opting
the REQUIRE-MATCH behavior with completion behavior.
All code that previously might have passed a
function value for REQUIRE-MATCH expects that value
to be treated as any other non-`nil', non-`t',
non-`confirm*' value. That's now broken. That more
general behavior is lost - a function value being
treated differently imposes a limitation - the
behavior is more specific now (another case added),
not more general.
The new behavior that was cobbled together into the
REQUIRE-MATCH arg should have been provided in some
other way - whether an additional arg, or a non-arg
variable, or whatever. It should not have been
jammed into REQUIRE-MATCH, changing its behavior in
an incompatible way.
(Just one opinion.)
next prev parent reply other threads:[~2023-10-06 14:08 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-24 21:31 bug#66187: read-file-name unexpected behavior when MUSTMATCH is a function Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-25 3:58 ` Michael Heerdegen
2023-09-25 5:12 ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-25 21:33 ` Michael Heerdegen
2023-09-26 8:37 ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-27 0:26 ` Michael Heerdegen
2023-09-27 0:55 ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-27 1:43 ` Michael Heerdegen
2023-10-03 21:18 ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-03 23:00 ` Drew Adams
2023-10-04 3:35 ` Michael Heerdegen
2023-10-04 5:22 ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-05 1:12 ` Michael Heerdegen
2023-10-04 7:03 ` Eli Zaretskii
2023-10-05 19:34 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-05 20:20 ` Drew Adams
2023-10-06 4:47 ` Eli Zaretskii
2023-10-06 13:05 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-06 14:08 ` Drew Adams [this message]
2023-10-06 4:45 ` Eli Zaretskii
2023-10-06 13:01 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-06 13:46 ` Eli Zaretskii
2023-10-06 16:43 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-07 5:23 ` Eli Zaretskii
2023-10-07 14:25 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-07 15:09 ` Eli Zaretskii
2023-10-07 15:12 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-12 21:26 ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-26 6:49 ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-18 0:24 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-19 2:52 ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-09 8:06 ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-25 20:53 ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-28 19:20 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-28 19:28 ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-06 5:55 ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-29 12:00 ` Eli Zaretskii
2023-10-03 20:43 ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-04 6:05 ` Eli Zaretskii
2023-10-04 6:25 ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SJ0PR10MB5488BA53706149817D6B9FC3F3C9A@SJ0PR10MB5488.namprd10.prod.outlook.com \
--to=drew.adams@oracle.com \
--cc=66187@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=joseph@breatheoutbreathe.in \
--cc=michael_heerdegen@web.de \
--cc=monnier@iro.umontreal.ca \
--cc=philipk@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).