From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#66187: read-file-name unexpected behavior when MUSTMATCH is a function Date: Fri, 6 Oct 2023 14:08:51 +0000 Message-ID: References: <87r0mni6m1.fsf@breatheoutbreathe.in> <87bkdq3nw6.fsf@web.de> <875y3yx221.fsf@breatheoutbreathe.in> <87pm260wh9.fsf@web.de> <87v8bx48ww.fsf@breatheoutbreathe.in> <87msx8sbpv.fsf@web.de> <87bkdoh1gy.fsf@breatheoutbreathe.in> <87h6ngs85e.fsf@web.de> <87ttr7nzyj.fsf@breatheoutbreathe.in> <83pm1u6f8l.fsf@gnu.org> <83edi82w75.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16430"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "michael_heerdegen@web.de" , "philipk@posteo.net" , "66187@debbugs.gnu.org" <66187@debbugs.gnu.org>, "joseph@breatheoutbreathe.in" To: Stefan Monnier , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Oct 06 16:10:00 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qolWh-0003um-KA for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 06 Oct 2023 16:09:59 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qolWS-0004Pd-9I; Fri, 06 Oct 2023 10:09:44 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qolWR-0004PQ-Ay for bug-gnu-emacs@gnu.org; Fri, 06 Oct 2023 10:09:43 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qolWR-0007bX-2y for bug-gnu-emacs@gnu.org; Fri, 06 Oct 2023 10:09:43 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qolWj-0000A9-Js for bug-gnu-emacs@gnu.org; Fri, 06 Oct 2023 10:10:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 06 Oct 2023 14:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66187 X-GNU-PR-Package: emacs Original-Received: via spool by 66187-submit@debbugs.gnu.org id=B66187.1696601359563 (code B ref 66187); Fri, 06 Oct 2023 14:10:01 +0000 Original-Received: (at 66187) by debbugs.gnu.org; 6 Oct 2023 14:09:19 +0000 Original-Received: from localhost ([127.0.0.1]:52335 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qolW3-000091-4X for submit@debbugs.gnu.org; Fri, 06 Oct 2023 10:09:19 -0400 Original-Received: from mx0b-00069f02.pphosted.com ([205.220.177.32]:45924) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qolW0-00008p-OV for 66187@debbugs.gnu.org; Fri, 06 Oct 2023 10:09:18 -0400 Original-Received: from pps.filterd (m0333520.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 396Cc2Wo015192; Fri, 6 Oct 2023 14:08:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2023-03-30; bh=j2X0r2yTjTn6fAFxSxeb16h7a6eMtoAzPO+oaSDRUek=; b=qBPcp8s1VFKycvYMJA6Xh/yibmvjmik9mFWpXGM0I426/WlzEM8lM6C3nnREjo2mBsLb 2E1rORt/FWh0fyzcAc11/EyxvMcPP5z8P6VXZBSuVYv3bN+pDLslbLJWzqpDPVTbKHog JMKEGHMSMTQeO7Xwesn+6h0NW+BSxhjZJKBH2hY3iVXhDW3PfjAx+QRaBLaomkOg7HtX ZQ9mvepTXkVist9TTIEib8bkvq3RJCn2B6rhGwKMgkKkJD9RfhFKlTBX6wbg88wNUuMg XVEYyx2uckdM2YU7bgvqlXK+3fN12fkP6QBvQB6lxuUjAt8+wLX2MFpr7bspm+Xus5+j xQ== Original-Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3tebqe4170-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 06 Oct 2023 14:08:54 +0000 Original-Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 396E14f1033713; Fri, 6 Oct 2023 14:08:53 GMT Original-Received: from nam02-bn1-obe.outbound.protection.outlook.com (mail-bn1nam02lp2044.outbound.protection.outlook.com [104.47.51.44]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3tea4axt24-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 06 Oct 2023 14:08:53 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kRAOKzni4qv7hiO5ehfe9V1LkrezwOD7Csq/zJvX8tkXkf1u4CyT73iIdm3BQbnhgKJ65+/pXxSco6eHqCW0jvUOhv4nwXa6pqta1QEWNVs4ZoUaYHKfySvOtij4BLfyIXMm8HqXqOIsSNnMZBvK0B3xLlLHm/EZKOu6dcwXqB64fd9EqZP7w7HqlccQcZN3F3aAJ+k/19eWMGYiVRgp6obrNUAzWRQW57I6ypYSUdHgXSvCp+T60cdIBxBHaw3LfuoNU7+ZrYLuIzq0viDIErDHc9gxYcfPJwrkYmfYvxYjCx4j48tiOaYM/Gsg5nDGhdC9wTMWR8IzJtvBOVRicQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=j2X0r2yTjTn6fAFxSxeb16h7a6eMtoAzPO+oaSDRUek=; b=QXM8cUp+5S/eJ40G7aeqQz33HAsfulFo+Qek7TC7KhB0LjNdQPgd0zZfdhf1qcHrsZC9CXek69dMBzHNEk5SBgdxDLoMyGaO+Nj1QbnylnXdeHhpp45uHUvSqGWe286aL29SFpOuLtwvYF1s2OOsHhW3Sl1FenYHcJrQSDsVot85+UdFYGskJwA3iiP+A0+vItDDaUJe2J7dN7gSOcx+mCL8oA1w4bwuQPaZ/si3U9t5ylulMLrU+eMo2zNq/bXLVuS0zTkkQiKz098GWI9MBR3vx44GKN0dUDvYuHJyjWXWCoOujzUws+agaZrbdYZXEijPNsSiedrWaq0BHG+UDA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=j2X0r2yTjTn6fAFxSxeb16h7a6eMtoAzPO+oaSDRUek=; b=Kb+nnaySTsOAx0Ejp5R9CGGTDg1jXYUGFoZ13+Y8nf+S/oaEqHG/VCA8hG2DDlfRaTOCJADjeDStif7lI4bKtxBzJUN1L33DhJYEx07hI9PTBjQ4hBj7yFoPCgVBhQ5uD7cg51j/wWKmMrBY8JIgf/hv9vVreq4492tmjKHdHYA= Original-Received: from SJ0PR10MB5488.namprd10.prod.outlook.com (2603:10b6:a03:37e::19) by CO1PR10MB4497.namprd10.prod.outlook.com (2603:10b6:303:9d::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.37; Fri, 6 Oct 2023 14:08:51 +0000 Original-Received: from SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::b7d5:c4af:24ca:f386]) by SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::b7d5:c4af:24ca:f386%4]) with mapi id 15.20.6838.033; Fri, 6 Oct 2023 14:08:51 +0000 Thread-Topic: [External] : bug#66187: read-file-name unexpected behavior when MUSTMATCH is a function Thread-Index: AQHZ+FXcycvvLGWk30ShwNYHkx3GKLA8yh1w In-Reply-To: Accept-Language: en-US Content-Language: en-US x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ0PR10MB5488:EE_|CO1PR10MB4497:EE_ x-ms-office365-filtering-correlation-id: 92878572-0844-4fe5-e216-08dbc675c478 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 4IGySQHQeye6YOavfKogEsUjNPeYpfoMnd+y6+wo1pupDvz8v+/J7Fl4nYTzbZRI18Sw3z3CWJ9hIen+pjqVEBMApjMSfDoVbW7G3q5bM/kMUc4SpziGg9KeMn342fu7g3AOWo37MSJ/AFP51cmxtt8361aBEg0K06INUwDJSHgOi1VD9x8xdADkjbHBlEmtUlraWz4ka4Txhi0T4nn9FNinhTCZDcI1Aw4TNfo244hq6j/DH0y7U7m5bmHjySiiNPvlrPJUcx84cdOHKlrPU/UB5/5PugVGSxJF7qH3yh973MInPQjRIh27oNSkfunavNs9vR/B1MBgHgKuMCbQwWmPjq6VlL/KbHSaNwDo0uNbBdUQztrcSPit4fmxVgDJ+apPNLYXwO5XgHUT3GvF4wQC7lwNphPPXEMzCqP5+IFInnDzrgz/oH1QiByk1sBW7mnrABA8CeSPgaGOo5Si6jyyacMZMflSgjcZ/XMDsmYZ18NK8aREQc75MHP5U3sLzU4v1cvDANds30m/ngOrVMENkCgyHATOCBiPKIxYjVUarehqg4LvctFNAFkzEOA3/NdRiL5B/OoB7V2nPqgsn74L0qkYh9I9PyJCfd0VSUlAy7KbWtp0FVJRO/AT6K0U x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR10MB5488.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(136003)(346002)(366004)(396003)(39860400002)(376002)(230922051799003)(64100799003)(451199024)(1800799009)(186009)(66476007)(66556008)(296002)(66446008)(64756008)(41300700001)(54906003)(66946007)(9686003)(33656002)(122000001)(71200400001)(26005)(7696005)(6506007)(38100700002)(38070700005)(83380400001)(478600001)(86362001)(76116006)(110136005)(55016003)(316002)(44832011)(2906002)(4326008)(8936002)(8676002)(52536014)(5660300002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: umg7p0Qw/U6+oW08yK1EwTEvKg0dr+uLkhu+kD0J7Xa1stMaqBUd+/jANxdmkM2205ecM0v3+cDLj4PbICVx4eyQf/nrzD8OPmjOqInolT9JZJP7w9V+7YsHrn6685ktQ0z6sw0DVP0PRuUwDJv/rdmoGoiht7TVnKqAxqTsSkBNBv3haGDxvLYRUS9yrosBpgzD2TgPm3IVKQ0hrt4/S9Fk3mIEphv8NDcQnwzf75QYDv28Sjy1fe7urdBfZ/5UcApKMGvyWGVB2wNdgpXhnmZgiCW1uUmQgLGXZVIgp75CzftsGTYDGzOONhYuRKsnvzwEsFulJIpcSqIykmr6/+gt+bW2SZJIfgO2Uh+Lnwy/JLDQQ3JsRh6v7+fYn6CkN5eokePocNCMSd+50LP9uVGWytPQ51jMPoFTTwGPuX+N7EK/QQCzZzbGMaL8TT9hROiTJAcw/q7GjuuOatFRzLlA65sGvafW3RVDAmMbOmUNFL8YmYSINfYLet//99fjcJYhW+etH1sHBxSdRA8+hejm9UNvGTigv7BYJn9VALi+oFO/PlY4M325AH2EfWvZ0WKc/UeLeqPW3HJKSMKQV/53Muhs2In7EnuqpZ8wgslKFRuDm5tI4UKJs33qbzaE/1Ia3jh9lmydMa5efMDhK6LnVhYP2k5QOHgGHTTGPlefCIO5w7rI3eWSJtHx2WtZCvy40A9DQpE0Uq96hOV+5uuR0dym3RF2azU+h/aVkPXyky3HqVXSdFpV/3 +LpVf7epDtK5IZhNZ2iOQb3lkSME2MhnxCfm4cIOkSxG5uTP4RxTTgV7nuPl3PXbSVf5tOjOrxi/0jjsQZNh58wrEkTyowwhSH X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: wnNU4y5mhdGp++Ssz3xP9nOELwR7CdBdiv+RAHBde0HDnI8GCtYbGhzeSp1N8lFcnupKxtjYuHxsV+xaZYbj94Y/KLufyXGtWoihmStHJnomjnjBQuWioplPqs5+4gH00aOc4EXheoo4HaNNjyTgX0Db46wiqJHC50jSfsdiZ0/fTuWHQRX40SMLmCcPeTDCDYZtBRArVFTz72yToENVqFZriNr4QDzqoawMM6aVmOcvh1OlMnWLYdnsdVm3/DUpl4JupKEfB5i5w76hRWQX7lnCamyLbf54RbFmEoTLSlVSk8HGELeKE4TpEkrF3xgArRLzWlX9MnET7YU4UkRxDliwGN2c2vZ+cN3wjWYgdLaA4NrSRjAxhmqtpnBPsiTzmWqUneOReCSwn7QNQAXgh8nNRWN8QyiyTm/bCRxKvnw4VLlrNZ8AMFDfd9qGKvqdmzXdznUdcR848rz1z5Xkudm/wWL9kIYv/gIT3AKH3gSQR5OYOpXrNQ8bB/69/LDmgvyvPMTi5/nLWEifNILg2IUYUbxkJhtjF0R5EfVO8VyFhI8pB5txbPzriD1n4WoLuzhi9FuMDF3izU92bWcQRhgt3M2gdBgIp0cid1IL7LTIPsvzDRFTpwfTzoDEFFEc297mj94GcL+CkavSgs+Rmovafq+WLiJnqvVx/75upjzkhbr28YdYPygrwG2KafKhe5B7crKhxmP88u2sqG4LezmrlXcEOMGGKHH/qAZXFXo953 Pf7euF0y22Et6G7KMjXoUym2yv0v2DnjInxyfgBh8KpqpV2dkDoOCwId0Spw5QViMvWheqrCSCT8Bfdc5HOaYsiezzsHrBu6zf X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB5488.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 92878572-0844-4fe5-e216-08dbc675c478 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Oct 2023 14:08:51.2688 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: sik9KVlgbsGdicERjZpk2coRUdyWomEyPemzi1FqHPSywaJW5O4E0AxHowlwMLK58J1qMJ9uNNaR4g/X7qUe8Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4497 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-10-06_12,2023-10-06_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxlogscore=765 suspectscore=0 malwarescore=0 spamscore=0 bulkscore=0 mlxscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2309180000 definitions=main-2310060104 X-Proofpoint-GUID: m_UtQ_0nvU7i-sEdF5PW9EJta7_pVHeW X-Proofpoint-ORIG-GUID: m_UtQ_0nvU7i-sEdF5PW9EJta7_pVHeW X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:271951 Archived-At: > (we've had `require-match` for more than 30 years > and it's only last year that we decided it was > worth generalizing it to a function) ^^^^^^^^^^^^ It was decided with very little discussion, FWIW. The 29.1 behavior is not at all more general than the longstanding previous behavior. Just the opposite. It confuses different things, co-opting the REQUIRE-MATCH behavior with completion behavior. All code that previously might have passed a function value for REQUIRE-MATCH expects that value to be treated as any other non-`nil', non-`t', non-`confirm*' value. That's now broken. That more general behavior is lost - a function value being treated differently imposes a limitation - the behavior is more specific now (another case added), not more general. The new behavior that was cobbled together into the REQUIRE-MATCH arg should have been provided in some other way - whether an additional arg, or a non-arg variable, or whatever. It should not have been jammed into REQUIRE-MATCH, changing its behavior in an incompatible way. (Just one opinion.)