unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: Juri Linkov <juri@linkov.net>,
	"49534@debbugs.gnu.org" <49534@debbugs.gnu.org>
Subject: bug#49534: 26.3; Isearch should support using filter predicates with empty search hits
Date: Wed, 16 Feb 2022 04:20:40 +0000	[thread overview]
Message-ID: <SJ0PR10MB54887545F6AB7CFA293A87F6F3359@SJ0PR10MB5488.namprd10.prod.outlook.com> (raw)
In-Reply-To: <SJ0PR10MB5488D606F5F4E9EACB351B5BF3159@SJ0PR10MB5488.namprd10.prod.outlook.com>

(Resending after unarchiving.)

Juri, could you please answer the questions
I asked you here?  Thx.

> > > Your code (in master) removes that boundary test
> > > altogether (no `bobp' or `eobp' test).  Why is
> > > that the right thing?  Is it because the match
> > > should be allowed to match up to `bobp' or `eobp'?
> > > If so, why was that test in isearch.el in the
> > > first place?
> >
> > If you think that you found a problem, please provide
> > a test that exposes it.
> 
> I'm asking why you removed that boundary test.
> And peripherally, why it was there to begin with?

ping.  I'd really like to know.

> > > Actually, you do still test for reaching the
> > > boundary, but only for an empty match and after
> > > filter failure.  Why is that?
> >
> > Please provide a test case if you think there is a problem.
> 
> I'm asking why you test for reaching the boundary,
> and only for an empty match and after a filter
> failure.

ping.  I'd really like to know.
 
> > > And why do you not need to back up a char after
> > > the loop, if the match was empty the last time
> > > around and the next time it fails?  It'll have
> > > advanced a char; should it stay there instead
> > > of backing up?  (Dunno, but I supposed not.)
> >
> > Please provide more tests that confirm your doubts.
> 
> I'm asking why you don't need to back up a char
> after having advanced a char in that case.

ping.  I'd really like to know.





  parent reply	other threads:[~2022-02-16  4:20 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-12 14:34 bug#49534: 26.3; Isearch should support using filter predicates with empty search hits Drew Adams
2021-07-13 16:27 ` Lars Ingebrigtsen
2021-07-13 19:25   ` Juri Linkov
2021-07-13 20:20     ` Juri Linkov
2021-07-13 20:41       ` Lars Ingebrigtsen
2021-07-13 22:30         ` Juri Linkov
2021-07-13 21:42       ` bug#49534: [External] : " Drew Adams
2021-07-13 22:30         ` Juri Linkov
2021-07-13 23:00           ` Drew Adams
2021-07-13 22:48       ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-07-13 23:21         ` Juri Linkov
2021-07-13 21:44     ` bug#49534: [External] : " Drew Adams
2021-07-13 22:31       ` Juri Linkov
2021-07-13 23:04         ` Drew Adams
2022-02-16  4:20 ` Drew Adams [this message]
2022-02-16 18:20   ` Juri Linkov
2022-02-16 18:54     ` bug#49534: [External] : " Drew Adams
2022-02-16 19:09       ` Juri Linkov
2022-02-16 19:17         ` Drew Adams
2022-02-16 19:25           ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SJ0PR10MB54887545F6AB7CFA293A87F6F3359@SJ0PR10MB5488.namprd10.prod.outlook.com \
    --to=drew.adams@oracle.com \
    --cc=49534@debbugs.gnu.org \
    --cc=juri@linkov.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).