From: Juri Linkov <juri@linkov.net>
To: Drew Adams <drew.adams@oracle.com>
Cc: Lars Ingebrigtsen <larsi@gnus.org>,
"49534@debbugs.gnu.org" <49534@debbugs.gnu.org>
Subject: bug#49534: [External] : bug#49534: 26.3; Isearch should support using filter predicates with empty search hits
Date: Wed, 14 Jul 2021 01:30:36 +0300 [thread overview]
Message-ID: <87pmvl3kz7.fsf@mail.linkov.net> (raw)
In-Reply-To: <SJ0PR10MB5488730CA6D38697EFE9013FF3149@SJ0PR10MB5488.namprd10.prod.outlook.com> (Drew Adams's message of "Tue, 13 Jul 2021 21:42:00 +0000")
>> What would be better: to remember its result in a let-bound variable,
>> or to use save-match-data? Probably, save-match-data:
>
> Yes, that's probably the right thing; good catch.
> ___
>
> [On the other hand, a filter predicate can really
> do more than just act as a predicate (it can
> perform useful side effects). There could
> presumably be reasons we'd want to let it change
> the match data.
>
> No, I don't have any concrete use case in mind;
> and yes, without some other changes, that could
> mess up code that follows using the predicate.
> I just wonder about further restricting the
> predicate. The point of this bug fix was to
> _remove_ an unnecessary restriction, but now
> we're adding another restriction. ;-)]
If you want to mess with the match data,
you can use own isearch-search-fun-function.
next prev parent reply other threads:[~2021-07-13 22:30 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-12 14:34 bug#49534: 26.3; Isearch should support using filter predicates with empty search hits Drew Adams
2021-07-13 16:27 ` Lars Ingebrigtsen
2021-07-13 19:25 ` Juri Linkov
2021-07-13 20:20 ` Juri Linkov
2021-07-13 20:41 ` Lars Ingebrigtsen
2021-07-13 22:30 ` Juri Linkov
2021-07-13 21:42 ` bug#49534: [External] : " Drew Adams
2021-07-13 22:30 ` Juri Linkov [this message]
2021-07-13 23:00 ` Drew Adams
2021-07-13 22:48 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-07-13 23:21 ` Juri Linkov
2021-07-13 21:44 ` bug#49534: [External] : " Drew Adams
2021-07-13 22:31 ` Juri Linkov
2021-07-13 23:04 ` Drew Adams
2022-02-16 4:20 ` Drew Adams
2022-02-16 18:20 ` Juri Linkov
2022-02-16 18:54 ` bug#49534: [External] : " Drew Adams
2022-02-16 19:09 ` Juri Linkov
2022-02-16 19:17 ` Drew Adams
2022-02-16 19:25 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pmvl3kz7.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=49534@debbugs.gnu.org \
--cc=drew.adams@oracle.com \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).