From: Drew Adams <drew.adams@oracle.com>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: "52877@debbugs.gnu.org" <52877@debbugs.gnu.org>
Subject: bug#52877: [External] : Re: bug#52877: 27.2; Let `use-dialog-box' apply to more than just yes/no questions
Date: Sat, 15 Jan 2022 22:12:05 +0000 [thread overview]
Message-ID: <SJ0PR10MB548866A7A7BE97D4EE417716F3559@SJ0PR10MB5488.namprd10.prod.outlook.com> (raw)
In-Reply-To: <87r199wc44.fsf@gnus.org>
> > A starting point is to redefine commands such as `menu-set-font', to
> > respect `use-dialog-box'. For example:
> >
> > (defun menu-set-font ()
> > "Interactively select a font and make it the default on all frames.
> > The selected font will be the default on both the existing and future
> > frames."
> > (interactive)
> > (if use-dialog-box
> > (menu-set-font)
> > (call-interactively #'set-frame-font-all)))
>
> If use-dialog-box is set, you want menu-set-font to call itself?
The call inside the function should have been
`(current-definition-of-menu-set-font)'.
> In any case, the current definition is:...
Which is pretty much what it's always been.
> So it uses a graphical chooser by default, no matter whether
> use-dialog-box is set or not.
Exactly. That's exactly the limitation this
enhancement request asks to remove. Let _users_
control whether it uses a graphical chooser
or not - exactly what `use-dialog-box' is for.
The limitation is that `use-dialog-box' currently
is usable only with `yes-or-no' questions.
Clearly the `set-frame-font-all' code I showed,
together with the `use-dialog-box' test, should
have clued you in to what's being requested.
Alas, it apparently did not.
> So I don't think there's anything to fix
> here, and I'm closing this bug report.
Too bad. This enhancement is not at all about
only `menu-set-font' - that was an illustration.
In your zeal to pointing out the typo in the
the `menu-set-font' definition did you perhaps
overlook the whole point?
next prev parent reply other threads:[~2022-01-15 22:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-29 17:47 bug#52877: 27.2; Let `use-dialog-box' apply to more than just yes/no questions Drew Adams
2022-01-15 10:02 ` Lars Ingebrigtsen
2022-01-15 22:12 ` Drew Adams [this message]
2022-01-16 8:50 ` bug#52877: [External] : " Eli Zaretskii
2022-01-16 22:13 ` Drew Adams
2022-01-17 12:47 ` Eli Zaretskii
2022-01-17 17:18 ` Drew Adams
2022-01-17 17:34 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SJ0PR10MB548866A7A7BE97D4EE417716F3559@SJ0PR10MB5488.namprd10.prod.outlook.com \
--to=drew.adams@oracle.com \
--cc=52877@debbugs.gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).