unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Drew Adams <drew.adams@oracle.com>
Cc: 52877@debbugs.gnu.org
Subject: bug#52877: 27.2; Let `use-dialog-box' apply to more than just yes/no questions
Date: Sat, 15 Jan 2022 11:02:19 +0100	[thread overview]
Message-ID: <87r199wc44.fsf@gnus.org> (raw)
In-Reply-To: <SJ0PR10MB5488E038243B55C1DA1B10B6F3449@SJ0PR10MB5488.namprd10.prod.outlook.com> (Drew Adams's message of "Wed, 29 Dec 2021 17:47:19 +0000")

Drew Adams <drew.adams@oracle.com> writes:

> A starting point is to redefine commands such as `menu-set-font', to
> respect `use-dialog-box'.  For example:
>
> (defun menu-set-font ()
>   "Interactively select a font and make it the default on all frames.
> The selected font will be the default on both the existing and future frames."
>   (interactive)
>   (if use-dialog-box
>       (menu-set-font)
>     (call-interactively #'set-frame-font-all)))

If use-dialog-box is set, you want menu-set-font to call itself?

In any case, the current definition is:

(defun menu-set-font ()
  "Interactively select a font and make it the default on all frames.

The selected font will be the default on both the existing and future frames."
  (interactive)
  (set-frame-font (if (fboundp 'x-select-font)
		      (x-select-font)
		    (mouse-select-font))
		  nil t))

So it uses a graphical chooser by default, no matter whether
use-dialog-box is set or not.  So I don't think there's anything to fix
here, and I'm closing this bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





  reply	other threads:[~2022-01-15 10:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-29 17:47 bug#52877: 27.2; Let `use-dialog-box' apply to more than just yes/no questions Drew Adams
2022-01-15 10:02 ` Lars Ingebrigtsen [this message]
2022-01-15 22:12   ` bug#52877: [External] : " Drew Adams
2022-01-16  8:50     ` Eli Zaretskii
2022-01-16 22:13       ` Drew Adams
2022-01-17 12:47         ` Eli Zaretskii
2022-01-17 17:18           ` Drew Adams
2022-01-17 17:34             ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r199wc44.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=52877@debbugs.gnu.org \
    --cc=drew.adams@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).