* bug#54114: 26.3; Doc of `face-remap-add-relative' in (elisp) `Face Remapping'
@ 2022-02-22 17:22 Drew Adams
2022-02-22 17:45 ` Eli Zaretskii
0 siblings, 1 reply; 5+ messages in thread
From: Drew Adams @ 2022-02-22 17:22 UTC (permalink / raw)
To: 54114
In this text:
-- Function: face-remap-add-relative face &rest specs
This function adds the face spec in SPECS as relative remappings
for face FACE in the current buffer. The remaining arguments,
SPECS, should form either a list of face names, or a property list
of attribute/value pairs.
please consider removing this: "The remaining arguments,".
This should just say "SPECS should form...".
SPECS and FACE were already introduced in the first sentence. And the
`&rest' makes clear that SPECS is the remaining args _after argument
FACE_. Talking about "remaining arguments out of the blue, without
saying they are what come ("remain") _after FACE_, is not
comprehensible.
In GNU Emacs 26.3 (build 1, x86_64-w64-mingw32)
of 2019-08-29
Repository revision: 96dd0196c28bc36779584e47fffcca433c9309cd
Windowing system distributor `Microsoft Corp.', version 10.0.19043
Configured using:
`configure --without-dbus --host=x86_64-w64-mingw32
--without-compress-install 'CFLAGS=-O2 -static -g3''
^ permalink raw reply [flat|nested] 5+ messages in thread* bug#54114: 26.3; Doc of `face-remap-add-relative' in (elisp) `Face Remapping' 2022-02-22 17:22 bug#54114: 26.3; Doc of `face-remap-add-relative' in (elisp) `Face Remapping' Drew Adams @ 2022-02-22 17:45 ` Eli Zaretskii 2022-02-22 18:32 ` bug#54114: [External] : " Drew Adams 2022-02-23 11:59 ` Lars Ingebrigtsen 0 siblings, 2 replies; 5+ messages in thread From: Eli Zaretskii @ 2022-02-22 17:45 UTC (permalink / raw) To: Drew Adams; +Cc: 54114 > From: Drew Adams <drew.adams@oracle.com> > Date: Tue, 22 Feb 2022 17:22:32 +0000 > > In this text: > > -- Function: face-remap-add-relative face &rest specs > This function adds the face spec in SPECS as relative remappings > for face FACE in the current buffer. The remaining arguments, > SPECS, should form either a list of face names, or a property list > of attribute/value pairs. > > please consider removing this: "The remaining arguments,". > This should just say "SPECS should form...". I don't see any reason to make such a change, FWIW. ^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#54114: [External] : Re: bug#54114: 26.3; Doc of `face-remap-add-relative' in (elisp) `Face Remapping' 2022-02-22 17:45 ` Eli Zaretskii @ 2022-02-22 18:32 ` Drew Adams 2022-02-23 11:59 ` Lars Ingebrigtsen 1 sibling, 0 replies; 5+ messages in thread From: Drew Adams @ 2022-02-22 18:32 UTC (permalink / raw) To: Eli Zaretskii; +Cc: 54114@debbugs.gnu.org > I don't see any reason to make such a change, FWIW. English. That's the reason. There's no clear antecedent to "the remaining arguments". And SPECS is already identified. ___ This is also poor: "the face spec in SPECS". Presumably you want to say "each face spec in SPECS" or "the face specs in SPECS". The current text suggests that there's exactly one face spec in SPECS, in spite of the plural name. ^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#54114: 26.3; Doc of `face-remap-add-relative' in (elisp) `Face Remapping' 2022-02-22 17:45 ` Eli Zaretskii 2022-02-22 18:32 ` bug#54114: [External] : " Drew Adams @ 2022-02-23 11:59 ` Lars Ingebrigtsen 2022-02-23 16:10 ` bug#54114: [External] : " Drew Adams 1 sibling, 1 reply; 5+ messages in thread From: Lars Ingebrigtsen @ 2022-02-23 11:59 UTC (permalink / raw) To: Eli Zaretskii; +Cc: 54114 Eli Zaretskii <eliz@gnu.org> writes: > I don't see any reason to make such a change, FWIW. The entry seems somewhat hard to parse, so I've now reworded it in the emacs-28 manual. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no ^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#54114: [External] : Re: bug#54114: 26.3; Doc of `face-remap-add-relative' in (elisp) `Face Remapping' 2022-02-23 11:59 ` Lars Ingebrigtsen @ 2022-02-23 16:10 ` Drew Adams 0 siblings, 0 replies; 5+ messages in thread From: Drew Adams @ 2022-02-23 16:10 UTC (permalink / raw) To: Lars Ingebrigtsen, Eli Zaretskii; +Cc: 54114@debbugs.gnu.org > > I don't see any reason to make such a change, FWIW. > > The entry seems somewhat hard to parse, so I've now reworded it in the > emacs-28 manual. Yes, the improvement helps. Thx. ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-02-23 16:10 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2022-02-22 17:22 bug#54114: 26.3; Doc of `face-remap-add-relative' in (elisp) `Face Remapping' Drew Adams 2022-02-22 17:45 ` Eli Zaretskii 2022-02-22 18:32 ` bug#54114: [External] : " Drew Adams 2022-02-23 11:59 ` Lars Ingebrigtsen 2022-02-23 16:10 ` bug#54114: [External] : " Drew Adams
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).