From: HaiJun Zhang <netjune@outlook.com>
To: Alan Third <alan@idiocy.org>, tsuucat <tsuucat@icloud.com>
Cc: 23412@debbugs.gnu.org
Subject: bug#23412: 25.1.50; GUI Emacs on Mac OS X: text is keeping shaking/re-displaying when insert text with external input method
Date: Thu, 19 Dec 2019 10:05:59 +0800 [thread overview]
Message-ID: <PS1PR03MB3606198BF46EC25FF64B34EFB7520@PS1PR03MB3606.apcprd03.prod.outlook.com> (raw)
In-Reply-To: <C7692E58-8FB4-4286-94A8-BA337D9C76CF@icloud.com>
[-- Attachment #1: Type: text/plain, Size: 1275 bytes --]
Since the working text is not the final text to insert to buffer, how about displaying it using after-string property of overlay? Such as:
(overlay-put (setq ns-working-overlay (make-overlay start (point)))
‘after-string (propertize ns-working-text ‘face 'ns-working-text-face))
在 2019年12月19日 +0800 AM8:32,tsuucat via Bug reports for GNU Emacs, the Swiss army knife of text editors <bug-gnu-emacs@gnu.org>,写道:
>
> > Can I ask what this change does?
> >
> > - (overlay-put (setq ns-working-overlay (make-overlay start (point)
> > - (current-buffer) nil t))
> > + (overlay-put (setq ns-working-overlay (make-overlay start (point)))
>
>
> At first I thought it would be fixed just by moving [self deleteWorkingText] in nsterm.m.
> However as a result insertText (ex: pressing RET to input selected candidates) left nothing.
>
> That’s because ns-delete-working-text (by [self deleteWorkingText]) delete all inserted
> chars including chars inserted by insertText-emited normal input events. This patch prevent
> ns-working-overlay expanding its size in insertText.
>
>
> Unfortunately I found the patch change behavior of undo worse. So NS-spesific patch should
> have further modification.
>
> --
> tsuucat
>
>
>
>
[-- Attachment #2: Type: text/html, Size: 1994 bytes --]
next prev parent reply other threads:[~2019-12-19 2:05 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bebc4ca8-0a58-4ea0-8fb1-4dbb6d18e335@Spark>
2016-05-01 8:54 ` bug#23412: 25.1.50; GUI Emacs on Mac OS X: text is keeping shaking/re-displaying when insert text with external input method Chunyang Xu
2016-05-01 15:07 ` Eli Zaretskii
2016-05-01 15:35 ` Chunyang Xu
2016-05-27 19:16 ` Alan Third
2016-05-27 20:13 ` Chunyang Xu
2017-04-26 17:43 ` hylom
2017-05-01 12:26 ` bug#23412: Can this bug be fixed now? 张海君
2019-10-27 11:49 ` bug#23412: 25.1.50; GUI Emacs on Mac OS X: text is keeping shaking/re-displaying when insert text with external input method HaiJun Zhang
2019-10-28 11:26 ` Alan Third
2019-10-29 13:24 ` HaiJun Zhang
2019-10-29 19:20 ` Alan Third
2019-10-30 1:15 ` HaiJun Zhang
2019-10-31 20:53 ` Alan Third
2019-12-05 11:21 ` Stefan Kangas
2019-12-05 14:43 ` Alan Third
2019-12-04 11:19 ` bug#23412: tsuucat via Bug reports for GNU Emacs, the Swiss army knife of text editors
2019-12-04 22:50 ` bug#23412: HaiJun Zhang
2019-12-17 9:18 ` bug#23412: 25.1.50; GUI Emacs on Mac OS X: text is keeping shaking/re-displaying when insert text with external input method tsuucat via Bug reports for GNU Emacs, the Swiss army knife of text editors
2019-12-17 20:28 ` Alan Third
2019-12-18 15:55 ` tsuucat via Bug reports for GNU Emacs, the Swiss army knife of text editors
2019-12-18 20:44 ` Alan Third
2019-12-19 0:31 ` tsuucat via Bug reports for GNU Emacs, the Swiss army knife of text editors
2019-12-19 2:05 ` HaiJun Zhang [this message]
2019-12-19 5:57 ` tsuucat via Bug reports for GNU Emacs, the Swiss army knife of text editors
2019-12-19 6:14 ` HaiJun Zhang
2019-12-19 6:22 ` HaiJun Zhang
2019-12-19 7:02 ` HaiJun Zhang
2019-12-21 22:54 ` Alan Third
2019-12-22 3:33 ` Eli Zaretskii
2019-12-22 7:24 ` tsuucat via Bug reports for GNU Emacs, the Swiss army knife of text editors
2019-12-22 11:51 ` Alan Third
2019-12-22 17:14 ` Eli Zaretskii
2019-12-22 11:32 ` HaiJun Zhang
2019-12-22 12:02 ` Alan Third
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PS1PR03MB3606198BF46EC25FF64B34EFB7520@PS1PR03MB3606.apcprd03.prod.outlook.com \
--to=netjune@outlook.com \
--cc=23412@debbugs.gnu.org \
--cc=alan@idiocy.org \
--cc=tsuucat@icloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).