bug#23412: 25.1.50; GUI Emacs on Mac OS X: text is keeping shaking/re-displaying when insert text with external input method

[Alan Third <alan@idiocy.org>]

[-- Attachment #1: Type: text/plain, Size: 394 bytes --]

On Sun, Oct 27, 2019 at 11:49:20AM +0000, HaiJun Zhang wrote:
> After some debugging work, I think I find the cause.
> 
> See the discussion: https://lists.gnu.org/archive/html/emacs-devel/2019-10/msg01096.html

Thanks for working this out. I suspect that we can remove a call to
delete the working text from the C code and just leave it to lisp.

Please try the attached patch.
-- 
Alan Third

[-- Attachment #2: 0001-Prevent-flicker-with-macOS-input-methods-bug-23412.patch --]
[-- Type: text/plain, Size: 812 bytes --]

From 201a496eb011ccc3a630fe9fa8d69da58a13b469 Mon Sep 17 00:00:00 2001
From: Alan Third <alan@idiocy.org>
Date: Mon, 28 Oct 2019 11:21:29 +0000
Subject: [PATCH] Prevent flicker with macOS input methods (bug#23412)

* src/nsterm.m ([EmacsView setMarkedText:selectedRange:]): Don't
delete the working text as ns-put-working-text does that anyway.
---
 src/nsterm.m | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/nsterm.m b/src/nsterm.m
index 5583c6105c..2622242071 100644
--- a/src/nsterm.m
+++ b/src/nsterm.m
@@ -6435,8 +6435,6 @@ - (void)setMarkedText: (id)aString selectedRange: (NSRange)selRange
            (unsigned long)selRange.length,
            (unsigned long)selRange.location);
 
-  if (workingText != nil)
-    [self deleteWorkingText];
   if ([str length] == 0)
     return;
 
-- 
2.21.0