* bug#2870: 23.0.91; Cursor face not changing
@ 2009-04-02 22:33 Chong Yidong
2009-05-31 15:27 ` bug#3434: " Adrian Robert
0 siblings, 1 reply; 4+ messages in thread
From: Chong Yidong @ 2009-04-02 22:33 UTC (permalink / raw)
To: Adrian Robert; +Cc: emacs-pretest-bug, Alberto Simões
> Although I am able to configure the cursor face using the usual
> custumization tool, the real colors/face doesn't change.
>
> While the customization tool added to my .emacs the line:
> '(cursor ((t (:background "wheat" :foreground "black"))))
>
> under the faces configuration command, when emacs starts I get back
> the original cursor colors (that are just annoying because I can't see
> the character behind the cursor).
>
> Oh, This emacs is compiled by me, from cvs (about 15 days ago), under
> MacOS/NS.
I can't reproduce this, so it's likely a bug on NS. Adrian, can you
reproduce it?
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#3434: 23.0.91; Cursor face not changing
2009-04-02 22:33 bug#2870: 23.0.91; Cursor face not changing Chong Yidong
@ 2009-05-31 15:27 ` Adrian Robert
2009-08-18 20:56 ` bug#4194: " Nikolaj Schumacher
0 siblings, 1 reply; 4+ messages in thread
From: Adrian Robert @ 2009-05-31 15:27 UTC (permalink / raw)
To: Chong Yidong; +Cc: emacs-pretest-bug, Alberto Simões, Nikolaj Schumacher
On Apr 3, 2009, at 5:33 AM, Chong Yidong wrote:
>> Although I am able to configure the cursor face using the usual
>> custumization tool, the real colors/face doesn't change.
>>
>> While the customization tool added to my .emacs the line:
>> '(cursor ((t (:background "wheat" :foreground "black"))))
>>
>> under the faces configuration command, when emacs starts I get back
>> the original cursor colors (that are just annoying because I can't
>> see
>> the character behind the cursor).
>>
>> Oh, This emacs is compiled by me, from cvs (about 15 days ago), under
>> MacOS/NS.
>
> I can't reproduce this, so it's likely a bug on NS. Adrian, can you
> reproduce it?
I cannot.
Nikolaj Schumacher added later that:
> The same seems to happen for the region face. The background color
> reverts to ns_selection_color sometime after the custom variables are
> read. (It works when reading the custom settings again, later.)
I looked at the code and cannot see how this could be happening. The
region face is set to ns_selection_color in ns-win.el, but this
should be overridden by .emacs read later. This should have been
cleared up by David Reitter's changes around 2009-03-14, though since
the ChangeLog entries are incomplete it is difficult to be certain
when the last broken code was removed.
Anyway, if you still observe these in a recent build let me know and
I'll go on a more thorough witch-hunt.
thanks,
Adrian
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#4194: 23.0.91; Cursor face not changing
2009-05-31 15:27 ` bug#3434: " Adrian Robert
@ 2009-08-18 20:56 ` Nikolaj Schumacher
2011-11-17 0:17 ` Glenn Morris
0 siblings, 1 reply; 4+ messages in thread
From: Nikolaj Schumacher @ 2009-08-18 20:56 UTC (permalink / raw)
To: Adrian Robert; +Cc: emacs-pretest-bug, Chong Yidong, Alberto Simões
Sorry for the delay. I checked this again using a build from today.
On 2009-05-31, at 17:27, Adrian Robert wrote:
> On Apr 3, 2009, at 5:33 AM, Chong Yidong wrote:
>
>>> Although I am able to configure the cursor face using the usual
>>> custumization tool, the real colors/face doesn't change.
>>
>> I can't reproduce this, so it's likely a bug on NS. Adrian, can you
>> reproduce it?
>
> I cannot.
Setting the background color seems to work now. The foreground color,
inverse-video, and others don't stick.
> Nikolaj Schumacher added later that:
>
>> The same seems to happen for the region face. The background color
>> reverts to ns_selection_color sometime after the custom variables are
>> read. (It works when reading the custom settings again, later.)
>
> I looked at the code and cannot see how this could be happening.
> The region face is set to ns_selection_color in ns-win.el, but this
> should be overridden by .emacs read later. This should have been
> cleared up by David Reitter's changes around 2009-03-14, though
> since the ChangeLog entries are incomplete it is difficult to be
> certain when the last broken code was removed.
>
> Anyway, if you still observe these in a recent build let me know and
> I'll go on a more thorough witch-hunt.
I've looked at this further, and it seems to work with an empty .emacs.
It fails with my configuration, because I set the frame's background
color like this:
(setq default-frame-alist
'((background-color . "#040420")
(foreground-color . "wheat")))
If I don't set the background-color, I get my customized region face.
If I manually evaluate the line after the initial frame was created,
any additional frame uses the default ns_selection_color for the
region. The first frame and customize-face keep my color.
Nik
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#4194: 23.0.91; Cursor face not changing
2009-08-18 20:56 ` bug#4194: " Nikolaj Schumacher
@ 2011-11-17 0:17 ` Glenn Morris
0 siblings, 0 replies; 4+ messages in thread
From: Glenn Morris @ 2011-11-17 0:17 UTC (permalink / raw)
To: 4194-done
Version: 24.1
Nikolaj Schumacher wrote:
> Setting the background color seems to work now. The foreground color,
> inverse-video, and others don't stick.
In Emacs 24, the doc for the cursor face will say:
Currently, only the `:background' attribute is meaningful; all
other attributes are ignored.
With regards to the region face:
> This bug is easily fixed by changing the following line in ns-win.el:
>
> (set-face-background 'region "ns_selection_color")
This line was removed from ns-win some time ago, so I imagine this is
fixed too.
Please open a new report if there are still issues in the latest version.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-11-17 0:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-04-02 22:33 bug#2870: 23.0.91; Cursor face not changing Chong Yidong
2009-05-31 15:27 ` bug#3434: " Adrian Robert
2009-08-18 20:56 ` bug#4194: " Nikolaj Schumacher
2011-11-17 0:17 ` Glenn Morris
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).