unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Yuan Fu <casouri@gmail.com>
To: Knut Anders Hatlen <kahatlen@gmail.com>
Cc: 60397@debbugs.gnu.org
Subject: bug#60397: 29.0.60; c++-ts-mode could report better defun names
Date: Sun, 1 Jan 2023 16:27:08 -0800	[thread overview]
Message-ID: <F92AE86B-A945-4823-9E59-10CC5C265961@gmail.com> (raw)
In-Reply-To: <87358yejw4.fsf@oracle.com>


Knut Anders Hatlen <kahatlen@gmail.com> writes:

> The defun names reported by c++-ts-mode could still need a couple of
> improvements:
>
> 1) In a buffer with c++-ts-mode and which-function-mode enabled, and
> this content:
>
> struct S {
>   int f1(int x) {
>     return x + 1;
>   }
>   int g1(int x);
> };
>
> int S::g1(int x) {
>   return x + 1;
> }
>
> Inside the inline f1 function definition, which-function-mode shows
> "S.f1". But inside the out-of-line g1 function definition, it shows
> "n/a" instead of "S.g1". (Not limited to structs. Classes have the same
> problem.)
>
> 2) Namespaces are not handled. Given this content:
>
> namespace n {
> int f1(int x) {
>   return x + 1;
> }
> }
>
> namespace {
> int f2(int x) {
>   return x + 1;
> }
> }
>
> Inside the f1 and f2 function bodies, which-function-mode shows "f1" and
> "f2", respectively. It would be better if it showed "n.f1" for the
> former, and perhaps something like "(anonymous).f2" for the latter.

Thanks for the report. I’ll work on this :-)

Yuan





  reply	other threads:[~2023-01-02  0:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-29  7:42 bug#60397: 29.0.60; c++-ts-mode could report better defun names Knut Anders Hatlen
2023-01-02  0:27 ` Yuan Fu [this message]
2023-01-08  0:06 ` Yuan Fu
2023-01-08  7:05   ` Knut Anders Hatlen
2023-01-17  9:39 ` Yuan Fu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=F92AE86B-A945-4823-9E59-10CC5C265961@gmail.com \
    --to=casouri@gmail.com \
    --cc=60397@debbugs.gnu.org \
    --cc=kahatlen@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).