From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#60397: 29.0.60; c++-ts-mode could report better defun names Date: Sun, 1 Jan 2023 16:27:08 -0800 Message-ID: References: <87358yejw4.fsf@oracle.com> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36203"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60397@debbugs.gnu.org To: Knut Anders Hatlen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jan 02 01:28:15 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pC8gY-00099r-AS for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 02 Jan 2023 01:28:14 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pC8gO-0006Mq-DY; Sun, 01 Jan 2023 19:28:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pC8gM-0006KI-Tt for bug-gnu-emacs@gnu.org; Sun, 01 Jan 2023 19:28:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pC8gM-0000K5-Iy for bug-gnu-emacs@gnu.org; Sun, 01 Jan 2023 19:28:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pC8gM-0006ke-Eu for bug-gnu-emacs@gnu.org; Sun, 01 Jan 2023 19:28:02 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: <87358yejw4.fsf@oracle.com> Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 02 Jan 2023 00:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60397 X-GNU-PR-Package: emacs Original-Received: via spool by 60397-submit@debbugs.gnu.org id=B60397.167261923725886 (code B ref 60397); Mon, 02 Jan 2023 00:28:02 +0000 Original-Received: (at 60397) by debbugs.gnu.org; 2 Jan 2023 00:27:17 +0000 Original-Received: from localhost ([127.0.0.1]:42036 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pC8fc-0006jR-TW for submit@debbugs.gnu.org; Sun, 01 Jan 2023 19:27:17 -0500 Original-Received: from mail-pj1-f52.google.com ([209.85.216.52]:44963) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pC8fa-0006jC-Lg for 60397@debbugs.gnu.org; Sun, 01 Jan 2023 19:27:15 -0500 Original-Received: by mail-pj1-f52.google.com with SMTP id o31-20020a17090a0a2200b00223fedffb30so26907867pjo.3 for <60397@debbugs.gnu.org>; Sun, 01 Jan 2023 16:27:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:from:to:cc:subject:date:message-id :reply-to; bh=YFgfSWGFdIcDrgrDim+UXCIFJqOLvo4QQJLFPdQdp48=; b=qNEZ7S5M/TcLcDoljv3AuCvrXrjM3gdFQV7u/xESrZoQAnd1aPQYvvayNEPiqWnCCz gJWsDlRqZBhbOhFPiksf88P7oKOODprWFwIfJolGQU2sY1414B4K/wtvkg3iHkCT6HyV rlbWcNupwAUugX9WW4Xoy4iwFzjJDg3IuFuM7kgQVdWfWfpwbytI+2d4bV4G0EetmNLE UwykAN1OoLLBHet9c66Scet6GcUuzdUzA826tfF8PfVhK45IYgtdsXhQ0WyvlTAEwzuF UmiAHpFqgdDg28xQLpdlWQ1R3v7QE8U/1qqI8VrGI2shqZbGaJUe+sG6y8Y8SuCiCgko qMnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YFgfSWGFdIcDrgrDim+UXCIFJqOLvo4QQJLFPdQdp48=; b=Lw5pEGlQI5KhE7iDvCOd1n+zrKfRZ1UdqejZ99SZvcOYAxdgBGnlYqKFkHPZwiqP99 PrMXk7FBMy6xMuGy/Z9lNWxkxIJfKusPwjCyRxen1EeAN82cZKT3MoY248MmO2Zr6gNx qkwnx4dUZBpV+RtHAS27jeGUd1u6DcxZAjC5wl6TxRZgdu8hzLqxCW5JUekvaF2q1B/P Fsp+eLwsidSIq9fHpLsOA0TnJoaD0NwI9Q9dKC1T3z5mh6diBonTo0U4RS0rK5HAD69J r/eRk4jk34hkMB5+/U+G1WH+24QzQbB31G/FF5DDnT/bo0meYvlbNxw/OSpKiYNK3AsS dkQw== X-Gm-Message-State: AFqh2kpyiCBgM2QnmS2vydvpkvwJsnHX2HrRLuVqz1gdbv/kOqL4TD1X 2EMb6r5nYAbKUOi2+ayCe004dG8NLGdaZA== X-Google-Smtp-Source: AMrXdXuLOW/H06URQZWh87ZkAoCxcTGRVNVadVzIPBZXC+DCx3Um8IUZOx/DPV5AS1ZAKQ5Ep6BDHg== X-Received: by 2002:a05:6a20:b297:b0:9d:efbf:7880 with SMTP id ei23-20020a056a20b29700b0009defbf7880mr41790591pzb.53.1672619228995; Sun, 01 Jan 2023 16:27:08 -0800 (PST) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id 13-20020a62180d000000b0057737e403d9sm17081476pfy.209.2023.01.01.16.27.08 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 01 Jan 2023 16:27:08 -0800 (PST) X-Mailer: Apple Mail (2.3696.120.41.1.1) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:252299 Archived-At: Knut Anders Hatlen writes: > The defun names reported by c++-ts-mode could still need a couple of > improvements: > > 1) In a buffer with c++-ts-mode and which-function-mode enabled, and > this content: > > struct S { > int f1(int x) { > return x + 1; > } > int g1(int x); > }; > > int S::g1(int x) { > return x + 1; > } > > Inside the inline f1 function definition, which-function-mode shows > "S.f1". But inside the out-of-line g1 function definition, it shows > "n/a" instead of "S.g1". (Not limited to structs. Classes have the = same > problem.) > > 2) Namespaces are not handled. Given this content: > > namespace n { > int f1(int x) { > return x + 1; > } > } > > namespace { > int f2(int x) { > return x + 1; > } > } > > Inside the f1 and f2 function bodies, which-function-mode shows "f1" = and > "f2", respectively. It would be better if it showed "n.f1" for the > former, and perhaps something like "(anonymous).f2" for the latter. Thanks for the report. I=E2=80=99ll work on this :-) Yuan