bug#4933: 23.1.50; RCS buffer: save-buffer moves point to beginning of buffer

bug#4933: 23.1.50; RCS buffer: save-buffer moves point to beginning of buffer

[Carsten Bormann]

Start Emacs with -Q -q.
C-x C-f a file with an RCS version control file behind it.
perform some edit somewhere.
C-x C-s.
Bug: Point does not stay where it was, but jumps to the beginning of the file.
(Note that this does not seem to occur with, e.g., svn-controlled files.)


In GNU Emacs 23.1.50.3 (x86_64-apple-darwin10.2.0, NS apple-appkit-1038.25)
 of 2009-11-16 on tuffi.local
Windowing system distributor `Apple', version 10.3.1038
configured using `configure  '--without-dbus' '--without-x' '--with-ns' 'CFLAGS=-O9 -mtune=nocona -pipe -fomit-frame-pointer''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: UTF-8
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: nil
  value of $XMODIFIERS: nil
  locale-coding-system: utf-8-unix
  default enable-multibyte-characters: t

Major mode: Fundamental

Minor modes in effect:
  tooltip-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
C-x C-f / t p <backspace> m p / b <return> <escape> 
> <return> b l a b a l <return> C-x C-s <menu-bar> 
<help-menu> <send-emacs-bug-report>

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.
Mark set
Saving file /tmp/b...
Wrote /tmp/b

Load-path shadows:
None found.

Features:
(shadow mail-extr message ecomplete rfc822 mml mml-sec password-cache
mm-decode mm-bodies mm-encode mailcap mail-parse rfc2231 rfc2047 rfc2045
qp ietf-drums mailabbrev nnheader gnus-util netrc time-date mm-util
mail-prsvr gmm-utils wid-edit mailheader canlock sha1 hex-util hashcash
mail-utils emacsbug sendmail regexp-opt vc-rcs tooltip ediff-hook
vc-hooks lisp-float-type mwheel ns-win easymenu tool-bar dnd fontset
image fringe lisp-mode register page menu-bar rfn-eshadow timer select
scroll-bar mldrag mouse jit-lock font-lock syntax facemenu font-core
frame cham georgian utf-8-lang misc-lang vietnamese tibetan thai
tai-viet lao korean japanese hebrew greek romanian slovak czech european
ethiopic indian cyrillic chinese case-table epa-hook jka-cmpr-hook help
simple abbrev loaddefs button minibuffer faces cus-face text-properties
overlay md5 base64 format env code-pages mule custom widget
hashtable-print-readable backquote make-network-process ns multi-tty
emacs)

bug#4933: 23.1.50; RCS buffer: save-buffer moves point to beginning of buffer

[Stefan Monnier]

> Start Emacs with -Q -q.
> C-x C-f a file with an RCS version control file behind it.
> perform some edit somewhere.
> C-x C-s.
> Bug: Point does not stay where it was, but jumps to the beginning of the file.
> (Note that this does not seem to occur with, e.g., svn-controlled files.)

Thank you for that precise bug report.  I've just installed the patch
below which should fix it,


        Stefan


--- vc-rcs.el.~1.97.~	2009-11-15 23:34:56.000000000 -0500
+++ vc-rcs.el	2009-11-16 09:38:57.000000000 -0500
@@ -1056,6 +1056,7 @@
    ((not (get-file-buffer file)) nil)
    ((let (status version locking-user)
       (with-current-buffer (get-file-buffer file)
+        (save-excursion
         (goto-char (point-min))
         (cond
          ;; search for $Id or $Header
@@ -1112,7 +1113,7 @@
             (setq status 'rev)))
          ;; else: nothing found
          ;; -------------------
-         (t nil)))
+           (t nil))))
      (if status (vc-file-setprop file 'vc-working-revision version))
      (and (eq status 'rev-and-lock)
 	  (vc-file-setprop file 'vc-state

bug#4933: 23.1.50; RCS buffer: save-buffer moves point to beginning of buffer

[Carsten Bormann]

> I've just installed the patch
> below which should fix it,

Works correctly for me, now.
Thanks!

Gruesse, Carsten

bug#4933: marked as done (23.1.50; RCS buffer: save-buffer moves point to beginning of buffer)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 949 bytes --]

Your message dated Mon, 16 Nov 2009 10:29:54 -0500
with message-id <jwvmy2m7ajn.fsf-monnier+emacsbugreports@gnu.org>
and subject line Re: bug#4933: 23.1.50; RCS buffer: save-buffer moves point to beginning of buffer
has caused the Emacs bug report #4933,
regarding 23.1.50; RCS buffer: save-buffer moves point to beginning of buffer
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)


-- 
4933: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=4933
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 5003 bytes --]

From: Carsten Bormann <cabo@tzi.org>
To: emacs-pretest-bug@gnu.org
Subject: 23.1.50; RCS buffer: save-buffer moves point to beginning of buffer
Date: Mon, 16 Nov 2009 06:38:26 +0100
Message-ID: <D4A7BA83-41AC-44D9-BC36-6962A994F628@tzi.org>

Start Emacs with -Q -q.
C-x C-f a file with an RCS version control file behind it.
perform some edit somewhere.
C-x C-s.
Bug: Point does not stay where it was, but jumps to the beginning of the file.
(Note that this does not seem to occur with, e.g., svn-controlled files.)


In GNU Emacs 23.1.50.3 (x86_64-apple-darwin10.2.0, NS apple-appkit-1038.25)
 of 2009-11-16 on tuffi.local
Windowing system distributor `Apple', version 10.3.1038
configured using `configure  '--without-dbus' '--without-x' '--with-ns' 'CFLAGS=-O9 -mtune=nocona -pipe -fomit-frame-pointer''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: UTF-8
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: nil
  value of $XMODIFIERS: nil
  locale-coding-system: utf-8-unix
  default enable-multibyte-characters: t

Major mode: Fundamental

Minor modes in effect:
  tooltip-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
C-x C-f / t p <backspace> m p / b <return> <escape> 
> <return> b l a b a l <return> C-x C-s <menu-bar> 
<help-menu> <send-emacs-bug-report>

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.
Mark set
Saving file /tmp/b...
Wrote /tmp/b

Load-path shadows:
None found.

Features:
(shadow mail-extr message ecomplete rfc822 mml mml-sec password-cache
mm-decode mm-bodies mm-encode mailcap mail-parse rfc2231 rfc2047 rfc2045
qp ietf-drums mailabbrev nnheader gnus-util netrc time-date mm-util
mail-prsvr gmm-utils wid-edit mailheader canlock sha1 hex-util hashcash
mail-utils emacsbug sendmail regexp-opt vc-rcs tooltip ediff-hook
vc-hooks lisp-float-type mwheel ns-win easymenu tool-bar dnd fontset
image fringe lisp-mode register page menu-bar rfn-eshadow timer select
scroll-bar mldrag mouse jit-lock font-lock syntax facemenu font-core
frame cham georgian utf-8-lang misc-lang vietnamese tibetan thai
tai-viet lao korean japanese hebrew greek romanian slovak czech european
ethiopic indian cyrillic chinese case-table epa-hook jka-cmpr-hook help
simple abbrev loaddefs button minibuffer faces cus-face text-properties
overlay md5 base64 format env code-pages mule custom widget
hashtable-print-readable backquote make-network-process ns multi-tty
emacs)



[-- Attachment #3: Type: message/rfc822, Size: 3350 bytes --]

From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Carsten Bormann <cabo@tzi.org>
Subject: Re: bug#4933: 23.1.50; RCS buffer: save-buffer moves point to beginning of buffer
Date: Mon, 16 Nov 2009 10:29:54 -0500
Message-ID: <jwvmy2m7ajn.fsf-monnier+emacsbugreports@gnu.org>

>> I've just installed the patch
>> below which should fix it,
> Works correctly for me, now.

Thank you for confirming it,


        Stefan