unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#66666: 30.0.50; Feedback on treesit-font-lock-level
@ 2023-10-21 14:16 Augusto Stoffel
  2023-10-21 18:18 ` Yuan Fu
  2023-10-22 20:47 ` bug#66666: control message for bug #66666 Vivien Kraus via Bug reports for GNU Emacs, the Swiss army knife of text editors
  0 siblings, 2 replies; 3+ messages in thread
From: Augusto Stoffel @ 2023-10-21 14:16 UTC (permalink / raw)
  To: 66666; +Cc: Yuan Fu

The docstring of treesit-font-lock-level says:

  Level 1 usually contains only comments and definitions.

As a user of minimal fontification, I don't find this very appealing.
IMO, the lowest fontification level should allow distinguishing code
from non-code, and therefore fontify comments and strings, and nothing
else.





^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#66666: 30.0.50; Feedback on treesit-font-lock-level
  2023-10-21 14:16 bug#66666: 30.0.50; Feedback on treesit-font-lock-level Augusto Stoffel
@ 2023-10-21 18:18 ` Yuan Fu
  2023-10-22 20:47 ` bug#66666: control message for bug #66666 Vivien Kraus via Bug reports for GNU Emacs, the Swiss army knife of text editors
  1 sibling, 0 replies; 3+ messages in thread
From: Yuan Fu @ 2023-10-21 18:18 UTC (permalink / raw)
  To: Augusto Stoffel; +Cc: 66666



> On Oct 21, 2023, at 7:16 AM, Augusto Stoffel <arstoffel@gmail.com> wrote:
> 
> The docstring of treesit-font-lock-level says:
> 
>  Level 1 usually contains only comments and definitions.
> 
> As a user of minimal fontification, I don't find this very appealing.
> IMO, the lowest fontification level should allow distinguishing code
> from non-code, and therefore fontify comments and strings, and nothing
> else.


That’s a fair point, and I don’t have strong opinions of what minimal level of font-lock should include. The default value is derived from my observation of the (few) existing major modes that support font-lock levels.

Since this isn’t a technical issue but rather a subjective one, perhaps you can bring it up to emacs-devel and have a discussion there. If the consensus agrees with you, then we can change the default value.

If you just want to make it work for yourself, you can use treesit-font-lock-recompute-features to add/remove features you desire.

Yuan




^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#66666: control message for bug #66666
  2023-10-21 14:16 bug#66666: 30.0.50; Feedback on treesit-font-lock-level Augusto Stoffel
  2023-10-21 18:18 ` Yuan Fu
@ 2023-10-22 20:47 ` Vivien Kraus via Bug reports for GNU Emacs, the Swiss army knife of text editors
  1 sibling, 0 replies; 3+ messages in thread
From: Vivien Kraus via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2023-10-22 20:47 UTC (permalink / raw)
  To: 66666

severity 66666 devilish
quit





^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-10-22 20:47 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-21 14:16 bug#66666: 30.0.50; Feedback on treesit-font-lock-level Augusto Stoffel
2023-10-21 18:18 ` Yuan Fu
2023-10-22 20:47 ` bug#66666: control message for bug #66666 Vivien Kraus via Bug reports for GNU Emacs, the Swiss army knife of text editors

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).