* bug#63750: 30.0.50; tree-sitter: `treesit-language-source-alist' is not customisable
@ 2023-05-27 12:01 Mickey Petersen
2023-05-27 12:32 ` Eli Zaretskii
0 siblings, 1 reply; 7+ messages in thread
From: Mickey Petersen @ 2023-05-27 12:01 UTC (permalink / raw)
To: 63750
Given the simple alist structure, and that its intent is to be used
with the interactive function `treesit-install-language-grammar', it'd
make sense to turn it into a Customize option.
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#63750: 30.0.50; tree-sitter: `treesit-language-source-alist' is not customisable
2023-05-27 12:01 bug#63750: 30.0.50; tree-sitter: `treesit-language-source-alist' is not customisable Mickey Petersen
@ 2023-05-27 12:32 ` Eli Zaretskii
2023-05-27 23:12 ` Yuan Fu
0 siblings, 1 reply; 7+ messages in thread
From: Eli Zaretskii @ 2023-05-27 12:32 UTC (permalink / raw)
To: Mickey Petersen, Yuan Fu; +Cc: 63750
> From: Mickey Petersen <mickey@masteringemacs.org>
> Date: Sat, 27 May 2023 13:01:40 +0100
>
>
> Given the simple alist structure, and that its intent is to be used
> with the interactive function `treesit-install-language-grammar', it'd
> make sense to turn it into a Customize option.
We deliberately decided not to make it a defcustom, and not to provide
any non-trivial default value, so as to avoid the impression that we
as a project want to be responsible for the language grammars, their
correctness, up-to-date sites, and their licenses. It should be
entirely up to the user and/or the Emacs distros.
However, I think we decided to make it so that each installation
should update the value of the variable with the data of the grammar
just installed. I see that we don't actually do that -- Yuan, am I
misremembering this? If not, would you please add code to add to the
variable's value the data of every grammar that is installed?
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#63750: 30.0.50; tree-sitter: `treesit-language-source-alist' is not customisable
2023-05-27 12:32 ` Eli Zaretskii
@ 2023-05-27 23:12 ` Yuan Fu
2023-05-28 5:32 ` Eli Zaretskii
0 siblings, 1 reply; 7+ messages in thread
From: Yuan Fu @ 2023-05-27 23:12 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 63750, Mickey Petersen
> On May 27, 2023, at 5:32 AM, Eli Zaretskii <eliz@gnu.org> wrote:
>
>> From: Mickey Petersen <mickey@masteringemacs.org>
>> Date: Sat, 27 May 2023 13:01:40 +0100
>>
>>
>> Given the simple alist structure, and that its intent is to be used
>> with the interactive function `treesit-install-language-grammar', it'd
>> make sense to turn it into a Customize option.
>
> We deliberately decided not to make it a defcustom, and not to provide
> any non-trivial default value, so as to avoid the impression that we
> as a project want to be responsible for the language grammars, their
> correctness, up-to-date sites, and their licenses. It should be
> entirely up to the user and/or the Emacs distros.
>
> However, I think we decided to make it so that each installation
> should update the value of the variable with the data of the grammar
> just installed. I see that we don't actually do that -- Yuan, am I
> misremembering this? If not, would you please add code to add to the
> variable's value the data of every grammar that is installed?
Sure. Does it need to be preserved across sessions (ie, use custom)? Or just add for the current session?
Yuan
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#63750: 30.0.50; tree-sitter: `treesit-language-source-alist' is not customisable
2023-05-27 23:12 ` Yuan Fu
@ 2023-05-28 5:32 ` Eli Zaretskii
2023-05-28 22:51 ` Yuan Fu
0 siblings, 1 reply; 7+ messages in thread
From: Eli Zaretskii @ 2023-05-28 5:32 UTC (permalink / raw)
To: Yuan Fu; +Cc: 63750, mickey
> From: Yuan Fu <casouri@gmail.com>
> Date: Sat, 27 May 2023 16:12:18 -0700
> Cc: Mickey Petersen <mickey@masteringemacs.org>,
> 63750@debbugs.gnu.org
>
> > However, I think we decided to make it so that each installation
> > should update the value of the variable with the data of the grammar
> > just installed. I see that we don't actually do that -- Yuan, am I
> > misremembering this? If not, would you please add code to add to the
> > variable's value the data of every grammar that is installed?
>
> Sure. Does it need to be preserved across sessions (ie, use custom)? Or just add for the current session?
Only for the current session. Users who want it preserved should do
it themselves (I will add that to the doc string when the code which
updates the variable is installed).
Thanks.
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#63750: 30.0.50; tree-sitter: `treesit-language-source-alist' is not customisable
2023-05-28 5:32 ` Eli Zaretskii
@ 2023-05-28 22:51 ` Yuan Fu
2023-05-29 14:40 ` Eli Zaretskii
0 siblings, 1 reply; 7+ messages in thread
From: Yuan Fu @ 2023-05-28 22:51 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 63750, mickey
> On May 27, 2023, at 10:32 PM, Eli Zaretskii <eliz@gnu.org> wrote:
>
>> From: Yuan Fu <casouri@gmail.com>
>> Date: Sat, 27 May 2023 16:12:18 -0700
>> Cc: Mickey Petersen <mickey@masteringemacs.org>,
>> 63750@debbugs.gnu.org
>>
>>> However, I think we decided to make it so that each installation
>>> should update the value of the variable with the data of the grammar
>>> just installed. I see that we don't actually do that -- Yuan, am I
>>> misremembering this? If not, would you please add code to add to the
>>> variable's value the data of every grammar that is installed?
>>
>> Sure. Does it need to be preserved across sessions (ie, use custom)? Or just add for the current session?
>
> Only for the current session. Users who want it preserved should do
> it themselves (I will add that to the doc string when the code which
> updates the variable is installed).
Done.
Yuan
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#63750: 30.0.50; tree-sitter: `treesit-language-source-alist' is not customisable
2023-05-28 22:51 ` Yuan Fu
@ 2023-05-29 14:40 ` Eli Zaretskii
2023-05-29 20:37 ` Yuan Fu
0 siblings, 1 reply; 7+ messages in thread
From: Eli Zaretskii @ 2023-05-29 14:40 UTC (permalink / raw)
To: Yuan Fu; +Cc: 63750, mickey
> From: Yuan Fu <casouri@gmail.com>
> Date: Sun, 28 May 2023 15:51:05 -0700
> Cc: mickey@masteringemacs.org,
> 63750@debbugs.gnu.org
>
>
>
> > On May 27, 2023, at 10:32 PM, Eli Zaretskii <eliz@gnu.org> wrote:
> >
> >> From: Yuan Fu <casouri@gmail.com>
> >> Date: Sat, 27 May 2023 16:12:18 -0700
> >> Cc: Mickey Petersen <mickey@masteringemacs.org>,
> >> 63750@debbugs.gnu.org
> >>
> >>> However, I think we decided to make it so that each installation
> >>> should update the value of the variable with the data of the grammar
> >>> just installed. I see that we don't actually do that -- Yuan, am I
> >>> misremembering this? If not, would you please add code to add to the
> >>> variable's value the data of every grammar that is installed?
> >>
> >> Sure. Does it need to be preserved across sessions (ie, use custom)? Or just add for the current session?
> >
> > Only for the current session. Users who want it preserved should do
> > it themselves (I will add that to the doc string when the code which
> > updates the variable is installed).
>
> Done.
Thanks. And I see that you have updated the doc string accordingly.
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#63750: 30.0.50; tree-sitter: `treesit-language-source-alist' is not customisable
2023-05-29 14:40 ` Eli Zaretskii
@ 2023-05-29 20:37 ` Yuan Fu
0 siblings, 0 replies; 7+ messages in thread
From: Yuan Fu @ 2023-05-29 20:37 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 63750, Mickey Petersen
> On May 29, 2023, at 7:40 AM, Eli Zaretskii <eliz@gnu.org> wrote:
>
>> From: Yuan Fu <casouri@gmail.com>
>> Date: Sun, 28 May 2023 15:51:05 -0700
>> Cc: mickey@masteringemacs.org,
>> 63750@debbugs.gnu.org
>>
>>
>>
>>> On May 27, 2023, at 10:32 PM, Eli Zaretskii <eliz@gnu.org> wrote:
>>>
>>>> From: Yuan Fu <casouri@gmail.com>
>>>> Date: Sat, 27 May 2023 16:12:18 -0700
>>>> Cc: Mickey Petersen <mickey@masteringemacs.org>,
>>>> 63750@debbugs.gnu.org
>>>>
>>>>> However, I think we decided to make it so that each installation
>>>>> should update the value of the variable with the data of the grammar
>>>>> just installed. I see that we don't actually do that -- Yuan, am I
>>>>> misremembering this? If not, would you please add code to add to the
>>>>> variable's value the data of every grammar that is installed?
>>>>
>>>> Sure. Does it need to be preserved across sessions (ie, use custom)? Or just add for the current session?
>>>
>>> Only for the current session. Users who want it preserved should do
>>> it themselves (I will add that to the doc string when the code which
>>> updates the variable is installed).
>>
>> Done.
>
> Thanks. And I see that you have updated the doc string accordingly.
Glad my docstring worked out this time ;-)
Yuan
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2023-05-29 20:37 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-27 12:01 bug#63750: 30.0.50; tree-sitter: `treesit-language-source-alist' is not customisable Mickey Petersen
2023-05-27 12:32 ` Eli Zaretskii
2023-05-27 23:12 ` Yuan Fu
2023-05-28 5:32 ` Eli Zaretskii
2023-05-28 22:51 ` Yuan Fu
2023-05-29 14:40 ` Eli Zaretskii
2023-05-29 20:37 ` Yuan Fu
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).