unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Morgan Smith <Morgan.J.Smith@outlook.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 63913@debbugs.gnu.org
Subject: bug#63913: [PATCH] * lisp/minibuffer.el (minibuffer-completion-help): Only ding when appropriate.
Date: Mon, 05 Jun 2023 15:09:02 -0400	[thread overview]
Message-ID: <DM5PR03MB31630368E91DB73AE375F33CC54DA@DM5PR03MB3163.namprd03.prod.outlook.com> (raw)
In-Reply-To: <834jnl4ub9.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 05 Jun 2023 14:50:53 -0400")

Eli Zaretskii <eliz@gnu.org> writes:

>
> Sorry, no, it isn't obvious to me.  So please do provide a complete
> recipe for reproducing the problem, starting frm "emacs -Q".
>
> Thanks.

I apologize for my assumption.

emacs -Q
(setopt completion-auto-help 'visible)
(debug-on-entry 'ding) ;; just so we know when it dings

`M-x eshell` then spam TAB until the completion buffer pops up.  Now
type in enough to select a unique completion.  I'm completing
`eshell-command` so I'll make the minibuffer look like 'eshell-comman'.

Now press one final TAB to select the only available completion.  It
should ding.

Obviously it shouldn't ding in that situation since it is a success.
Also that situation doesn't respect completion-fail-discreetly if you
where to type in a failing completion before the final TAB press.





  reply	other threads:[~2023-06-05 19:09 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-05 17:50 bug#63913: [PATCH] * lisp/minibuffer.el (minibuffer-completion-help): Only ding when appropriate Morgan Smith
2023-06-05 18:50 ` Eli Zaretskii
2023-06-05 19:09   ` Morgan Smith [this message]
2023-06-06 11:19     ` Eli Zaretskii
2023-06-06 19:08       ` Morgan Smith
2023-06-08  9:59         ` Eli Zaretskii
2023-06-08 16:54           ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-10  9:13             ` Eli Zaretskii
2023-06-10 17:34               ` Morgan Smith
2023-06-10 17:56                 ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM5PR03MB31630368E91DB73AE375F33CC54DA@DM5PR03MB3163.namprd03.prod.outlook.com \
    --to=morgan.j.smith@outlook.com \
    --cc=63913@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).