unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Morgan Smith <Morgan.J.Smith@outlook.com>
Cc: spacibba@aol.com, 63913-done@debbugs.gnu.org, monnier@iro.umontreal.ca
Subject: bug#63913: [PATCH] * lisp/minibuffer.el (minibuffer-completion-help): Only ding when appropriate.
Date: Sat, 10 Jun 2023 20:56:26 +0300	[thread overview]
Message-ID: <83edmjyzed.fsf@gnu.org> (raw)
In-Reply-To: <DM5PR03MB3163F84BF352B9E432F413C7C556A@DM5PR03MB3163.namprd03.prod.outlook.com> (message from Morgan Smith on Sat, 10 Jun 2023 13:34:32 -0400)

> From: Morgan Smith <Morgan.J.Smith@outlook.com>
> Cc: Stefan Monnier <monnier@iro.umontreal.ca>,  spacibba@aol.com,
>   63913-done@debbugs.gnu.org
> Date: Sat, 10 Jun 2023 13:34:32 -0400
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> >
> > Thanks, installed on the emacs-29 branch, and closing the bug.
> 
> Would you also consider installing the test patch I sent previously?
> I've reattached it here for your convenience.

Installed.  But please in the future try to follow better our
conventions for log messages, to avoid the need for me to manually fix
the log message when installing:

 . always mention the bug number in the log message
 . quote symbols 'like this'
 . make sure the lines are not too long (they will be longer by 8
   columns when converted to a ChangeLog as part of tarring the
   release)





      reply	other threads:[~2023-06-10 17:56 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-05 17:50 bug#63913: [PATCH] * lisp/minibuffer.el (minibuffer-completion-help): Only ding when appropriate Morgan Smith
2023-06-05 18:50 ` Eli Zaretskii
2023-06-05 19:09   ` Morgan Smith
2023-06-06 11:19     ` Eli Zaretskii
2023-06-06 19:08       ` Morgan Smith
2023-06-08  9:59         ` Eli Zaretskii
2023-06-08 16:54           ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-10  9:13             ` Eli Zaretskii
2023-06-10 17:34               ` Morgan Smith
2023-06-10 17:56                 ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83edmjyzed.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=63913-done@debbugs.gnu.org \
    --cc=Morgan.J.Smith@outlook.com \
    --cc=monnier@iro.umontreal.ca \
    --cc=spacibba@aol.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).