unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#70364: Add YANG LSP support to eglot
@ 2024-04-12 16:32 Siddharth Sharma via Bug reports for GNU Emacs, the Swiss army knife of text editors
  2024-04-18 10:38 ` Eli Zaretskii
  0 siblings, 1 reply; 2+ messages in thread
From: Siddharth Sharma via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2024-04-12 16:32 UTC (permalink / raw)
  To: 70364

[-- Attachment #1: Type: text/plain, Size: 129 bytes --]

Hello,

This is a wish to add YANG LSP server based on https://github.com/TypeFox/yang-lsp support to eglot.

Regards,
Sid

[-- Attachment #2: 0001-Add-YANG-LSP-support-to-eglot.patch --]
[-- Type: application/octet-stream, Size: 1536 bytes --]

From 5b237232076406874a7a47a6bfa3ffd306d98709 Mon Sep 17 00:00:00 2001
From: Siddharth Sharma <siddharth.sharma@ericsson.com>
Date: Fri, 12 Apr 2024 18:11:58 +0200
Subject: [PATCH] Add YANG LSP support to eglot

Also added jsonc-mode association to json-language-server since
YANG LSP configuration file is of type JSON with Comments

Signed-off-by: Siddharth Sharma <siddharth.sharma@ericsson.com>
---
 lisp/progmodes/eglot.el | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el
index f247c43203c..2eaf12c56e1 100644
--- a/lisp/progmodes/eglot.el
+++ b/lisp/progmodes/eglot.el
@@ -241,7 +241,7 @@ automatically)."
          '("pylsp" "pyls" ("basedpyright-langserver" "--stdio")
            ("pyright-langserver" "--stdio")
            "jedi-language-server" "ruff-lsp")))
-    ((js-json-mode json-mode json-ts-mode)
+    ((js-json-mode json-mode json-ts-mode jsonc-mode)
      . ,(eglot-alternatives '(("vscode-json-language-server" "--stdio")
                               ("vscode-json-languageserver" "--stdio")
                               ("json-languageserver" "--stdio"))))
@@ -301,6 +301,7 @@ automatically)."
     (futhark-mode . ("futhark" "lsp"))
     ((lua-mode lua-ts-mode) . ,(eglot-alternatives
                                 '("lua-language-server" "lua-lsp")))
+    (yang-mode . ("yang-language-server"))
     (zig-mode . ("zls"))
     ((css-mode css-ts-mode)
      . ,(eglot-alternatives '(("vscode-css-language-server" "--stdio")
-- 
2.43.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* bug#70364: Add YANG LSP support to eglot
  2024-04-12 16:32 bug#70364: Add YANG LSP support to eglot Siddharth Sharma via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2024-04-18 10:38 ` Eli Zaretskii
  0 siblings, 0 replies; 2+ messages in thread
From: Eli Zaretskii @ 2024-04-18 10:38 UTC (permalink / raw)
  To: Siddharth Sharma; +Cc: 70364-done

> Date: Fri, 12 Apr 2024 16:32:38 +0000
> From:  Siddharth Sharma via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
> 
> This is a wish to add YANG LSP server based on https://github.com/TypeFox/yang-lsp support to eglot.

Thanks, installed on the master branch, and closing the bug.

Please in the future avoid having the Signed-off-by header in the
commit log message, since our git-commit-hook rejects those; see
CONTRIBUTE.





^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-04-18 10:38 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-12 16:32 bug#70364: Add YANG LSP support to eglot Siddharth Sharma via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-18 10:38 ` Eli Zaretskii

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).