bug#11012: VC git checkout fails with error

bug#11012: VC git checkout fails with error

[David Reitter]

X-Debbugs-CC: Robert Goldman <rpgoldman@sift.info>

Begin forwarded message:

> From: Robert Goldman <rpgoldman@sift.info>
> Subject: [Aquamacs-bugs] VC git checkout fails with error
> Date: March 12, 2012 12:38:58 PM EDT
> To: Aquamacs bugs list <aquamacs-bugs@aquamacs.org>
> Reply-To: rpgoldman@sift.info, Bug reports for Aquamacs Emacs <aquamacs-bugs@aquamacs.org>
> 
> Using ^X V + (vc-update) in a buffer under git revision control calls 
> vc-git-command as follows:
> 
> vc-git-command(nil 0 <filename> "checkout" t)
> 
> The arguments to vc-git-command are 
> 
> (defun vc-git-command (buffer okstatus file-or-list &rest flags)
> 
> and it calls 
> 
> vc-do-command (buffer okstatus command file-or-list &rest flags)
> 
> with flags as ("checkout" t)
> 
> but vc-do-command treats flags as a list of strings, meaning that it
> blows up with a not-a-sequence error here:
> 
> (mapcar (lambda (s) (if (> (length s) 20) (concat (substring s 0 2) "...")  s)) flags)
> 
> vc-dispatcher.el, line 300.
> 
> That last argument, T, is supposed to be a REV at the bottom of the call stack, where we call vc-update and then vc-checkout.
> 
> The slip-up seems to be on the pass-through to vc-call-backend.
> 
> Aquamacs info:
> 
> GNU Emacs 23.3.50.1 (i386-apple-darwin9.8.0, NS apple-appkit-949.54)
> of 2011-10-25 on braeburn.aquamacs.org - Aquamacs Distribution 2.4
> 
> Snow Leopard

bug#11012: VC git checkout fails with error

[Glenn Morris]

David Reitter wrote:

>> Using ^X V + (vc-update) in a buffer under git revision control calls 
[...]
>> blows up with a not-a-sequence error here:

>> Aquamacs info:
>> 
>> GNU Emacs 23.3.50.1 (i386-apple-darwin9.8.0, NS apple-appkit-949.54)
>> of 2011-10-25 on braeburn.aquamacs.org - Aquamacs Distribution 2.4


This error does not occur in the current Emacs trunk.

bug#11012: VC git checkout fails with error

[David Reitter]

[-- Attachment #1: Type: text/plain, Size: 327 bytes --]

On Mar 14, 2012, at 2:43 PM, Glenn Morris wrote:


>>> GNU Emacs 23.3.50.1 (i386-apple-darwin9.8.0, NS apple-appkit-949.54)
>>> of 2011-10-25 on braeburn.aquamacs.org - Aquamacs Distribution 2.4
> 
> This error does not occur in the current Emacs trunk.

What was the fix?  Can we apply this to the stable branch (that is, 23)?

[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 203 bytes --]

bug#11012: VC git checkout fails with error

[Glenn Morris]

Emacs 24.1, where this is fixed, has been released.