bug#29672: 26.0.90 Can't move cursor above prompt in evil-mode

bug#29672: 26.0.90 Can't move cursor above prompt in evil-mode

[James Nguyen]

This is in char-mode.

It works in emacs 25.

——————————————————
emacs-major-version ;; 25
(add-to-list 'load-path "/Users/james/.emacs.d/elpa/25/evil-20171129.651")
(require 'evil)
(evil-mode)
M-x term
"/bin/zsh"
Press ESC to go into 'normal state'.
Press k to move cursor above prompt. --> cursor moves above prompt
——————————————————

——————————————————
emacs-major-version ;; 26
(add-to-list 'load-path "/Users/james/.emacs.d/elpa/26/evil-20171129.651")
(require 'evil)
(evil-mode)
M-x term
"/bin/zsh"
Press ESC to go into 'normal state'.
Press k to move cursor above prompt. --> cursor won't move outside of prompt
——————————————————

In GNU Emacs 26.0.90 (build 1, x86_64-apple-darwin16.7.0, NS appkit-1504.83 Version 10.12.6 (Build 16G29))
 of 2017-12-09 built on jamesretina.local
Repository revision: e9ea2065a82c46b3524633e4638834fc70ae3e6e
Windowing system distributor 'Apple', version 10.3.1504
Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.
26 (#o32, #x1a, ?\C-z)
Mark set
("/Users/james/.emacs.d/elpa/26/evil-20171129.651" "/Users/james/Code/emacs/nextstep/Emacs.app/Contents/Resources/lisp" "/Users/james/Code/emacs/nextstep/Emacs.app/Contents/Resources/lisp/vc" "/Users/james/Code/emacs/nextstep/Emacs.app/Contents/Resources/lisp/url" "/Users/james/Code/emacs/nextstep/Emacs.app/Contents/Resources/lisp/textmodes" "/Users/james/Code/emacs/nextstep/Emacs.app/Contents/Resources/lisp/progmodes" "/Users/james/Code/emacs/nextstep/Emacs.app/Contents/Resources/lisp/play" "/Users/james/Code/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org" "/Users/james/Code/emacs/nextstep/Emacs.app/Contents/Resources/lisp/nxml" "/Users/james/Code/emacs/nextstep/Emacs.app/Contents/Resources/lisp/net" "/Users/james/Code/emacs/nextstep/Emacs.app/Contents/Resources/lisp/mh-e" "/Users/james/Code/emacs/nextstep/Emacs.app/Contents/Resources/lisp/mail" ...)
Quit [2 times]
evil
t
Configured using:
 'configure --with-modules'

Configured features:
JPEG RSVG NOTIFY ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS NS MODULES

Important settings:
  value of $LC_ALL: C
  value of $LC_COLLATE: C
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  shell-dirtrack-mode: t
  evil-mode: t
  evil-local-mode: t
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message rmc puny seq byte-opt gv
bytecomp byte-compile cconv dired dired-loaddefs format-spec rfc822 mml
mml-sec password-cache epa derived epg epg-config gnus-util rmail
rmail-loaddefs mm-decode mm-bodies mm-encode mail-parse rfc2231
mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums
mm-util mail-prsvr mail-utils term disp-table easymenu ehelp evil
evil-integration evil-maps evil-commands flyspell ispell evil-jumps
evil-command-window evil-types evil-search evil-ex shell pcomplete
comint ansi-color evil-macros evil-repeat evil-states evil-core advice
evil-common windmove thingatpt rect evil-digraphs evil-vars ring edmacro
kmacro cl-loaddefs cl-lib elec-pair time-date tooltip eldoc electric
uniquify ediff-hook vc-hooks lisp-float-type mwheel term/ns-win ns-win
ucs-normalize mule-util term/common-win tool-bar dnd fontset image
regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode
lisp-mode prog-mode register page menu-bar rfn-eshadow isearch timer
select scroll-bar mouse jit-lock font-lock syntax facemenu font-core
term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang
vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932
hebrew greek romanian slovak czech european ethiopic indian cyrillic
chinese composite charscript charprop case-table epa-hook jka-cmpr-hook
help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs
button faces cus-face macroexp files text-properties overlay sha1 md5
base64 format env code-pages mule custom widget hashtable-print-readable
backquote kqueue cocoa ns multi-tty make-network-process emacs)

Memory information:
((conses 16 244772 13155)
 (symbols 48 23991 1)
 (miscs 40 58 184)
 (strings 32 38538 1421)
 (string-bytes 1 1074324)
 (vectors 16 40740)
 (vector-slots 8 767765 11060)
 (floats 8 56 166)
 (intervals 56 297 0)
 (buffers 992 12))

bug#29672: 26.0.90 Can't move cursor above prompt in evil-mode

[Noam Postavsky]

James Nguyen <jamesn@fastmail.com> writes:

> This is in char-mode.
>
> It works in emacs 25.
>
> ——————————————————
> emacs-major-version ;; 25
> (add-to-list 'load-path "/Users/james/.emacs.d/elpa/25/evil-20171129.651")
> (require 'evil)
> (evil-mode)
> M-x term
> "/bin/zsh"
> Press ESC to go into 'normal state'.
> Press k to move cursor above prompt. --> cursor moves above prompt
> ——————————————————
>
> ——————————————————
> emacs-major-version ;; 26
> (add-to-list 'load-path "/Users/james/.emacs.d/elpa/26/evil-20171129.651")
> (require 'evil)
> (evil-mode)
> M-x term
> "/bin/zsh"
> Press ESC to go into 'normal state'.
> Press k to move cursor above prompt. --> cursor won't move outside of prompt
> ——————————————————

A similar recipe without evil:

M-x term
"/bin/bash" ;; I happen not to have zsh installed at the moment
Hit RET a few times so there is somewhere to move.
C-c M-x eval-expression RET (previous-line) RET
See cursort move up, and then move back to the prompt.

Seems to be on purpose, caused by this code, introduced in [1: 0d8e4f45d6]:

    ;; Don't allow changes to the buffer or to point which are not
    ;; caused by the process filter.
    (when term-char-mode-buffer-read-only
      (setq buffer-read-only t))
    (add-hook 'pre-command-hook #'term-set-goto-process-mark nil t)
    (add-hook 'post-command-hook #'term-goto-process-mark-maybe nil t)


[1: 0d8e4f45d6]: 2017-10-21 11:17:56 +0300
  Avoid creating inconsistent buffer states in term-char-mode
  https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=0d8e4f45d612ecd77f4997fae30e4d1591f9b8a6

bug#29672: 26.0.90 Can't move cursor above prompt in evil-mode

[Philipp Stephani]

[-- Attachment #1: Type: text/plain, Size: 1479 bytes --]

Noam Postavsky <npostavs@users.sourceforge.net> schrieb am Di., 12. Dez.
2017 um 15:08 Uhr:

> James Nguyen <jamesn@fastmail.com> writes:
>
> > This is in char-mode.
> >
> > It works in emacs 25.
> >
> > ——————————————————
> > emacs-major-version ;; 25
> > (add-to-list 'load-path
> "/Users/james/.emacs.d/elpa/25/evil-20171129.651")
> > (require 'evil)
> > (evil-mode)
> > M-x term
> > "/bin/zsh"
> > Press ESC to go into 'normal state'.
> > Press k to move cursor above prompt. --> cursor moves above prompt
> > ——————————————————
> >
> > ——————————————————
> > emacs-major-version ;; 26
> > (add-to-list 'load-path
> "/Users/james/.emacs.d/elpa/26/evil-20171129.651")
> > (require 'evil)
> > (evil-mode)
> > M-x term
> > "/bin/zsh"
> > Press ESC to go into 'normal state'.
> > Press k to move cursor above prompt. --> cursor won't move outside of
> prompt
> > ——————————————————
>
> A similar recipe without evil:
>
> M-x term
> "/bin/bash" ;; I happen not to have zsh installed at the moment
> Hit RET a few times so there is somewhere to move.
> C-c M-x eval-expression RET (previous-line) RET
> See cursort move up, and then move back to the prompt.
>
> Seems to be on purpose, caused by this code, introduced in [1: 0d8e4f45d6]:
>
>
Agreed, this is pretty much working as intended.

[-- Attachment #2: Type: text/html, Size: 2054 bytes --]

bug#29672: 26.0.90 Can't move cursor above prompt in evil-mode

[James Nguyen]

[-- Attachment #1: Type: text/plain, Size: 1693 bytes --]

Thanks. That’s unfortunate but I’ll live. :)

> On Dec 21, 2017, at 12:44 PM, Philipp Stephani <p.stephani2@gmail.com> wrote:
> 
> 
> 
> Noam Postavsky <npostavs@users.sourceforge.net <mailto:npostavs@users.sourceforge.net>> schrieb am Di., 12. Dez. 2017 um 15:08 Uhr:
> James Nguyen <jamesn@fastmail.com <mailto:jamesn@fastmail.com>> writes:
> 
> > This is in char-mode.
> >
> > It works in emacs 25.
> >
> > ——————————————————
> > emacs-major-version ;; 25
> > (add-to-list 'load-path "/Users/james/.emacs.d/elpa/25/evil-20171129.651")
> > (require 'evil)
> > (evil-mode)
> > M-x term
> > "/bin/zsh"
> > Press ESC to go into 'normal state'.
> > Press k to move cursor above prompt. --> cursor moves above prompt
> > ——————————————————
> >
> > ——————————————————
> > emacs-major-version ;; 26
> > (add-to-list 'load-path "/Users/james/.emacs.d/elpa/26/evil-20171129.651")
> > (require 'evil)
> > (evil-mode)
> > M-x term
> > "/bin/zsh"
> > Press ESC to go into 'normal state'.
> > Press k to move cursor above prompt. --> cursor won't move outside of prompt
> > ——————————————————
> 
> A similar recipe without evil:
> 
> M-x term
> "/bin/bash" ;; I happen not to have zsh installed at the moment
> Hit RET a few times so there is somewhere to move.
> C-c M-x eval-expression RET (previous-line) RET
> See cursort move up, and then move back to the prompt.
> 
> Seems to be on purpose, caused by this code, introduced in [1: 0d8e4f45d6]:
> 
> 
> Agreed, this is pretty much working as intended.


[-- Attachment #2: Type: text/html, Size: 3249 bytes --]