unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#3931: 23.0.96; doc of select-frame-set-input-focus and select-frame
@ 2009-07-26 16:44 Drew Adams
  2009-07-26 19:22 ` Bastien
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Drew Adams @ 2009-07-26 16:44 UTC (permalink / raw)
  To: emacs-pretest-bug

Doc string of `select-frame':
 
"If you are using a window system, the previously selected frame may
be restored as the selected frame after return to the command loop..."
 
That's grammatically incorrect - "return" should presumably be
"returning" (depending on what is intended by the sentence).
 
In any case, this paragraph of the description is not very clear.
 

Doc string of `select-frame-set-input-focus':
 
"If `mouse-autoselect-window' is non-nil, also move mouse cursor to
FRAME's selected window.  Otherwise, if `focus-follows-mouse' is
non-nil, move mouse cursor to FRAME."
 
"Mouse cursor" is incorrect; "pointer" is correct (or "mouse pointer",
but, strictly speaking, "mouse" is redundant for the pointer).
 
Why "Otherwise"? I'm guessing that what is really meant is this:
 
* If either `mouse-autoselect-window' or `focus-follows-mouse' is
  non-nil, then move the mouse pointer to....
* Otherwise, do not move the mouse pointer.
 

Similar problems exist for the description in the Elisp manual (the
text is almost the same).  In addition, the manual should say
something more about the differences between these two functions, and
mention when you might use one or the other.
 
 
 
In GNU Emacs 23.0.96.1 (i386-mingw-nt5.1.2600)
 of 2009-07-09 on SOFT-MJASON
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (3.4)'
 






^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#3931: 23.0.96; doc of select-frame-set-input-focus and select-frame
  2009-07-26 16:44 bug#3931: 23.0.96; doc of select-frame-set-input-focus and select-frame Drew Adams
@ 2009-07-26 19:22 ` Bastien
  2009-07-26 19:33   ` Drew Adams
  2011-07-12 20:02 ` Lars Magne Ingebrigtsen
  2012-01-29  5:23 ` Drew Adams
  2 siblings, 1 reply; 6+ messages in thread
From: Bastien @ 2009-07-26 19:22 UTC (permalink / raw)
  To: Drew Adams; +Cc: emacs-pretest-bug, 3931

"Drew Adams" <drew.adams@oracle.com> writes:

> "If you are using a window system, the previously selected frame may
> be restored as the selected frame after return to the command loop..."
>  
> That's grammatically incorrect - "return" should presumably be
> "returning" (depending on what is intended by the sentence).
>  
> In any case, this paragraph of the description is not very clear.

I have changed it to this:

  "If you are using a window system, the previously selected frame may
  be restored as the selected frame when returning to the command loop,
  because it still may have the window system's input focus."

> Doc string of `select-frame-set-input-focus':
>  
> "If `mouse-autoselect-window' is non-nil, also move mouse cursor to
> FRAME's selected window.  Otherwise, if `focus-follows-mouse' is
> non-nil, move mouse cursor to FRAME."
>  
> "Mouse cursor" is incorrect; "pointer" is correct (or "mouse pointer",
> but, strictly speaking, "mouse" is redundant for the pointer).

Right, I changed this.

> Why "Otherwise"? 

Because the value of `focus-follows-mouse' is only checked if
`mouse-autoselect-window' is nil.

> Similar problems exist for the description in the Elisp manual (the
> text is almost the same).  In addition, the manual should say
> something more about the differences between these two functions, and
> mention when you might use one or the other.

I don't know how to fix the Elisp manual.

-- 
 Bastien





^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#3931: 23.0.96; doc of select-frame-set-input-focus and select-frame
  2009-07-26 19:22 ` Bastien
@ 2009-07-26 19:33   ` Drew Adams
  0 siblings, 0 replies; 6+ messages in thread
From: Drew Adams @ 2009-07-26 19:33 UTC (permalink / raw)
  To: 'Bastien'; +Cc: emacs-pretest-bug, 3931

> > Doc string of `select-frame-set-input-focus':
> > "If `mouse-autoselect-window' is non-nil, also move mouse cursor to
> > FRAME's selected window.  Otherwise, if `focus-follows-mouse' is
> > non-nil, move mouse cursor to FRAME."
> >  
> > Why "Otherwise"? 
> 
> Because the value of `focus-follows-mouse' is only checked if
> `mouse-autoselect-window' is nil.

OK, in that case the text is correct. But it could easily be misread by some
users. It would be clearer to state this explicitly: "If
`mouse-autoselect-window' is nil and `mouse-autoselect-window' is non-nil, then
move the mouse pointer to FRAME."

And it wouldn't hurt to state this explicitly also:
"Otherwise, do not move the mouse pointer."

> > Similar problems exist for the description in the Elisp manual (the
> > text is almost the same).  In addition, the manual should say
> > something more about the differences between these two 
> functions, and
> > mention when you might use one or the other.
> 
> I don't know how to fix the Elisp manual.

Hopefully, someone else does. ;-)

Thx.






^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#3931: 23.0.96; doc of select-frame-set-input-focus and select-frame
  2009-07-26 16:44 bug#3931: 23.0.96; doc of select-frame-set-input-focus and select-frame Drew Adams
  2009-07-26 19:22 ` Bastien
@ 2011-07-12 20:02 ` Lars Magne Ingebrigtsen
  2011-07-12 21:11   ` Drew Adams
  2012-01-29  5:23 ` Drew Adams
  2 siblings, 1 reply; 6+ messages in thread
From: Lars Magne Ingebrigtsen @ 2011-07-12 20:02 UTC (permalink / raw)
  To: Drew Adams; +Cc: 3931

"Drew Adams" <drew.adams@oracle.com> writes:

> "Mouse cursor" is incorrect; "pointer" is correct (or "mouse pointer",
> but, strictly speaking, "mouse" is redundant for the pointer).
>
> Why "Otherwise"? I'm guessing that what is really meant is this:
>
> * If either `mouse-autoselect-window' or `focus-follows-mouse' is
>   non-nil, then move the mouse pointer to....
> * Otherwise, do not move the mouse pointer.
>
> Similar problems exist for the description in the Elisp manual (the
> text is almost the same).  In addition, the manual should say
> something more about the differences between these two functions, and
> mention when you might use one or the other.

I'm unable to find wording of this kind in the manual.  Has this been
fixed now?

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/





^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#3931: 23.0.96; doc of select-frame-set-input-focus and select-frame
  2011-07-12 20:02 ` Lars Magne Ingebrigtsen
@ 2011-07-12 21:11   ` Drew Adams
  0 siblings, 0 replies; 6+ messages in thread
From: Drew Adams @ 2011-07-12 21:11 UTC (permalink / raw)
  To: 'Lars Magne Ingebrigtsen'; +Cc: 3931

> > Why "Otherwise"? I'm guessing that what is really meant is this:
> >
> > * If either `mouse-autoselect-window' or `focus-follows-mouse' is
> >   non-nil, then move the mouse pointer to....
> > * Otherwise, do not move the mouse pointer.
> >
> > Similar problems exist for the description in the Elisp manual (the
> > text is almost the same).  In addition, the manual should say
> > something more about the differences between these two 
> > functions, and mention when you might use one or the other.
> 
> I'm unable to find wording of this kind in the manual.  Has this been
> fixed now?

I don't know what I meant by the first sentence in the last paragraph, sorry.

But please fix the doc string as indicated.  And please explain in the Elisp
manual what the difference is between these two functions.  Thx.






^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#3931: 23.0.96; doc of select-frame-set-input-focus and select-frame
  2009-07-26 16:44 bug#3931: 23.0.96; doc of select-frame-set-input-focus and select-frame Drew Adams
  2009-07-26 19:22 ` Bastien
  2011-07-12 20:02 ` Lars Magne Ingebrigtsen
@ 2012-01-29  5:23 ` Drew Adams
  2 siblings, 0 replies; 6+ messages in thread
From: Drew Adams @ 2012-01-29  5:23 UTC (permalink / raw)
  To: 3931

Subject: RE: [debbugs-tracker] Processed: close 3931

This bug seems to have been closed with no explanation.  At least I received no
other message associated with the closing, apart from the equally empty of
explanation "acknowledged by developer" message.

Was this bug fixed?

> From: GNU bug Tracking System Sent: Friday, January 27, 2012 8:30 PM
> To: Chong Yidong Cc: tracker@debbugs.gnu.org
> Subject: [debbugs-tracker] Processed: close 3931
> 
> Processing commands for control@debbugs.gnu.org:
> 
> > close 3931
> bug#3931: 23.0.96; doc of select-frame-set-input-focus and 
> select-frame
> bug closed, send any further explanations to
> 3931@debbugs.gnu.org and "Drew Adams" <drew.adams@oracle.com>
> 
> > thanks
> Stopping processing here.
> 
> Please contact help-debbugs@gnu.org if you need assistance.
> 
> GNU bugs database, http://debbugs.gnu.org/






^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2012-01-29  5:23 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-07-26 16:44 bug#3931: 23.0.96; doc of select-frame-set-input-focus and select-frame Drew Adams
2009-07-26 19:22 ` Bastien
2009-07-26 19:33   ` Drew Adams
2011-07-12 20:02 ` Lars Magne Ingebrigtsen
2011-07-12 21:11   ` Drew Adams
2012-01-29  5:23 ` Drew Adams

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).