bug#51740: 27.2; find-file-literally doesn't respect saveplace-mode

bug#51740: 27.2; find-file-literally doesn't respect saveplace-mode

[Scott Otterson]

[-- Attachment #1: Type: text/plain, Size: 3925 bytes --]

In my config file, I have (save-place-mode 1), so when I visit a file with
M-x find-file, close that file, and then revisit it, the cursor is returned
to its last position during the previous find-file visit.

However, if I open the file with M-x find-file-literally, then the cursor
always goes to the top.  Also, when I later reopen the file with find-file,
the previous position of the last M-x find-file is lost (the cursor goes to
the top).

This is a bother when I'm flipping through many files with a command like
the consult package's consult-recent-file, which previews each file as you
move through the recent file list.  In the case of large files,
consult-recent-file reverts to using find-file-literally; the result is
that you can potentially lose your place in a large collection of your most
used files.

The simplest way to make this better is to not allow find-file-literally to
change the save-place-mode state.

Better would be if it opened the file at the same cursor position as would
find-file, and upon exit, appropriately set the save-place-mode state.

----------

In GNU Emacs 27.2 (build 1, x86_64-w64-mingw32)
 of 2021-03-26 built on CIRROCUMULUS
Repository revision: deef5efafb70f4b171265b896505b92b6eef24e6
Repository branch: HEAD
Windowing system distributor 'Microsoft Corp.', version 10.0.22000
System Description: Microsoft Windows 10 Home (v10.0.2009.22000.282)

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.

Configured using:
 'configure --without-dbus --host=x86_64-w64-mingw32
 --without-compress-install 'CFLAGS=-O2 -static''

Configured features:
XPM JPEG TIFF GIF PNG RSVG SOUND NOTIFY W32NOTIFY ACL GNUTLS LIBXML2
HARFBUZZ ZLIB TOOLKIT_SCROLL_BARS MODULES THREADS JSON PDUMPER LCMS2 GMP

Important settings:
  value of $LANG: ENU
  locale-coding-system: cp1252

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs
format-spec rfc822 mml easymenu mml-sec password-cache epa derived epg
epg-config gnus-util rmail rmail-loaddefs text-property-search time-date
subr-x seq byte-opt gv bytecomp byte-compile cconv mm-decode mm-bodies
mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs
cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils
tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type
mwheel dos-w32 ls-lisp disp-table term/w32-win w32-win w32-vars
term/common-win tool-bar dnd fontset image regexp-opt fringe
tabulated-list replace newcomment text-mode elisp-mode lisp-mode
prog-mode register page tab-bar menu-bar rfn-eshadow isearch timer
select scroll-bar mouse jit-lock font-lock syntax facemenu font-core
term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang
misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms
cp51932 hebrew greek romanian slovak czech european ethiopic indian
cyrillic chinese composite charscript charprop case-table epa-hook
jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice loaddefs
button faces cus-face macroexp files text-properties overlay sha1 md5
base64 format env code-pages mule custom widget hashtable-print-readable
backquote threads w32notify w32 lcms2 multi-tty make-network-process
emacs)

Memory information:
((conses 16 47294 6213)
 (symbols 48 6072 1)
 (strings 32 16900 2165)
 (string-bytes 1 532003)
 (vectors 16 10062)
 (vector-slots 8 130503 11604)
 (floats 8 21 242)
 (intervals 56 235 0)
 (buffers 1000 11))

[-- Attachment #2: Type: text/html, Size: 4281 bytes --]

bug#51740: 27.2; find-file-literally doesn't respect saveplace-mode

[Eli Zaretskii]

> From: Scott Otterson <scotto@sharpleaf.org>
> Date: Tue, 9 Nov 2021 19:06:52 -0800
> 
> The simplest way to make this better is to not allow find-file-literally to change the save-place-mode state.

I think this is the only solution.

> Better would be if it opened the file at the same cursor position as would find-file, and upon exit, appropriately
> set the save-place-mode state.

That's not really possible, since find-file-literally reads the file
into a buffer in a way that can completely change the relation between
the buffer position and the corresponding file byte offset -- due to
decoding of text and other transformations that affect this.

bug#51740: 27.2; find-file-literally doesn't respect saveplace-mode

[Lars Ingebrigtsen]

Eli Zaretskii <eliz@gnu.org> writes:

> That's not really possible, since find-file-literally reads the file
> into a buffer in a way that can completely change the relation between
> the buffer position and the corresponding file byte offset -- due to
> decoding of text and other transformations that affect this.

Yup.  So I've now done this in Emacs 29 (and not on the emacs-28 branch
since this isn't a regression).

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#51740: 27.2; find-file-literally doesn't respect saveplace-mode

[Scott Otterson]

[-- Attachment #1: Type: text/plain, Size: 649 bytes --]

That was fast.  Thanks!

On Wed, Nov 10, 2021 at 8:05 PM Lars Ingebrigtsen <larsi@gnus.org> wrote:

> Eli Zaretskii <eliz@gnu.org> writes:
>
> > That's not really possible, since find-file-literally reads the file
> > into a buffer in a way that can completely change the relation between
> > the buffer position and the corresponding file byte offset -- due to
> > decoding of text and other transformations that affect this.
>
> Yup.  So I've now done this in Emacs 29 (and not on the emacs-28 branch
> since this isn't a regression).
>
> --
> (domestic pets only, the antidote for overdose, milk.)
>    bloggy blog: http://lars.ingebrigtsen.no
>

[-- Attachment #2: Type: text/html, Size: 1127 bytes --]