From: Al Petrofsky <al@petrofsky.org>
To: Gregory Heytings <gregory@heytings.org>
Cc: 64075@debbugs.gnu.org
Subject: bug#64075: 28.2; ispell broken on uncolored terminals
Date: Wed, 14 Jun 2023 19:48:37 -0400 [thread overview]
Message-ID: <CAPMQwz432dbGwnoa1mdcW47ngX5m9dr8OEcJ0KQodZ2UhYHzaQ@mail.gmail.com> (raw)
In-Reply-To: <42ff58c7e8e4095a1f34@heytings.org>
[-- Attachment #1: Type: text/plain, Size: 1343 bytes --]
Ah, I see Eli fixed ispell-highlight-spelling-error-generic last year.
http://git.savannah.gnu.org/cgit/emacs.git/commit/lisp/textmodes/ispell.el?id=f3b876fa75042a1c00886e07d8491ac11824a892
Still, this anachronistic kludge should really be nuked entirely.
Even with the current fix, it fails to use ispell-highlight-face,
instead always using inverse-video.
By "nuked entirely" I mean:
(1) delete ispell-highlight-spelling-error
(2) delete ispell-highlight-spelling-error-generic
(3) rename ispell-highlight-spelling-error-overlay
to ispell-highlight-spelling-error
On Wed, Jun 14, 2023 at 7:25 PM Gregory Heytings <gregory@heytings.org>
wrote:
>
> >
> > emacs-28.2 -Q -nw --color=no
> > s t o n k s M-$ 1
> >
> > At this point, I expect to see the word "stonks" replaced with "stocks",
> > but it is instead replaced with "stockstonks".
> >
> > The problem seems to be in ispell-highlight-spelling-error-generic, a
> > 20th-century kludge from before face support for ttys was added in
> > emacs-21 in 2001. It's been unnecessary since then, and it looks like
> > it's been breaking ispell on colorless ttys since at least emacs-23.
> >
>
> This recipe can be reproduced with Emacs 25, 26, 27 and 28... but not with
> Emacs 29, in which "stonks" is indeed replaced with "stocks".
>
[-- Attachment #2: Type: text/html, Size: 1995 bytes --]
next prev parent reply other threads:[~2023-06-14 23:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-14 23:13 bug#64075: 28.2; ispell broken on uncolored terminals Al Petrofsky
2023-06-14 23:25 ` Gregory Heytings
2023-06-14 23:48 ` Al Petrofsky [this message]
2023-06-15 5:36 ` Eli Zaretskii
2023-06-15 6:34 ` Al Petrofsky
2023-06-15 7:48 ` Eli Zaretskii
2023-06-15 23:19 ` Al Petrofsky
2023-06-16 6:27 ` Eli Zaretskii
2023-06-15 5:23 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPMQwz432dbGwnoa1mdcW47ngX5m9dr8OEcJ0KQodZ2UhYHzaQ@mail.gmail.com \
--to=al@petrofsky.org \
--cc=64075@debbugs.gnu.org \
--cc=gregory@heytings.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).