From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Al Petrofsky Newsgroups: gmane.emacs.bugs Subject: bug#64075: 28.2; ispell broken on uncolored terminals Date: Wed, 14 Jun 2023 19:48:37 -0400 Message-ID: References: <42ff58c7e8e4095a1f34@heytings.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000f0534505fe1f971e" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31501"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 64075@debbugs.gnu.org To: Gregory Heytings Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jun 15 01:49:21 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q9aEr-0007wr-E0 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 15 Jun 2023 01:49:21 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q9aEZ-0003sC-7X; Wed, 14 Jun 2023 19:49:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q9aEY-0003s3-F1 for bug-gnu-emacs@gnu.org; Wed, 14 Jun 2023 19:49:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q9aEY-0003Mx-5t for bug-gnu-emacs@gnu.org; Wed, 14 Jun 2023 19:49:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q9aEY-0005j9-1z for bug-gnu-emacs@gnu.org; Wed, 14 Jun 2023 19:49:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Al Petrofsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 14 Jun 2023 23:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64075 X-GNU-PR-Package: emacs Original-Received: via spool by 64075-submit@debbugs.gnu.org id=B64075.168678653822006 (code B ref 64075); Wed, 14 Jun 2023 23:49:02 +0000 Original-Received: (at 64075) by debbugs.gnu.org; 14 Jun 2023 23:48:58 +0000 Original-Received: from localhost ([127.0.0.1]:45796 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q9aEU-0005is-Cr for submit@debbugs.gnu.org; Wed, 14 Jun 2023 19:48:58 -0400 Original-Received: from mail-pj1-f51.google.com ([209.85.216.51]:39062) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q9aES-0005ie-9o for 64075@debbugs.gnu.org; Wed, 14 Jun 2023 19:48:57 -0400 Original-Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-25e0fddf3a2so246500a91.0 for <64075@debbugs.gnu.org>; Wed, 14 Jun 2023 16:48:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686786530; x=1689378530; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=CrK34zsPNyXiFrhUs0YAybU7I7IVtva7GcPao3PrY9o=; b=dItLyJbZluoeWzdebnoeQgv7H6izwB0vuzD2ZJQXgewhGVxeoq5bcdpXunXWxtmLYY Vup4LqSlw/NxCl+Yion4yqAxEMBIBvzoTyvYswAM3TzpwUs27FoSfHCC+L+I2qphhLZc 3gRstH4PK7ZOHygIy1B6qO/9U+ouxVa08+Y75ntU+XPXYTKGsJrILHe9mxztq79ctQJY e8j8IZQYZb5viq/ecLUTMJ38P6hq0Otgoy27bt9URrbtzqaYjpLaGspIaJUJtuGxqosC C8PqZX/nBwJDOh5dkwyK7OB/v1qN8/a6BfPtxm+3xBjcFyi49dbP55Sgu31b58NETwAM r8tQ== X-Gm-Message-State: AC+VfDxq9GF+9hA1/qTBrTY7UtgVWCSbyBxUNjuznzyGOguqZQfIHvaX yubE5qxn6ZjEDK+09VtJbw/VV3S6AwRr7Uk27Tk= X-Google-Smtp-Source: ACHHUZ46XuysLI++ACU7NcgPU8pqaj0l3q3KvNZXOJ6xAozsucwc4+tmysUw3f8PAC8jOJB0BssL0/sQjDeTBcMtu6U= X-Received: by 2002:a17:90b:1bcf:b0:255:54c4:9a75 with SMTP id oa15-20020a17090b1bcf00b0025554c49a75mr18562606pjb.2.1686786530103; Wed, 14 Jun 2023 16:48:50 -0700 (PDT) In-Reply-To: <42ff58c7e8e4095a1f34@heytings.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:263387 Archived-At: --000000000000f0534505fe1f971e Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Ah, I see Eli fixed ispell-highlight-spelling-error-generic last year. http://git.savannah.gnu.org/cgit/emacs.git/commit/lisp/textmodes/ispell.el?= id=3Df3b876fa75042a1c00886e07d8491ac11824a892 Still, this anachronistic kludge should really be nuked entirely. Even with the current fix, it fails to use ispell-highlight-face, instead always using inverse-video. By "nuked entirely" I mean: (1) delete ispell-highlight-spelling-error (2) delete ispell-highlight-spelling-error-generic (3) rename ispell-highlight-spelling-error-overlay to ispell-highlight-spelling-error On Wed, Jun 14, 2023 at 7:25=E2=80=AFPM Gregory Heytings wrote: > > > > > emacs-28.2 -Q -nw --color=3Dno > > s t o n k s M-$ 1 > > > > At this point, I expect to see the word "stonks" replaced with "stocks"= , > > but it is instead replaced with "stockstonks". > > > > The problem seems to be in ispell-highlight-spelling-error-generic, a > > 20th-century kludge from before face support for ttys was added in > > emacs-21 in 2001. It's been unnecessary since then, and it looks like > > it's been breaking ispell on colorless ttys since at least emacs-23. > > > > This recipe can be reproduced with Emacs 25, 26, 27 and 28... but not wit= h > Emacs 29, in which "stonks" is indeed replaced with "stocks". > --000000000000f0534505fe1f971e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Ah, I see Eli fixed ispell-highlight-= spelling-error-generic last year.
http://git.savannah.gnu.org/cgit/emacs.git/commit/lisp/= textmodes/ispell.el?id=3Df3b876fa75042a1c00886e07d8491ac11824a892
Still, this anachronistic kludge should really be nuked entirely.
Even= with the current fix, it fails to use ispell-highlight-face,
instead al= ways using inverse-video.

By "nuked entirely" I mean:
= =C2=A0 =C2=A0(1) delete ispell-highlight-spelling-error
=C2=A0 =C2=A0(2)= delete ispell-highlight-spelling-error-generic
=C2=A0 =C2=A0(3) rename = ispell-highlight-spelling-error-overlay
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0to ispell-highlight-spelling-error

=
On W= ed, Jun 14, 2023 at 7:25=E2=80=AFPM Gregory Heytings <gregory@heytings.org> wrote:=

>
> emacs-28.2 -Q -nw --color=3Dno
> s t o n k s M-$ 1
>
> At this point, I expect to see the word "stonks" replaced wi= th "stocks",
> but it is instead replaced with "stockstonks".
>
> The problem seems to be in ispell-highlight-spelling-error-generic, a =
> 20th-century kludge from before face support for ttys was added in > emacs-21 in 2001.=C2=A0 It's been unnecessary since then, and it l= ooks like
> it's been breaking ispell on colorless ttys since at least emacs-2= 3.
>

This recipe can be reproduced with Emacs 25, 26, 27 and 28... but not with =
Emacs 29, in which "stonks" is indeed replaced with "stocks&= quot;.
--000000000000f0534505fe1f971e--