bug#11032: 24.0.94; illegible mode-line text (in dark themes?)

bug#11032: 24.0.94; illegible mode-line text (in dark themes?)

[Richard Copley]

Some faces are illegible if used on the mode-line when the default background is
dark but the mode line background is light. (Or at least, this can
happen in a dark
theme.)

For example (from emacs -Q):

Set the theme to "tsdh-dark".
M-x compile RET M-n dir RET # "dir" should succeed
C-x o                       # activate *Compilation*

The exit status 0 is shown with the background from 'mode-line
and the foreground from 'success. The (background dark)
version of 'success is used, so you get "green" on "grey75".
It should be "ForestGreen", since the background is light.

In GNU Emacs 24.0.94.1 (i386-mingw-nt6.1.7601)
 of 2012-03-15 on MACHINE
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
 `configure --with-gcc (4.6) --enable-checking --cflags -L
 c:/gnuwin32/lib -I c:/gnuwin32/include'

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: ENG
  value of $XMODIFIERS: nil
  locale-coding-system: cp1252
  default enable-multibyte-characters: t

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
M-x r e p o r t - e m <tab> <return>

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.

Load-path shadows:
None found.

Features:
(shadow sort gnus-util mail-extr emacsbug message format-spec rfc822 mml
easymenu mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231
mailabbrev gmm-utils mailheader sendmail regexp-opt rfc2047 rfc2045
ietf-drums mm-util mail-prsvr mail-utils time-date tooltip ediff-hook
vc-hooks lisp-float-type mwheel dos-w32 disp-table ls-lisp w32-win
w32-vars tool-bar dnd fontset image fringe lisp-mode register page
menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock
syntax facemenu font-core frame cham georgian utf-8-lang misc-lang
vietnamese tibetan thai tai-viet lao korean japanese hebrew greek
romanian slovak czech european ethiopic indian cyrillic chinese
case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer button
faces cus-face files text-properties overlay sha1 md5 base64 format env
code-pages mule custom widget hashtable-print-readable backquote
make-network-process multi-tty emacs)

bug#11032: 24.0.94; illegible mode-line text (in dark themes?)

[Chong Yidong]

Richard Copley <rcopley@gmail.com> writes:

> Some faces are illegible if used on the mode-line when the default
> background is dark but the mode line background is light. (Or at
> least, this can happen in a dark theme.)
>
> For example (from emacs -Q):
>
> Set the theme to "tsdh-dark".
> M-x compile RET M-n dir RET # "dir" should succeed
> C-x o                       # activate *Compilation*

Thanks for the bug report.  I have defined some new faces for
compilation messages on the mode line, and tweaked the default face
attributes and the built-in themes so that these messages are legible on
the mode-line.

bug#11032: 24.0.94; illegible mode-line text (in dark themes?)

[Richard Copley]

On 3 June 2012 15:38, Chong Yidong <cyd@gnu.org> wrote:
> Richard Copley <rcopley@gmail.com> writes:
>
>> Some faces are illegible if used on the mode-line when the default
>> background is dark but the mode line background is light. (Or at
>> least, this can happen in a dark theme.)
>>
>> For example (from emacs -Q):
>>
>> Set the theme to "tsdh-dark".
>> M-x compile RET M-n dir RET # "dir" should succeed
>> C-x o                       # activate *Compilation*
>
> Thanks for the bug report.  I have defined some new faces for
> compilation messages on the mode line, and tweaked the default face
> attributes and the built-in themes so that these messages are legible on
> the mode-line.

[Re-sending with the appropriate cc: line, and with apologies to Chong
Yidong for the duplicate email.]

Thank you. In the tsdh-dark theme, the successful exit status is now
much more legible on an active mode line. However, it is much less
legible on an inactive mode line. The rest of the mode line text (in
grey on grey) is also hard to read. I really think the bug is that the
wrong light-/dark-background version of the face is chosen, and no
amount of compromise with face colours will fix that. (Perhaps it
could be made a convention that a dark-background theme must have a
dark-background mode-line?)

bug#11032: 24.0.94; illegible mode-line text (in dark themes?)

[Richard Copley]

On 4 June 2012 13:44, Richard Copley <rcopley@gmail.com> wrote:
> On 3 June 2012 15:38, Chong Yidong <cyd@gnu.org> wrote:
>> Richard Copley <rcopley@gmail.com> writes:
>>
>>> Some faces are illegible if used on the mode-line when the default
>>> background is dark but the mode line background is light. (Or at
>>> least, this can happen in a dark theme.)
>>>
>>> For example (from emacs -Q):
>>>
>>> Set the theme to "tsdh-dark".
>>> M-x compile RET M-n dir RET # "dir" should succeed
>>> C-x o                       # activate *Compilation*
>>
>> Thanks for the bug report.  I have defined some new faces for
>> compilation messages on the mode line, and tweaked the default face
>> attributes and the built-in themes so that these messages are legible on
>> the mode-line.
>
> [Re-sending with the appropriate cc: line, and with apologies to Chong
> Yidong for the duplicate email.]
>
> Thank you. In the tsdh-dark theme, the successful exit status is now
> much more legible on an active mode line. However, it is much less
> legible on an inactive mode line. The rest of the mode line text (in
> grey on grey) is also hard to read. I really think the bug is that the
> wrong light-/dark-background version of the face is chosen, and no
> amount of compromise with face colours will fix that. (Perhaps it
> could be made a convention that a dark-background theme must have a
> dark-background mode-line?)

Sorry, I hadn't pulled new revisions when I thought I had, so I was
not looking at the new faces. The new colours work very nicely. Please
ignore my last comments.