From: Richard Copley <rcopley@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 15418@debbugs.gnu.org
Subject: bug#15418: 24.3.50; RCS annotate broken in vc-rcs.el r114131
Date: Wed, 25 Sep 2013 08:08:51 +0100 [thread overview]
Message-ID: <CAPM58ogQYCYHgL1MXSQebzhb1vHkXn9gLXdXUxamLErE9BTx0g@mail.gmail.com> (raw)
In-Reply-To: <jwvfvst4t6c.fsf-monnier+emacsbugs@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1433 bytes --]
The top of the stack trace is exactly the same as before, except for the
new name for "b".
buffer-substring-no-properties(nil 6747)
(cons (buffer-substring-no-properties (cadr pairs) (car pairs)) acc)
(setq acc (cons (buffer-substring-no-properties (cadr pairs) (car pairs))
acc))
(while pairs (setq acc (cons (buffer-substring-no-properties (cadr pairs)
(car pairs)) acc)) (setq pairs (cddr pairs)))
(let ((pairs (cons e (append @-holes (list vc-rcs--b)))) acc) (while
pairs (setq acc (cons (buffer-substring-no-properties (cadr pairs) (car
pairs)) acc)) (setq pairs (cddr pairs))) (apply (quote concat) acc))
(The next line of the backtrace has 159030 characters, most of which are
from the master file. Sorry again that I can't provide an example, but the
file doesn't belong to me.)
On 25 September 2013 01:55, Stefan Monnier <monnier@iro.umontreal.ca> wrote:
> >> > For some files under RCS version control, `vc-annotate' now fails with
> >> > error `(wrong-type-argument integer-or-marker-p nil)'.
> >> > I think the problem is with the variable `b' whose dynamic binding
> >> > was used by `gather' and set by `incg' (local functions in
> >> > `vc-rcs-parse'), prior to r114131.
> >> Indeed, it seems like there was some subtle dynamic scoping at play.
> >> Does the patch below fix your problem?
> > No, I'm afraid it does not. I get the same error.
>
> Can you show the new backtrace?
>
>
> Stefan
>
[-- Attachment #2: Type: text/html, Size: 2036 bytes --]
next prev parent reply other threads:[~2013-09-25 7:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-19 14:16 bug#15418: 24.3.50; RCS annotate broken in vc-rcs.el r114131 Richard Copley
2013-09-19 21:26 ` Stefan Monnier
2013-09-24 22:47 ` Richard Copley
2013-09-25 0:55 ` Stefan Monnier
2013-09-25 7:08 ` Richard Copley [this message]
2013-10-14 16:14 ` Richard Copley
2013-10-14 22:33 ` Richard Copley
2013-10-15 21:09 ` Richard Copley
2013-10-16 3:05 ` Stefan Monnier
2013-11-05 10:09 ` Richard Copley
2013-11-05 15:37 ` Stefan Monnier
2013-11-06 10:56 ` Richard Copley
2013-11-06 11:19 ` Richard Copley
2013-11-06 13:46 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPM58ogQYCYHgL1MXSQebzhb1vHkXn9gLXdXUxamLErE9BTx0g@mail.gmail.com \
--to=rcopley@gmail.com \
--cc=15418@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).