From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Richard Copley Newsgroups: gmane.emacs.bugs Subject: bug#15418: 24.3.50; RCS annotate broken in vc-rcs.el r114131 Date: Wed, 25 Sep 2013 08:08:51 +0100 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=047d7b6703a3f907cb04e72fec03 X-Trace: ger.gmane.org 1380092956 14144 80.91.229.3 (25 Sep 2013 07:09:16 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 25 Sep 2013 07:09:16 +0000 (UTC) Cc: 15418@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Sep 25 09:09:19 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VOjDo-0000eW-66 for geb-bug-gnu-emacs@m.gmane.org; Wed, 25 Sep 2013 09:09:16 +0200 Original-Received: from localhost ([::1]:49795 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VOjDn-0005e6-Nj for geb-bug-gnu-emacs@m.gmane.org; Wed, 25 Sep 2013 03:09:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49778) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VOjDf-0005dp-VE for bug-gnu-emacs@gnu.org; Wed, 25 Sep 2013 03:09:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VOjDb-0000Bl-6F for bug-gnu-emacs@gnu.org; Wed, 25 Sep 2013 03:09:07 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:54114) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VOjDb-0000Bh-1y for bug-gnu-emacs@gnu.org; Wed, 25 Sep 2013 03:09:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VOjDa-0006iT-9k for bug-gnu-emacs@gnu.org; Wed, 25 Sep 2013 03:09:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Richard Copley Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 25 Sep 2013 07:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 15418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 15418-submit@debbugs.gnu.org id=B15418.138009293625804 (code B ref 15418); Wed, 25 Sep 2013 07:09:02 +0000 Original-Received: (at 15418) by debbugs.gnu.org; 25 Sep 2013 07:08:56 +0000 Original-Received: from localhost ([127.0.0.1]:34174 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VOjDT-0006i6-FY for submit@debbugs.gnu.org; Wed, 25 Sep 2013 03:08:56 -0400 Original-Received: from mail-ea0-f170.google.com ([209.85.215.170]:44019) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VOjDQ-0006hx-Sr for 15418@debbugs.gnu.org; Wed, 25 Sep 2013 03:08:53 -0400 Original-Received: by mail-ea0-f170.google.com with SMTP id h14so2960802eak.29 for <15418@debbugs.gnu.org>; Wed, 25 Sep 2013 00:08:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=+iu68EPrEB3Caq1dsqyV1aNlDQccC69k5S/h30U5v1I=; b=HrOO16iXbtWs93QCSaRFto8RwvuKUNEVMh47Gm0vj/1XuBOiugiEDbQyQ/RSZVcAG8 fbuq8Dkb4Dqwi2yyqtBogPSuVGtNJDK1W35OyUGUPRzYJ3DJfE4KJU7rEn6ITp0XGxsh MNZRnzoG3JSDQ9nF26kbPYKQDC8oddGHb/SxSMJmH8r5HW32Axiy0Uy3iVvuzDM6KoAA +L0PEKsz2uasnJSk8nobJ1oiiy1Z1wCJGj8W037fa0Eo2DweTG3IQHdNN54Hz1OiYuYH KDNs1nOaiYrUj844nchSq677M4FU8O7A3BI3rgj8+2dSxFavYEOeK7R0wGBSPBtryzTN v/Sg== X-Received: by 10.14.223.1 with SMTP id u1mr53348794eep.10.1380092932055; Wed, 25 Sep 2013 00:08:52 -0700 (PDT) Original-Received: by 10.14.152.132 with HTTP; Wed, 25 Sep 2013 00:08:51 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:78728 Archived-At: --047d7b6703a3f907cb04e72fec03 Content-Type: text/plain; charset=ISO-8859-1 The top of the stack trace is exactly the same as before, except for the new name for "b". buffer-substring-no-properties(nil 6747) (cons (buffer-substring-no-properties (cadr pairs) (car pairs)) acc) (setq acc (cons (buffer-substring-no-properties (cadr pairs) (car pairs)) acc)) (while pairs (setq acc (cons (buffer-substring-no-properties (cadr pairs) (car pairs)) acc)) (setq pairs (cddr pairs))) (let ((pairs (cons e (append @-holes (list vc-rcs--b)))) acc) (while pairs (setq acc (cons (buffer-substring-no-properties (cadr pairs) (car pairs)) acc)) (setq pairs (cddr pairs))) (apply (quote concat) acc)) (The next line of the backtrace has 159030 characters, most of which are from the master file. Sorry again that I can't provide an example, but the file doesn't belong to me.) On 25 September 2013 01:55, Stefan Monnier wrote: > >> > For some files under RCS version control, `vc-annotate' now fails with > >> > error `(wrong-type-argument integer-or-marker-p nil)'. > >> > I think the problem is with the variable `b' whose dynamic binding > >> > was used by `gather' and set by `incg' (local functions in > >> > `vc-rcs-parse'), prior to r114131. > >> Indeed, it seems like there was some subtle dynamic scoping at play. > >> Does the patch below fix your problem? > > No, I'm afraid it does not. I get the same error. > > Can you show the new backtrace? > > > Stefan > --047d7b6703a3f907cb04e72fec03 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
The top of the stack trace is exactly the same a= s before, except for the new name for "b".

=A0 buffe= r-substring-no-properties(nil 6747)
=A0 (cons (buffer-substring-no-prope= rties (cadr pairs) (car pairs)) acc)
=A0 (setq acc (cons (buffer-substring-no-properties (cadr pairs) (car pairs= )) acc))
=A0 (while pairs (setq acc (cons (buffer-substring-no-propertie= s (cadr pairs) (car pairs)) acc)) (setq pairs (cddr pairs)))
=A0 (let ((= pairs (cons e (append @-holes (list vc-rcs--b)))) acc) (while pairs (setq a= cc (cons (buffer-substring-no-properties (cadr pairs) (car pairs)) acc)) (s= etq pairs (cddr pairs))) (apply (quote concat) acc))

(The next line of the backtrace has 159030 characters, most of wh= ich are from the master file. Sorry again that I can't provide an examp= le, but the file doesn't belong to me.)



On 25 September 2013 01:55, Stefan Monni= er <monnier@iro.umontreal.ca> wrote:
>> > For some files under RCS version control, `= vc-annotate' now fails with
>> > error `(wrong-type-argument integer-or-marker-p nil)'. >> > I think the problem is with the variable `b' whose dynami= c binding
>> > was used by `gather' and set by `incg' (local functio= ns in
>> > `vc-rcs-parse'), prior to r114131.
>> Indeed, it seems like there was some subtle dynamic scoping at pla= y.
>> Does the patch below fix your problem?
> No, I'm afraid it does not. I get the same error.

Can you show the new backtrace?


=A0 =A0 =A0 =A0 Stefan

--047d7b6703a3f907cb04e72fec03--