From: Andrew Whatson <whatson@gmail.com>
To: Andrea Corallo <akrl@sdf.org>
Cc: 43532@debbugs.gnu.org, Jim Myhrberg <contact@jimeh.me>,
Aloxaf Yin <aloxafx@gmail.com>
Subject: bug#43532: [feature/native-comp] *.eln file name hashing, algorithm doesn't seem to play nice with NATIVE_FULL_AOT and self-contained, Emacs.app builds for macOS
Date: Thu, 15 Oct 2020 19:38:48 +1000 [thread overview]
Message-ID: <CAPE069dvWGb=A6xg1Bnj+jz78G-VM18wgV-D=-qm+1A-Nuwy6g@mail.gmail.com> (raw)
In-Reply-To: <xjf8sc9nvkp.fsf@sdf.org>
Hi Andrea,
I added some debug messages to the loading procedure and determined
that the files were ignored because the timestamp check required the
eln to be newer than the source file. This makes sense when running
from the build directory or when the eln's are built with deferred
compilation, but doesn't work for packaging where they're usually
installed with the same timestamp.
Though the fix is trivial, I wonder whether a timestamp check is
needed at all. If we're already hashing the contents of the source
file, perhaps that's sufficient to detect when things are outdated?
Cheers,
Andrew
next prev parent reply other threads:[~2020-10-15 9:38 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-20 13:02 bug#43532: [feature/native-comp] *.eln file name hashing algorithm doesn't seem to play nice with NATIVE_FULL_AOT and self-contained Emacs.app builds for macOS Jim Myhrberg
2020-09-21 7:53 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-09-21 9:19 ` Jim Myhrberg
2020-09-21 10:26 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-09-21 13:02 ` Jim Myhrberg
2020-09-21 13:41 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-09-21 18:54 ` Jim Myhrberg
2020-09-21 19:38 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-09-21 21:17 ` Jim Myhrberg
2020-09-21 22:40 ` Jim Myhrberg
2020-09-22 7:58 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-09-22 9:43 ` Jim Myhrberg
2020-09-22 10:21 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-09-22 11:37 ` Jim Myhrberg
2020-09-22 13:00 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-09-29 15:52 ` bug#43532: [feature/native-comp] *.eln file name hashing, algorithm doesn't seem to play nice with NATIVE_FULL_AOT and self-contained, " Aloxaf
2020-09-29 18:46 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-09-29 19:48 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
[not found] ` <CA+6YrQz8QcASrajz-+QVS5p68VPhQy1Me2T179CzXADn72WYXg@mail.gmail.com>
2020-09-30 7:13 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
[not found] ` <efd04f70-ced3-9978-2280-2bb41ca14a2f@gmail.com>
2020-10-01 13:19 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-10-01 15:01 ` Aloxaf
2020-10-01 15:40 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-10-04 18:04 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-10-04 19:54 ` Jim Myhrberg
2020-10-04 20:54 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-10-04 23:17 ` Jim Myhrberg
2020-10-05 6:56 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-10-05 9:57 ` Jim Myhrberg
2020-10-05 15:09 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-10-07 4:09 ` Aloxaf Yin
2020-10-07 15:00 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-10-08 3:40 ` Aloxaf Yin
2020-10-14 0:12 ` Andrew Whatson
2020-10-14 6:57 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-10-15 9:38 ` Andrew Whatson [this message]
2020-10-15 10:54 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-10-15 12:04 ` Andrew Whatson
2020-10-15 12:56 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-10-15 13:11 ` Jim Myhrberg
2020-10-15 14:51 ` Aloxaf Yin
2020-10-15 15:02 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-10-15 6:52 ` bug#43532: [PATCH] Fix timestamp check when loading from eln (bug #43532) Andrew Whatson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPE069dvWGb=A6xg1Bnj+jz78G-VM18wgV-D=-qm+1A-Nuwy6g@mail.gmail.com' \
--to=whatson@gmail.com \
--cc=43532@debbugs.gnu.org \
--cc=akrl@sdf.org \
--cc=aloxafx@gmail.com \
--cc=contact@jimeh.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).