From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrew Whatson Newsgroups: gmane.emacs.bugs Subject: bug#43532: [feature/native-comp] *.eln file name hashing, algorithm doesn't seem to play nice with NATIVE_FULL_AOT and self-contained, Emacs.app builds for macOS Date: Thu, 15 Oct 2020 19:38:48 +1000 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16226"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 43532@debbugs.gnu.org, Jim Myhrberg , Aloxaf Yin To: Andrea Corallo Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 15 11:40:23 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kSzkE-00047H-Eq for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 15 Oct 2020 11:40:22 +0200 Original-Received: from localhost ([::1]:47454 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kSzkD-0005NI-Gr for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 15 Oct 2020 05:40:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43558) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kSzju-0005N2-PL for bug-gnu-emacs@gnu.org; Thu, 15 Oct 2020 05:40:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42820) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kSzju-0000z6-FR for bug-gnu-emacs@gnu.org; Thu, 15 Oct 2020 05:40:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kSzju-0006I2-C9 for bug-gnu-emacs@gnu.org; Thu, 15 Oct 2020 05:40:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andrew Whatson Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 15 Oct 2020 09:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43532 X-GNU-PR-Package: emacs Original-Received: via spool by 43532-submit@debbugs.gnu.org id=B43532.160275474724107 (code B ref 43532); Thu, 15 Oct 2020 09:40:02 +0000 Original-Received: (at 43532) by debbugs.gnu.org; 15 Oct 2020 09:39:07 +0000 Original-Received: from localhost ([127.0.0.1]:54366 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kSzj0-0006Gl-Rt for submit@debbugs.gnu.org; Thu, 15 Oct 2020 05:39:07 -0400 Original-Received: from mail-vk1-f181.google.com ([209.85.221.181]:39784) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kSziy-0006GG-U6 for 43532@debbugs.gnu.org; Thu, 15 Oct 2020 05:39:05 -0400 Original-Received: by mail-vk1-f181.google.com with SMTP id h74so461336vkh.6 for <43532@debbugs.gnu.org>; Thu, 15 Oct 2020 02:39:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=YwdHiQI6Hofe1l0W/OCz9yR+nPx+WL7I4Xq3PxktcSs=; b=IexgfFC4RiqsG4BuJVj8KHOHmU5XSHIC2F3X299iWBSflXeaSaC8+qiANfSm34JxOF j0iCeotgNnpOlbmPrKT1D7kbZ4xJC/6xYxR+CjFiCIhrJQzC+Vf8Bo3/t6Q012Dwc+Wm 1qb5HBLtloIpjSGTCkkrHF+8UoY9+K/UmxCAIeflYbciG81k8gpYhRKFbF19ETccnUkz 7on2QwTb2OIBpboVRAN2zfxZ1tQ+A/USuoecsNVr3Jv35m3bRC6rV0CCSbi5RP/o8sKN B8GsncjnwGO8jxiP3kJVDxLoAKLpgofWezPEfnjtYIhAMzikcxIpgiiHyy7UOC+joRDy 2Ihw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YwdHiQI6Hofe1l0W/OCz9yR+nPx+WL7I4Xq3PxktcSs=; b=NJ6NrDu5bb1zIrEV2GJHoUhp1T4ePhwPMPuVuKrzZgBQtYfnO3GLg+2fW3mX4fgnb0 ZNzgpC7KbclNd/twYBasUk/0E8twISb2EnbV2sZ2Xdeuigat/4p+844mECgGFkz8myya B9I/EokpEBKqTPbSnSPzX810kKwc9Dp8QFKWn/El41b3mrTXJZ4htF5kWVAZ77v+p427 vVick2CuaOUxTaG6O1qExnGOJkrQAhFCU4t5ONOBpWs6VK1CZQhnr1khayyyqnubKL9t 4OmT5ujMJHZy7xT+SQOIx4Eq/KfIMI5UVcWfJyEPeM6NeItiqEDx+OWQ5zapd3pxa1ct Z3HQ== X-Gm-Message-State: AOAM531teorTCcIuyg4+oTJv5DaL3o3ZV/PqssJ2AlhRsBy1TS3wy+dq fIIPjQ98nHZlSq4dq3L/cM+BLrDoIQ/NiEb5pjc= X-Google-Smtp-Source: ABdhPJymBmVxMkYIBIi1VB1zYTPQuLASlUdvckXE3HD4foGzg4Z3zR0JESrSEX9NenazSM5I0s/GngHOFkekxEZyY6Q= X-Received: by 2002:a1f:9a4f:: with SMTP id c76mr1877400vke.13.1602754739122; Thu, 15 Oct 2020 02:38:59 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:190559 Archived-At: Hi Andrea, I added some debug messages to the loading procedure and determined that the files were ignored because the timestamp check required the eln to be newer than the source file. This makes sense when running from the build directory or when the eln's are built with deferred compilation, but doesn't work for packaging where they're usually installed with the same timestamp. Though the fix is trivial, I wonder whether a timestamp check is needed at all. If we're already hashing the contents of the source file, perhaps that's sufficient to detect when things are outdated? Cheers, Andrew