From: Knut Anders Hatlen <kahatlen@gmail.com>
To: Yuan Fu <casouri@gmail.com>
Cc: 61026@debbugs.gnu.org
Subject: bug#61026: 29.0.60; c-ts-mode: Broken indentation for loops and conditions without brace
Date: Tue, 7 Feb 2023 11:41:17 +0100 [thread overview]
Message-ID: <CAP4q88xpOHHm+mqrZkfU5eNkmUf=vpfvhS-FdOVerhiHGdm7mA@mail.gmail.com> (raw)
In-Reply-To: <B6825C4D-A47E-4D36-AAB3-A18910D1F01B@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1338 bytes --]
tir. 7. feb. 2023 kl. 03:30 skrev Yuan Fu <casouri@gmail.com>:
>
> Knut Anders Hatlen <kahatlen@gmail.com> writes:
>
> > Hi,
> >
> > I'm still seeing odd indentation for conditions without braces. For
> > example, invoking c-ts-mode-indent-defun (C-c C-q) with the point inside
> > this function ...
> >
> > int f(int x) {
> > if (x > 1)
> > return x;
> > else
> > return x + 1;
> > }
> >
> > ... results in the following indentation with the default GNU style:
> >
> > int f(int x) {
> > if (x > 1)
> > return x;
> > else
> > return x + 1;
> > }
> >
> > I would have expected this:
> >
> > int f(int x) {
> > if (x > 1)
> > return x;
> > else
> > return x + 1;
> > }
> >
> > Is something more needed for this bug, or is the problem I'm seeing a
> > different bug?
>
> My bad, I made some changes and didn’t push them, and I’m sitting here
> wondering why everyone is seeing problems... Everything should indent
> fine now.
>
> Yuan
>
Thanks, Yuan!
It now seems to work fine with the GNU style, K&R style and Linux style.
With BSD style, however, it ends up like this:
int f(int x) {
if (x > 1)
return x;
else
return x + 1;
}
I assume the return statements should have been indented one more level
here too?
Best regards,
--
Knut Anders
[-- Attachment #2: Type: text/html, Size: 2083 bytes --]
prev parent reply other threads:[~2023-02-07 10:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-23 11:17 bug#61026: 29.0.60; c-ts-mode: Broken indentation for loops and conditions without brace Mohammed Sadiq
2023-01-25 20:21 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-26 7:54 ` Yuan Fu
2023-01-26 7:57 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-29 8:22 ` Yuan Fu
2023-01-29 8:55 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-05 20:32 ` Knut Anders Hatlen
2023-02-07 2:30 ` Yuan Fu
2023-02-07 10:41 ` Knut Anders Hatlen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAP4q88xpOHHm+mqrZkfU5eNkmUf=vpfvhS-FdOVerhiHGdm7mA@mail.gmail.com' \
--to=kahatlen@gmail.com \
--cc=61026@debbugs.gnu.org \
--cc=casouri@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).