unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Theodor Thornhill via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Mohammed Sadiq <sadiq@sadiqpk.org>
Cc: 61026@debbugs.gnu.org, Yuan Fu <casouri@gmail.com>
Subject: bug#61026: 29.0.60; c-ts-mode: Broken indentation for loops and conditions without brace
Date: Wed, 25 Jan 2023 21:21:27 +0100	[thread overview]
Message-ID: <87ilgu8iwo.fsf@thornhill.no> (raw)
In-Reply-To: <aba6c2b4bbaf97779bfc017eb14177c1@sadiqpk.org> (Mohammed Sadiq's message of "Mon, 23 Jan 2023 16:47:38 +0530")

Mohammed Sadiq <sadiq@sadiqpk.org> writes:

> The following code has broken indentation with c-ts-mode:
>
>   while (true)
>     if (true) {
>     puts ("Hello");
>   }
>
>   if (true)
>     if (true)
>       {
>       puts ("World");
>     }
>
> For which, I expect to get the following indentation (with default config):
>
>   while (true)
>     if (true) {
>       puts ("Hello");
>     }
>
>   if (true)
>     if (true)
>       {
>         puts ("World");
>       }
>
>

Thanks, Mohammed!

Yuan, I'm not sure the new brace counting method is a good enough
improvement just yet considering its complexity and the number of issues
we are seeing.  Do you see any simple fixes for these issues?

I can try to debug this this weekend, but not sure I really have time to
fix it.  All of these issues work fine in js-ts-mode or java-ts-mode, if
I'm not mistaken.

Theo





  reply	other threads:[~2023-01-25 20:21 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-23 11:17 bug#61026: 29.0.60; c-ts-mode: Broken indentation for loops and conditions without brace Mohammed Sadiq
2023-01-25 20:21 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-01-26  7:54 ` Yuan Fu
2023-01-26  7:57   ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-29  8:22 ` Yuan Fu
2023-01-29  8:55   ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-05 20:32 ` Knut Anders Hatlen
2023-02-07  2:30 ` Yuan Fu
2023-02-07 10:41   ` Knut Anders Hatlen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ilgu8iwo.fsf@thornhill.no \
    --to=bug-gnu-emacs@gnu.org \
    --cc=61026@debbugs.gnu.org \
    --cc=casouri@gmail.com \
    --cc=sadiq@sadiqpk.org \
    --cc=theo@thornhill.no \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).