unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Pip Cet <pipcet@gmail.com>
To: Daniel Colascione <dancol@dancol.org>
Cc: 46881@debbugs.gnu.org, Paul Eggert <eggert@cs.ucla.edu>
Subject: bug#46881: 28.0.50; pdumper dumping causes way too many syscalls
Date: Fri, 5 Mar 2021 02:30:13 +0000	[thread overview]
Message-ID: <CAOqdjBe8qDmYO8K93oA9k7Zf12cORWDeAAoFAUzACDc4K+SmyA@mail.gmail.com> (raw)
In-Reply-To: <90e99fc5-280d-63bb-9bc4-3efe89b9f9e2@dancol.org>

On Thu, Mar 4, 2021 at 10:26 PM Daniel Colascione <dancol@dancol.org> wrote:
> On 3/3/21 12:51 AM, Eli Zaretskii wrote:
> > Daniel, Paul: any comments?  In particular, is it safe to allocate
> > large amounts of memory off the heap while dumping?  A couple of
> > places in pdumper.c says some parts of code should call malloc.
>
> It looks fine, but wouldn't dumping to a FILE* (with internal buffering)
> do the same basic thing in a simpler way?

I initially set out to do that, but decided against it. We don't just
write sequentially (when FILE I/O helps, a little), we also have the
seek-and-fixup phase, and it didn't seem any simpler at that point..

> There aren't any particular
> constraints on the environment _during_ the dump: we even make new lisp
> objects. It's when loading the dump, early in initialization, that you
> have to be careful.

Thanks!

Pip





  reply	other threads:[~2021-03-05  2:30 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-02 20:33 bug#46881: 28.0.50; pdumper dumping causes way too many syscalls Pip Cet
2021-03-02 20:45 ` Pip Cet
2021-03-02 21:07   ` Alan Third
2021-03-03  7:10     ` Pip Cet
2021-03-03 19:57       ` Alan Third
2021-03-04  7:25         ` Pip Cet
2021-03-03  5:51   ` Eli Zaretskii
2021-03-03  7:35     ` Pip Cet
2021-03-03 15:09       ` Lars Ingebrigtsen
2021-03-03 19:35       ` Paul Eggert
2021-03-04 22:26     ` Daniel Colascione
2021-03-05  2:30       ` Pip Cet [this message]
2021-03-05  7:19         ` Eli Zaretskii
2021-03-05  7:38           ` Pip Cet
2021-03-05  7:54             ` Eli Zaretskii
2021-03-05  9:54               ` Pip Cet
2021-03-05 10:23                 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-05 12:06                 ` Eli Zaretskii
2021-03-05 12:49                   ` Lars Ingebrigtsen
2021-03-05 13:23                     ` Eli Zaretskii
2021-03-05 13:16                   ` Pip Cet
2021-03-05 14:02                     ` Pip Cet
2021-03-05 14:13                       ` Daniel Colascione
2021-03-05 14:55                       ` Eli Zaretskii
2021-03-05 15:12                         ` Pip Cet
2021-03-05  9:35             ` Andreas Schwab
2021-03-05  9:41               ` Pip Cet
2021-06-15  9:25 ` Mattias Engdegård
2021-06-15 12:58   ` Daniel Colascione
2021-06-15 13:06     ` Eli Zaretskii
2021-06-15 13:17       ` Lars Ingebrigtsen
2021-06-15 13:25         ` Daniel Colascione
2021-06-15 13:30           ` Eli Zaretskii
2021-06-15 15:32         ` Mattias Engdegård
2021-06-15 22:44           ` Daniel Colascione
2021-06-16  8:00             ` Mattias Engdegård
2021-06-16  8:14               ` Lars Ingebrigtsen
2021-06-16  8:16               ` Pip Cet
2021-06-16 14:13 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOqdjBe8qDmYO8K93oA9k7Zf12cORWDeAAoFAUzACDc4K+SmyA@mail.gmail.com \
    --to=pipcet@gmail.com \
    --cc=46881@debbugs.gnu.org \
    --cc=dancol@dancol.org \
    --cc=eggert@cs.ucla.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).