From: Pip Cet <pipcet@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 46881@debbugs.gnu.org, eggert@cs.ucla.edu
Subject: bug#46881: 28.0.50; pdumper dumping causes way too many syscalls
Date: Fri, 5 Mar 2021 13:16:14 +0000 [thread overview]
Message-ID: <CAOqdjBdPP6ogXOTGB0DDP=yZ6CZ9vmzaS4pwfrRmZirsh+M1qQ@mail.gmail.com> (raw)
In-Reply-To: <83v9a5yfc0.fsf@gnu.org>
On Fri, Mar 5, 2021 at 12:07 PM Eli Zaretskii <eliz@gnu.org> wrote:
> > From: Pip Cet <pipcet@gmail.com>
> > Date: Fri, 5 Mar 2021 09:54:32 +0000
> > Cc: Daniel Colascione <dancol@dancol.org>, eggert@cs.ucla.edu, 46881@debbugs.gnu.org
> >
> > My patch:
> >
> > real 0m1.988s
> > user 0m1.916s
> > sys 0m0.073s
> >
> > fwrite-based patch:
> >
> > real 0m3.576s
> > user 0m2.571s
> > sys 0m1.006s
>
> 30% slowdown and 1.5 sec absolute time difference doesn't sound bad
> enough to me to
It's a 30% slowdown of the entire dump process, including the
CPU-intensive part which loads Emacs. I think you get a better idea of
the performance difference from the "sys" numbers above.
And the absolute time difference is more than that, because Emacs is
dumped twice during each build; the first dump file is about 2.5 times
the size of the ultimate dump file, so my guess (as I said before,
unfortunately Intel decided to make this system not have a predictable
CPU clock, so I can't really run good benchmarks) is we're talking
about 4.5 seconds here.
> justify a homemade solution.
"Create a buffer in memory and do all the IO at once" is such an old
solution that even the GNU Coding Standards explicitly recommend it
(albeit for input files):
You could keep the entire input file in memory and scan it there
instead of using stdio
>I say let's go with stdio.
Maybe setbuffer(3) could help us here? I could run some benchmarks for
that if the idea isn't out of the question.
> > > > Also, we're not currently using fseek-and-write anywhere in Emacs.
> > >
> > > I don't see why this would be important.
> >
> > Because the stream returned by emacs_fopen might not be generally seekable?
>
> I don't see how that could happen.
It has, to me, but I'm willing to accept I did some inadvisable things first.
> > By preparing the data in memory and writing it in one go, which
> > doesn't require any of the major complications of implementing
> > buffered streams.
>
> There are no complications I can see, not in our sources. (And you
> don't actually write it in one go anyway, see emacs_full_write.)
Er, precisely. I was the one saying there are no complications, so we
shouldn't let the idea of "implementing our own buffered streams"
scare us, because that is a complicated project but it's also not what
we are doing.
> So let's go with the stdio solution, please.
Should I add a sync after every seek to make absolutely certain,
rather than merely likely, this will destroy someone's flash chip one
day?
Pip
next prev parent reply other threads:[~2021-03-05 13:16 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-02 20:33 bug#46881: 28.0.50; pdumper dumping causes way too many syscalls Pip Cet
2021-03-02 20:45 ` Pip Cet
2021-03-02 21:07 ` Alan Third
2021-03-03 7:10 ` Pip Cet
2021-03-03 19:57 ` Alan Third
2021-03-04 7:25 ` Pip Cet
2021-03-03 5:51 ` Eli Zaretskii
2021-03-03 7:35 ` Pip Cet
2021-03-03 15:09 ` Lars Ingebrigtsen
2021-03-03 19:35 ` Paul Eggert
2021-03-04 22:26 ` Daniel Colascione
2021-03-05 2:30 ` Pip Cet
2021-03-05 7:19 ` Eli Zaretskii
2021-03-05 7:38 ` Pip Cet
2021-03-05 7:54 ` Eli Zaretskii
2021-03-05 9:54 ` Pip Cet
2021-03-05 10:23 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-05 12:06 ` Eli Zaretskii
2021-03-05 12:49 ` Lars Ingebrigtsen
2021-03-05 13:23 ` Eli Zaretskii
2021-03-05 13:16 ` Pip Cet [this message]
2021-03-05 14:02 ` Pip Cet
2021-03-05 14:13 ` Daniel Colascione
2021-03-05 14:55 ` Eli Zaretskii
2021-03-05 15:12 ` Pip Cet
2021-03-05 9:35 ` Andreas Schwab
2021-03-05 9:41 ` Pip Cet
2021-06-15 9:25 ` Mattias Engdegård
2021-06-15 12:58 ` Daniel Colascione
2021-06-15 13:06 ` Eli Zaretskii
2021-06-15 13:17 ` Lars Ingebrigtsen
2021-06-15 13:25 ` Daniel Colascione
2021-06-15 13:30 ` Eli Zaretskii
2021-06-15 15:32 ` Mattias Engdegård
2021-06-15 22:44 ` Daniel Colascione
2021-06-16 8:00 ` Mattias Engdegård
2021-06-16 8:14 ` Lars Ingebrigtsen
2021-06-16 8:16 ` Pip Cet
2021-06-16 14:13 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOqdjBdPP6ogXOTGB0DDP=yZ6CZ9vmzaS4pwfrRmZirsh+M1qQ@mail.gmail.com' \
--to=pipcet@gmail.com \
--cc=46881@debbugs.gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).