unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Pip Cet <pipcet@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 46834@debbugs.gnu.org, Lars Ingebrigtsen <larsi@gnus.org>
Subject: bug#46834: 28.0.50; byte-compiling the standard counter closure fails
Date: Mon, 1 Mar 2021 15:16:22 +0000	[thread overview]
Message-ID: <CAOqdjBcp8zPsiBVaw5Tjkh7OxX-izsbi3i0OAzjbGRjcXE0BZg@mail.gmail.com> (raw)
In-Reply-To: <jwv1rczrlz5.fsf-monnier+emacs@gnu.org>

On Mon, Mar 1, 2021 at 2:34 PM Stefan Monnier <monnier@iro.umontreal.ca> wrote:
> and notice that the counter is not shared between the two functions :-(

I'd noticed that, but figured Stefan wouldn't accept "partial byte
compilation" as a reasonable bug scenario :-)

That said, the comment in byte-compile--reify-function is incorrect:
since closures use alists and "let" uses proper lists, we can't share
structure between them, so the return value will be equivalent to a
snapshot of FUN, not "equal" to FUN itself. OTOH, even changing that
wouldn't help as byte-compiled closures use a third format to store
the bindings, IIUC.

I've been meaning to ask, is there anything like an XFAIL test in our
current framework? This would be an excellent use for one of those.

Pip





  reply	other threads:[~2021-03-01 15:16 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-28 15:04 bug#46834: 28.0.50; byte-compiling the standard counter closure fails Pip Cet
2021-02-28 19:57 ` Pip Cet
2021-02-28 20:34   ` Pip Cet
2021-03-01 14:23     ` Stefan Monnier
2021-03-01 15:01       ` Pip Cet
2021-03-01 16:02         ` Stefan Monnier
2021-03-02  7:00           ` Lars Ingebrigtsen
2021-03-02  7:31             ` Pip Cet
2021-03-02  7:34               ` Lars Ingebrigtsen
2021-03-02  7:36                 ` Pip Cet
2021-03-02 13:16                 ` Eli Zaretskii
2021-03-02 13:19                   ` Pip Cet
2021-03-02 13:48                     ` Eli Zaretskii
2021-03-01 13:16   ` Lars Ingebrigtsen
2021-03-01 14:34     ` Stefan Monnier
2021-03-01 15:16       ` Pip Cet [this message]
2021-03-01 16:15         ` Stefan Monnier
2021-03-01 16:41           ` Pip Cet
2021-03-01 17:01             ` Stefan Monnier
2021-03-01 17:13               ` Pip Cet
2021-03-01 16:31         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOqdjBcp8zPsiBVaw5Tjkh7OxX-izsbi3i0OAzjbGRjcXE0BZg@mail.gmail.com \
    --to=pipcet@gmail.com \
    --cc=46834@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).