From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Pip Cet Newsgroups: gmane.emacs.bugs Subject: bug#46834: 28.0.50; byte-compiling the standard counter closure fails Date: Mon, 1 Mar 2021 15:16:22 +0000 Message-ID: References: <8735xf8154.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2938"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 46834@debbugs.gnu.org, Lars Ingebrigtsen To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Mar 01 16:18:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lGkJG-0000dU-Cg for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 01 Mar 2021 16:18:10 +0100 Original-Received: from localhost ([::1]:60898 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lGkJF-0003it-Dp for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 01 Mar 2021 10:18:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57270) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lGkJ8-0003hq-Rh for bug-gnu-emacs@gnu.org; Mon, 01 Mar 2021 10:18:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38805) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lGkJ8-0004OT-LD for bug-gnu-emacs@gnu.org; Mon, 01 Mar 2021 10:18:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lGkJ8-0004Z4-Hf for bug-gnu-emacs@gnu.org; Mon, 01 Mar 2021 10:18:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Pip Cet Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 01 Mar 2021 15:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46834 X-GNU-PR-Package: emacs Original-Received: via spool by 46834-submit@debbugs.gnu.org id=B46834.161461182517438 (code B ref 46834); Mon, 01 Mar 2021 15:18:02 +0000 Original-Received: (at 46834) by debbugs.gnu.org; 1 Mar 2021 15:17:05 +0000 Original-Received: from localhost ([127.0.0.1]:50344 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lGkID-0004XC-B1 for submit@debbugs.gnu.org; Mon, 01 Mar 2021 10:17:05 -0500 Original-Received: from mail-ot1-f42.google.com ([209.85.210.42]:37982) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lGkIC-0004W3-B4 for 46834@debbugs.gnu.org; Mon, 01 Mar 2021 10:17:04 -0500 Original-Received: by mail-ot1-f42.google.com with SMTP id s3so16775464otg.5 for <46834@debbugs.gnu.org>; Mon, 01 Mar 2021 07:17:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fAj0Vn502nmYrz4udBhfHS+U5oha3C0Cf09aOk0CEAM=; b=DKaWj8ziKFaSLhy1EcexSdFJWqGbwyoRz/ZgqcPtZZ3iQVbr8hCD0c2r8JCvrIo81Z wULiW731Wezh60sdQsRwXMJCUhVGFzVZDaOOx4my1OCpPUusR5dMkqBwx/8EOPrtXUS0 R+6w7+kAWKRgxLc5Am3a/TABhMJIB6xzDsjluSkOKv9rmlFJfRaK/sUAQMRCQea05NyR NgCjBcV7fTUWx3jAgBJKIDvJAMUxULp3CZkXH4KdameRd1sdLZ1+efzMV8s7f6pj5VvZ p1dSUnFE2qTAela96qwSkBQtt57otYzVt9tHjh/KP11q80eW8CUnmZS2uOMQ/mV3qx0S 6/Mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fAj0Vn502nmYrz4udBhfHS+U5oha3C0Cf09aOk0CEAM=; b=SDg1lKYsDIidOj6ptcaAfT1roYvwDzidrpWRfwFjM4Iqnt0tRHfTlufYVIODfmIsBa AIu/l7hxRc8Zza3PaJZchl4CMmlwORrXmP+DJkRyHw9k18JLRs0LkNDLqCv3WUvVOD1z SfrbJ6Y0YgjE5oxTfFvLy5nzqcdUn7nZxF5F6v92PCx8qvCFfTv9GqxsIiWntm9HwMs9 HRG57gGpFWGKGVtJ5sMwxTjRT4j2E4Uv+95i/3rL/FCBN2cM4MdqTegc47zuoiMo5FTJ Trw34AGf8Cmp8rzxyiQ3A6LYP7ecqsunZBWOhw2ZWMs6j0HweqKRIO0VbySo2CvQNWZZ 3ibw== X-Gm-Message-State: AOAM5335mrxC/lIPwv2eYJeEu5agdM05B5++gce03mxMoHZH9cdQj5Uf Jiujj75cSe2k3XyDQf6wWuMR1oKV6wO4F1BvZIY= X-Google-Smtp-Source: ABdhPJwbLpshYRduBvuj85Yuw2S1F8g9rIXAoXHCGOC7CcGre2G5WBIqkEYzjsTGfhiRG1zSvy8eiu/ExUhcn1XJ57s= X-Received: by 2002:a05:6830:3090:: with SMTP id f16mr13833089ots.292.1614611818761; Mon, 01 Mar 2021 07:16:58 -0800 (PST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:201104 Archived-At: On Mon, Mar 1, 2021 at 2:34 PM Stefan Monnier wrote: > and notice that the counter is not shared between the two functions :-( I'd noticed that, but figured Stefan wouldn't accept "partial byte compilation" as a reasonable bug scenario :-) That said, the comment in byte-compile--reify-function is incorrect: since closures use alists and "let" uses proper lists, we can't share structure between them, so the return value will be equivalent to a snapshot of FUN, not "equal" to FUN itself. OTOH, even changing that wouldn't help as byte-compiled closures use a third format to store the bindings, IIUC. I've been meaning to ask, is there anything like an XFAIL test in our current framework? This would be an excellent use for one of those. Pip