unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Liu Hui <liuhui1610@gmail.com>
To: 63411@debbugs.gnu.org
Subject: bug#63411: 29.0.90; pcomplete/systemctl cannot complete units for old versions of systemd
Date: Wed, 10 May 2023 17:47:09 +0800	[thread overview]
Message-ID: <CAOQTW-NzYNh6HBHTr52bwsT306p_C2XvAavaiPOjCvA-8cCwjQ@mail.gmail.com> (raw)

Hi,

It is very convenient that Emacs 29 supports eshell completion for
systemctl, but I find units cannot be completed on Ubuntu 20.04 LTS:

1. emacs -Q
2. M-x eshell
3. type "systemctl stop ", and press TAB

There is no completion for units.

The reason is that 'pcmpl-linux--systemd-units' uses a new option
'--legend=no' that is introduced since Feb 18, 2021[1], and the option
cannot be recognized by systemd v245 on my system. Since the old
option '--no-legend' is still kept for compatibility[2], I suggest we
can just replace '--legend=no' with '--no-legend' to make systemctl
completion works for old systems.

[1] https://github.com/systemd/systemd/pull/18596
[2] https://github.com/systemd/systemd/blob/main/src/systemctl/systemctl.c#L485

Best,
Liu Hui





             reply	other threads:[~2023-05-10  9:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-10  9:47 Liu Hui [this message]
2023-05-17  8:53 ` bug#63411: [PATCH] pcomplete/systemctl cannot complete units for old versions of systemd Liu Hui
2023-05-18 10:40   ` Eli Zaretskii
2023-05-18 13:29     ` Liu Hui
2023-05-18 14:16       ` Eli Zaretskii
2023-05-18 18:57         ` Jim Porter
2023-05-20 15:02           ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOQTW-NzYNh6HBHTr52bwsT306p_C2XvAavaiPOjCvA-8cCwjQ@mail.gmail.com \
    --to=liuhui1610@gmail.com \
    --cc=63411@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).