unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Liu Hui <liuhui1610@gmail.com>
Cc: 63411@debbugs.gnu.org
Subject: bug#63411: [PATCH] pcomplete/systemctl cannot complete units for old versions of systemd
Date: Thu, 18 May 2023 17:16:16 +0300	[thread overview]
Message-ID: <83pm6xvi6n.fsf@gnu.org> (raw)
In-Reply-To: <CAOQTW-N3n+01oHsz4125mLW+NpfrmoHVrsDSacbsAak_eS0GWA@mail.gmail.com> (message from Liu Hui on Thu, 18 May 2023 21:29:46 +0800)

> From: Liu Hui <liuhui1610@gmail.com>
> Date: Thu, 18 May 2023 21:29:46 +0800
> Cc: 63411@debbugs.gnu.org
> 
> > I'm not an expert on systemctl; would someone who uses that please
> > tell if this could have any downsides?  E.g., is --no-legend expected
> > to be deprecated, perhaps resulting in a warning message or something?
> > If not, why did the systemd developers add another option with the
> > same semantics?
> 
> --no-legend is indeed superseded by --legend=yes/no in systemd v248+,
> but it is not deprecated. It is kept for compatibility and is totally
> equivalent to --legend=no, and doesn't produce any warning message. I
> have tested with systemctl v249 on Ubuntu 22.04 and the outputs are
> same. In fact, the point of the new option is it allows to display
> legends by --legend=yes in spite of other options such as --quiet,
> which is explained in https://github.com/systemd/systemd/pull/18596.

Thanks, I think I will wait for a few days to let others chime in.

> Another simple solution is adding a variable, e.g.
> pcmpl-linux-systemd-list-unit-arguments, to allow users to change
> options passing to systemctl. WDYT?

If --no-legend will continue to be supported for the observable
future, asking users to control that would be an annoyance, I think.





  reply	other threads:[~2023-05-18 14:16 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-10  9:47 bug#63411: 29.0.90; pcomplete/systemctl cannot complete units for old versions of systemd Liu Hui
2023-05-17  8:53 ` bug#63411: [PATCH] " Liu Hui
2023-05-18 10:40   ` Eli Zaretskii
2023-05-18 13:29     ` Liu Hui
2023-05-18 14:16       ` Eli Zaretskii [this message]
2023-05-18 18:57         ` Jim Porter
2023-05-20 15:02           ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83pm6xvi6n.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=63411@debbugs.gnu.org \
    --cc=liuhui1610@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).