From: Liu Hui <liuhui1610@gmail.com>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: 66982@debbugs.gnu.org
Subject: bug#66982: 30.0.50; Cannot delete bookmark of inaccessible remote file
Date: Fri, 10 Nov 2023 12:29:03 +0800 [thread overview]
Message-ID: <CAOQTW-N9Cj58iRu+cXgNO1d0QwoRtoJ+3MqUc86gykkt4qgbLA@mail.gmail.com> (raw)
In-Reply-To: <874jhweize.fsf@gmx.de>
Michael Albinus <michael.albinus@gmx.de> 于2023年11月8日周三 16:40写道:
> Thank you for the recipe, I can reproduce the problem. It happens,
> because in `bookmark--remove-fringe-mark' there is a call of
> `expand-file-name', which blocks if a remote file is not reachable.
>
> Could you pls check the appended patch? It fixes your recipe for me, and
> shouldn't harm other use cases.
Thank you! I confirm it works.
BTW, I find binding non-essential to t fixes a similar problem caused
by abbreviate/expand-file-name on remote files:
1. save the following text to file A:
;;; -*- coding: utf-8; mode: lisp-data -*-
(("/ssh:192.168.0.100:~/a.txt" . 282))
2. emacs -Q --eval '(setq save-place-file <file A>)' -f save-place-mode
diff --git a/lisp/saveplace.el b/lisp/saveplace.el
index 590c55d2609..2dda3b4d44b 100644
--- a/lisp/saveplace.el
+++ b/lisp/saveplace.el
@@ -156,7 +156,8 @@ save-place-abbreviate-file-names
:set (lambda (sym val)
(set-default sym val)
(or save-place-loaded (save-place-load-alist-from-file))
- (let ((fun (if val #'abbreviate-file-name #'expand-file-name)))
+ (let ((non-essential t)
+ (fun (if val #'abbreviate-file-name #'expand-file-name)))
(setq save-place-alist
(cl-delete-duplicates
(cl-loop for (k . v) in save-place-alist
next prev parent reply other threads:[~2023-11-10 4:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-07 10:18 bug#66982: 30.0.50; Cannot delete bookmark of inaccessible remote file Liu Hui
2023-11-08 8:40 ` Michael Albinus
2023-11-10 4:29 ` Liu Hui [this message]
2023-11-10 10:24 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOQTW-N9Cj58iRu+cXgNO1d0QwoRtoJ+3MqUc86gykkt4qgbLA@mail.gmail.com \
--to=liuhui1610@gmail.com \
--cc=66982@debbugs.gnu.org \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).