From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Liu Hui Newsgroups: gmane.emacs.bugs Subject: bug#66982: 30.0.50; Cannot delete bookmark of inaccessible remote file Date: Fri, 10 Nov 2023 12:29:03 +0800 Message-ID: References: <874jhweize.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38886"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 66982@debbugs.gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Nov 10 05:30:55 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r1JAV-0009wZ-5c for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 10 Nov 2023 05:30:55 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r1JA1-0000vM-Ge; Thu, 09 Nov 2023 23:30:25 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r1J9y-0000sN-U8 for bug-gnu-emacs@gnu.org; Thu, 09 Nov 2023 23:30:23 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r1J9y-0006MV-Kw for bug-gnu-emacs@gnu.org; Thu, 09 Nov 2023 23:30:22 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r1JAc-0000gg-4T for bug-gnu-emacs@gnu.org; Thu, 09 Nov 2023 23:31:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Liu Hui Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 10 Nov 2023 04:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66982 X-GNU-PR-Package: emacs Original-Received: via spool by 66982-submit@debbugs.gnu.org id=B66982.16995906032478 (code B ref 66982); Fri, 10 Nov 2023 04:31:02 +0000 Original-Received: (at 66982) by debbugs.gnu.org; 10 Nov 2023 04:30:03 +0000 Original-Received: from localhost ([127.0.0.1]:49288 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r1J9f-0000du-Ax for submit@debbugs.gnu.org; Thu, 09 Nov 2023 23:30:03 -0500 Original-Received: from mail-vs1-xe30.google.com ([2607:f8b0:4864:20::e30]:53505) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r1J9c-0000cx-F3 for 66982@debbugs.gnu.org; Thu, 09 Nov 2023 23:30:02 -0500 Original-Received: by mail-vs1-xe30.google.com with SMTP id ada2fe7eead31-45d8c405696so632663137.3 for <66982@debbugs.gnu.org>; Thu, 09 Nov 2023 20:29:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699590555; x=1700195355; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=IlNCz3w9LXQbauc+yvqJc0sr2Dt63m6Caxy3rx9sG5A=; b=eHaxNSgw7jCM5ufWGCwH5D/iMuz/hmwo4QRgJ21HvYr9HtOSL0g95LtdjBz4MqsYFJ hmKNkFUKvxURh3kjnOSG5DBBF4HO14gS/zwJUIIgQz74wQ3uNwmBriTPgRoOIJkqq7JL yj35I0jMehPHq8R/a12kNrGkEfv0bf77KH4KM1MIejGcBFEr/TqQ5wIVILPK+l3hINhF hzjwSBqSytsz7pTg0e6GeG+fegcbRHchGec+kvb40SWIYGLOWKEr040T8471Lx/2b3kg wmXn6YfUnvjrg9I3A90vIRgrnGAVy+VMj473TXhOHdWp4wzux6QFxbo3Rd/5UcqAVYg7 anpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699590555; x=1700195355; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IlNCz3w9LXQbauc+yvqJc0sr2Dt63m6Caxy3rx9sG5A=; b=jF4DNEYRoZ+ELFRKR7lqDEJJDJ5x9o68vTvDMaqcnuUwSgBaLFSYtIiXlgYGW+C6S7 HTVe4wOglsGz2EZMD2nufXW7VC3Ng+pgA6Os7+D9zMSl6pzZ75FazPzuOgX2gpuMh/vy T/x8lOfr/UWX0aCpjR492+GoivB1kaUuVs1PYHt7RRU5MzTgRIOdEI4yX8Kd3Wp3xW6N oCJHK+8BAcSlhBywyCeTf1wd0KQqWMIGHTYEmqHiLK/QjZwZuzrhjlQDTH1lP8dCtaDe U7krhLZYfm/IppitXRGJ/GJ6xEA6hyDKU8uYJRrOcw8VI2GJFoFvro+1pTx3ycgInl0r 2/Ag== X-Gm-Message-State: AOJu0YzL3VXgn9EKd9AdqDsKehBU1b7AEo8l/jkOOFTCuoJgJQ61gGaC Q3sKNMPNA7sOgz7E6hLwGwZzsoZcZyKydByG350= X-Google-Smtp-Source: AGHT+IG8QtlSZS130ZsB1c7OnzVwqXqZnXeM1QEDc6m43N9C7luj1dqksg8pqbxr7FhmwrMwxjp2RO7mQcBvfh9/J7Q= X-Received: by 2002:a67:b844:0:b0:45d:d55:a419 with SMTP id o4-20020a67b844000000b0045d0d55a419mr6772361vsh.30.1699590555229; Thu, 09 Nov 2023 20:29:15 -0800 (PST) In-Reply-To: <874jhweize.fsf@gmx.de> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:274084 Archived-At: Michael Albinus =E4=BA=8E2023=E5=B9=B411=E6=9C=888= =E6=97=A5=E5=91=A8=E4=B8=89 16:40=E5=86=99=E9=81=93=EF=BC=9A > Thank you for the recipe, I can reproduce the problem. It happens, > because in `bookmark--remove-fringe-mark' there is a call of > `expand-file-name', which blocks if a remote file is not reachable. > > Could you pls check the appended patch? It fixes your recipe for me, and > shouldn't harm other use cases. Thank you! I confirm it works. BTW, I find binding non-essential to t fixes a similar problem caused by abbreviate/expand-file-name on remote files: 1. save the following text to file A: ;;; -*- coding: utf-8; mode: lisp-data -*- (("/ssh:192.168.0.100:~/a.txt" . 282)) 2. emacs -Q --eval '(setq save-place-file )' -f save-place-mode diff --git a/lisp/saveplace.el b/lisp/saveplace.el index 590c55d2609..2dda3b4d44b 100644 --- a/lisp/saveplace.el +++ b/lisp/saveplace.el @@ -156,7 +156,8 @@ save-place-abbreviate-file-names :set (lambda (sym val) (set-default sym val) (or save-place-loaded (save-place-load-alist-from-file)) - (let ((fun (if val #'abbreviate-file-name #'expand-file-name))) + (let ((non-essential t) + (fun (if val #'abbreviate-file-name #'expand-file-name))) (setq save-place-alist (cl-delete-duplicates (cl-loop for (k . v) in save-place-alist