unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#69984: 30.0.50; missing "save-restriction" in flymake--update-eol-overlays
@ 2024-03-24 17:59 Paul Nelson
  2024-03-28 10:16 ` Eli Zaretskii
  0 siblings, 1 reply; 2+ messages in thread
From: Paul Nelson @ 2024-03-24 17:59 UTC (permalink / raw)
  To: 69984

Hi,

This seems like an obvious "one-word" bug ("save-excursion" should be
"save-restriction"), so I'll be brief, but please let me know if more
details would be helpful.

Steps to reproduce: when using flymake with
flymake-show-diagnostics-at-end-of-line set to t in a narrowed buffer,
the narrowing goes away after a couple updates.

I traced this down to the function noted in the subject.  Changing
save-restriction to save-excursion fixed the bug for me.

Thanks, best,

Paul





^ permalink raw reply	[flat|nested] 2+ messages in thread

* bug#69984: 30.0.50; missing "save-restriction" in flymake--update-eol-overlays
  2024-03-24 17:59 bug#69984: 30.0.50; missing "save-restriction" in flymake--update-eol-overlays Paul Nelson
@ 2024-03-28 10:16 ` Eli Zaretskii
  0 siblings, 0 replies; 2+ messages in thread
From: Eli Zaretskii @ 2024-03-28 10:16 UTC (permalink / raw)
  To: Paul Nelson; +Cc: 69984-done

> From: Paul Nelson <ultrono@gmail.com>
> Date: Sun, 24 Mar 2024 18:59:48 +0100
> 
> Hi,
> 
> This seems like an obvious "one-word" bug ("save-excursion" should be
> "save-restriction"), so I'll be brief, but please let me know if more
> details would be helpful.
> 
> Steps to reproduce: when using flymake with
> flymake-show-diagnostics-at-end-of-line set to t in a narrowed buffer,
> the narrowing goes away after a couple updates.
> 
> I traced this down to the function noted in the subject.  Changing
> save-restriction to save-excursion fixed the bug for me.

Thanks, I've changed that to save-restriction on the master branch,
and I'm therefore closing this bug.





^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-03-28 10:16 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-24 17:59 bug#69984: 30.0.50; missing "save-restriction" in flymake--update-eol-overlays Paul Nelson
2024-03-28 10:16 ` Eli Zaretskii

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).