unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#9809: 24.0.90; flyspell-auto-correct-word hard to access in org-mode
@ 2011-10-20 15:51 Eric Hanchrow
  2012-03-23  0:33 ` Glenn Morris
  0 siblings, 1 reply; 6+ messages in thread
From: Eric Hanchrow @ 2011-10-20 15:51 UTC (permalink / raw)
  To: 9809

This bug report will be sent to the Bug-GNU-Emacs mailing list
and the GNU bug tracker at debbugs.gnu.org.  Please check that
the From: line contains a valid email address.  After a delay of up
to one day, you should receive an acknowledgement at that address.

Please write in English if possible, as the Emacs maintainers
usually do not have translators for other languages.

Please describe exactly what actions triggered the bug, and
the precise symptoms of the bug.  If you can, give a recipe
starting from `emacs -Q':

I started emacs with "emacs -Q".  Then I typed

    M-x o r g - m o d e <return> M-x f l y s p e l l -
    m o d e <return> C-h c <M-tab> C-h c M-TAB

C-h c <M-tab> showed me "<M-tab> runs the command pcomplete".
C-h c  M-TAB (which I typed via Ctrl+Alt+i) showed me "M-TAB runs the
command flyspell-auto-correct-word".

I expected _both_ key events -- <M-tab> and M-TAB -- to show me
flyspell-auto-correct-word.

This tripped me up because I wanted to spell-check a buffer that
happened to already be in org-mode; I assumed that I could invoke
flyspell-auto-correct-word by typing Alt+TAB, as has always been the
case in the past.  In this buffer, however, I needed to type Ctrl+Alt+i,
which was awkward and surprising.  (Plus I don't know what 'pcomplete'
does, and thus wouldn't at all mind if it wasn't accessible via Alt+TAB).

If Emacs crashed, and you have the Emacs process in the gdb debugger,
please include the output from the following gdb commands:
    `bt full' and `xbacktrace'.
For information about debugging Emacs, please read the file
/usr/local/src/emacs-git/master/etc/DEBUG.


In GNU Emacs 24.0.90.1 (i686-pc-linux-gnu, GTK+ Version 2.24.4)
 of 2011-10-09 on erich-laptop
Windowing system distributor `The X.Org Foundation', version 11.0.11004000
Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: nil
  locale-coding-system: utf-8-unix
  default enable-multibyte-characters: t

Major mode: Org

Minor modes in effect:
  flyspell-mode: t
  tooltip-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
M-x o r g - m o d e <return> M-x f l y s p e l l -
m o d e <return> C-h c <M-tab> C-h c M-TAB M-x r e
p o r t - e m c a s - b <backspace> <backspace> <backspace>
<backspace> <backspace> a c s - b u f <backspace> g
<return>

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.
OVERVIEW
Starting new Ispell process [default] ...
<M-tab> runs the command pcomplete
M-TAB runs the command flyspell-auto-correct-word

Load-path shadows:
None found.

Features:
(shadow sort gnus-util mail-extr message rfc822 mml mml-sec mm-decode
mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums
mm-util mail-prsvr mailabbrev mail-utils gmm-utils mailheader emacsbug
thingatpt flyspell ispell org-wl org-w3m org-vm org-rmail org-mhe
org-mew org-irc org-jsinfo org-infojs org-html format-spec org-exp
ob-exp org-exp-blocks org-agenda org-info org-gnus org-docview
org-bibtex bibtex org-bbdb org byte-opt warnings bytecomp byte-compile
cconv macroexp advice help-fns advice-preload ob-emacs-lisp ob-tangle
ob-ref ob-lob ob-table org-footnote org-src ob-comint ob-keys ob ob-eval
org-pcomplete pcomplete comint ring org-list org-faces org-compat
org-entities org-macs noutline outline easy-mmode regexp-opt cal-menu
easymenu calendar cal-loaddefs time-date tooltip ediff-hook vc-hooks
lisp-float-type mwheel x-win x-dnd tool-bar dnd fontset image fringe
lisp-mode register page menu-bar rfn-eshadow timer select scroll-bar
mouse jit-lock font-lock syntax facemenu font-core frame cham georgian
utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean
japanese hebrew greek romanian slovak czech european ethiopic indian
cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev
minibuffer loaddefs button faces cus-face files text-properties overlay
sha1 md5 base64 format env code-pages mule custom widget
hashtable-print-readable backquote make-network-process dbusbind
dynamic-setting system-font-setting font-render-setting move-toolbar gtk
x-toolkit x multi-tty emacs)





^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#9809: 24.0.90; flyspell-auto-correct-word hard to access in org-mode
  2011-10-20 15:51 bug#9809: 24.0.90; flyspell-auto-correct-word hard to access in org-mode Eric Hanchrow
@ 2012-03-23  0:33 ` Glenn Morris
  2012-03-23 22:31   ` Bastien Guerry
       [not found]   ` <87pqc3x83n.fsf@altern.org>
  0 siblings, 2 replies; 6+ messages in thread
From: Glenn Morris @ 2012-03-23  0:33 UTC (permalink / raw)
  To: Eric Hanchrow; +Cc: 9809

Eric Hanchrow wrote:

> I started emacs with "emacs -Q".  Then I typed
>
>     M-x o r g - m o d e <return> M-x f l y s p e l l -
>     m o d e <return> C-h c <M-tab> C-h c M-TAB
>
> C-h c <M-tab> showed me "<M-tab> runs the command pcomplete".
> C-h c  M-TAB (which I typed via Ctrl+Alt+i) showed me "M-TAB runs the
> command flyspell-auto-correct-word".
>
> I expected _both_ key events -- <M-tab> and M-TAB -- to show me
> flyspell-auto-correct-word.

This occurs because org.el for some reason tries to define the M-TAB key
3 different ways:

(org-defkey org-mode-map [(meta tab)] 'pcomplete)
(org-defkey org-mode-map "\M-\t" 'pcomplete)
(org-defkey org-mode-map "\M-\C-i"      'pcomplete)

Removing all but the second definition would fix this.

Ref "Named ASCII Control Characters" in the lispref.

    If you do not want to distinguish between (for example) <TAB> and
    `C-i', make just one binding, for the ASCII character <TAB> (octal
    code 011). If you do want to distinguish, make one binding for this
    ASCII character, and another for the "function key" `tab'.





^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#9809: 24.0.90; flyspell-auto-correct-word hard to access in org-mode
  2012-03-23  0:33 ` Glenn Morris
@ 2012-03-23 22:31   ` Bastien Guerry
  2012-04-01 10:00     ` Bastien
       [not found]   ` <87pqc3x83n.fsf@altern.org>
  1 sibling, 1 reply; 6+ messages in thread
From: Bastien Guerry @ 2012-03-23 22:31 UTC (permalink / raw)
  To: Glenn Morris; +Cc: 9809, Eric Hanchrow

Hi Glenn,

Glenn Morris <rgm@gnu.org> writes:

> Eric Hanchrow wrote:
>
>> I started emacs with "emacs -Q".  Then I typed
>>
>>     M-x o r g - m o d e <return> M-x f l y s p e l l -
>>     m o d e <return> C-h c <M-tab> C-h c M-TAB
>>
>> C-h c <M-tab> showed me "<M-tab> runs the command pcomplete".
>> C-h c  M-TAB (which I typed via Ctrl+Alt+i) showed me "M-TAB runs the
>> command flyspell-auto-correct-word".
>>
>> I expected _both_ key events -- <M-tab> and M-TAB -- to show me
>> flyspell-auto-correct-word.
>
> This occurs because org.el for some reason tries to define the M-TAB key
> 3 different ways:
>
> (org-defkey org-mode-map [(meta tab)] 'pcomplete)
> (org-defkey org-mode-map "\M-\t" 'pcomplete)
> (org-defkey org-mode-map "\M-\C-i"      'pcomplete)
>
> Removing all but the second definition would fix this.
>
> Ref "Named ASCII Control Characters" in the lispref.
>
>     If you do not want to distinguish between (for example) <TAB> and
>     `C-i', make just one binding, for the ASCII character <TAB> (octal
>     code 011). If you do want to distinguish, make one binding for this
>     ASCII character, and another for the "function key" `tab'.

Thanks.  This is now fixing in Org repo, I'll close the bug when
this goes into Emacs.

-- 
 Bastien





^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#9809: 24.0.90; flyspell-auto-correct-word hard to access in org-mode
       [not found]   ` <87pqc3x83n.fsf@altern.org>
@ 2012-03-23 23:28     ` Lennart Borgman
  2012-03-24  2:00       ` Stefan Monnier
  0 siblings, 1 reply; 6+ messages in thread
From: Lennart Borgman @ 2012-03-23 23:28 UTC (permalink / raw)
  To: Bastien Guerry; +Cc: 9809, Eric Hanchrow

On Fri, Mar 23, 2012 at 23:31, Bastien Guerry <bzg@altern.org> wrote:
>
> Hi Glenn,
>
> Glenn Morris <rgm@gnu.org> writes:
>
> > Eric Hanchrow wrote:
> >
> >> I started emacs with "emacs -Q".  Then I typed
> >>
> >>     M-x o r g - m o d e <return> M-x f l y s p e l l -
> >>     m o d e <return> C-h c <M-tab> C-h c M-TAB
> >>
> >> C-h c <M-tab> showed me "<M-tab> runs the command pcomplete".
> >> C-h c  M-TAB (which I typed via Ctrl+Alt+i) showed me "M-TAB runs the
> >> command flyspell-auto-correct-word".
> >>
> >> I expected _both_ key events -- <M-tab> and M-TAB -- to show me
> >> flyspell-auto-correct-word.
> >
> > This occurs because org.el for some reason tries to define the M-TAB key
> > 3 different ways:
> >
> > (org-defkey org-mode-map [(meta tab)] 'pcomplete)
> > (org-defkey org-mode-map "\M-\t" 'pcomplete)
> > (org-defkey org-mode-map "\M-\C-i"      'pcomplete)
> >
> > Removing all but the second definition would fix this.
> >
> > Ref "Named ASCII Control Characters" in the lispref.
> >
> >     If you do not want to distinguish between (for example) <TAB> and
> >     `C-i', make just one binding, for the ASCII character <TAB> (octal
> >     code 011). If you do want to distinguish, make one binding for this
> >     ASCII character, and another for the "function key" `tab'.
>
> Thanks.  This is now fixing in Org repo, I'll close the bug when
> this goes into Emacs.

Isn't there an underlying bug in Emacs here? Should not the flyspell
binding have overrided the org-mode-map binding from the beginning
(since org-mode-map is a major mode map)?





^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#9809: 24.0.90; flyspell-auto-correct-word hard to access in org-mode
  2012-03-23 23:28     ` Lennart Borgman
@ 2012-03-24  2:00       ` Stefan Monnier
  0 siblings, 0 replies; 6+ messages in thread
From: Stefan Monnier @ 2012-03-24  2:00 UTC (permalink / raw)
  To: Lennart Borgman; +Cc: Bastien Guerry, 9809, Eric Hanchrow

> Isn't there an underlying bug in Emacs here?

Whether it's a bug or not depends on point of view.  flyspell takes the
position that it binds M-TAB, so if you want to bind M-tab to something
else you can (and you still get flyspell's command on C-M-i and on ESC
TAB).


        Stefan





^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#9809: 24.0.90; flyspell-auto-correct-word hard to access in org-mode
  2012-03-23 22:31   ` Bastien Guerry
@ 2012-04-01 10:00     ` Bastien
  0 siblings, 0 replies; 6+ messages in thread
From: Bastien @ 2012-04-01 10:00 UTC (permalink / raw)
  To: Glenn Morris; +Cc: 9809-done, Eric Hanchrow

Bastien Guerry <bzg@altern.org> writes:

> Glenn Morris <rgm@gnu.org> writes:
>
>> Eric Hanchrow wrote:
>>
>>> I started emacs with "emacs -Q".  Then I typed
>>>
>>>     M-x o r g - m o d e <return> M-x f l y s p e l l -
>>>     m o d e <return> C-h c <M-tab> C-h c M-TAB
>>>
>>> C-h c <M-tab> showed me "<M-tab> runs the command pcomplete".
>>> C-h c  M-TAB (which I typed via Ctrl+Alt+i) showed me "M-TAB runs the
>>> command flyspell-auto-correct-word".
>>>
>>> I expected _both_ key events -- <M-tab> and M-TAB -- to show me
>>> flyspell-auto-correct-word.
>>
>> This occurs because org.el for some reason tries to define the M-TAB key
>> 3 different ways:
>>
>> (org-defkey org-mode-map [(meta tab)] 'pcomplete)
>> (org-defkey org-mode-map "\M-\t" 'pcomplete)
>> (org-defkey org-mode-map "\M-\C-i"      'pcomplete)
>>
>> Removing all but the second definition would fix this.
>>
>> Ref "Named ASCII Control Characters" in the lispref.
>>
>>     If you do not want to distinguish between (for example) <TAB> and
>>     `C-i', make just one binding, for the ASCII character <TAB> (octal
>>     code 011). If you do want to distinguish, make one binding for this
>>     ASCII character, and another for the "function key" `tab'.
>
> Thanks.  This is now fixing in Org repo, I'll close the bug when
> this goes into Emacs.

Fixed in Emacs trunk.  Closing this bug.

-- 
 Bastien





^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2012-04-01 10:00 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-10-20 15:51 bug#9809: 24.0.90; flyspell-auto-correct-word hard to access in org-mode Eric Hanchrow
2012-03-23  0:33 ` Glenn Morris
2012-03-23 22:31   ` Bastien Guerry
2012-04-01 10:00     ` Bastien
     [not found]   ` <87pqc3x83n.fsf@altern.org>
2012-03-23 23:28     ` Lennart Borgman
2012-03-24  2:00       ` Stefan Monnier

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).