From: Phil Brown <p.brown.phil@gmail.com>
To: 45900@debbugs.gnu.org
Subject: bug#45900: 28.0.50; [PATCH] [native-comp] Improve backtraces from async workers
Date: Fri, 15 Jan 2021 10:19:37 -0800 [thread overview]
Message-ID: <CANOp0OgfheBMAZBUpsp46YLAXOp3J1WxpaGncG-RO9FqJ81bBQ@mail.gmail.com> (raw)
[-- Attachment #1.1: Type: text/plain, Size: 1037 bytes --]
Hi bug list,
I've been happily using the native-comp branch and it works well. Attached
is a tiny change to set `backtrace-line-length' in comp.el's async workers.
I was debugging a few failed compilations and had run `(setq
backtrace-line-length 0)` in an attempt to see the full path of the
offending files (turned out to be autoloads). The setting was having no
effect on the async compile errors and I realized the batch-mode worker
processes weren't inheriting it.
I haven't signed CA papers since this change is so small, but am happy to
if that's needed.
Thanks!
-Phil
In GNU Emacs 28.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.5,
cairo version 1.16.0)
of 2020-12-23 built on mars
Repository revision: ffcd490cb49ba86d625288ea425d98e8cac22a05
Repository branch: feature/native-comp
Windowing system distributor 'The X.Org Foundation', version 11.0.12004000
System Description: Debian GNU/Linux 10 (buster)
Configured using:
'configure --prefix=/home/phil/local/emacs-28-snapshot-native-comp
--with-nativecomp'
[-- Attachment #1.2: Type: text/html, Size: 1253 bytes --]
[-- Attachment #2: 0001-Set-backtrace-line-length-in-async-worker-processes.patch --]
[-- Type: text/x-patch, Size: 1129 bytes --]
From 24da03e0992e02a3bad9aac76706ad84bab6baa0 Mon Sep 17 00:00:00 2001
From: Philip Brown <pdbrown.git@gmail.com>
Date: Fri, 15 Jan 2021 00:35:36 -0800
Subject: [PATCH] Set backtrace-line-length in async worker processes
* lisp/emacs-lisp/comp.el (comp-run-async-workers): Set
backtrace-line-length in async worker processes.
Copyright-paperwork-exempt: yes
---
lisp/emacs-lisp/comp.el | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lisp/emacs-lisp/comp.el b/lisp/emacs-lisp/comp.el
index 875f15aa75..c974a09f6d 100644
--- a/lisp/emacs-lisp/comp.el
+++ b/lisp/emacs-lisp/comp.el
@@ -3802,6 +3802,8 @@ comp-run-async-workers
source-file (comp-el-to-eln-filename source-file)))
do (let* ((expr `(progn
(require 'comp)
+ ,(when (boundp 'backtrace-line-length)
+ `(setq backtrace-line-length ,backtrace-line-length))
(setf comp-speed ,comp-speed
comp-debug ,comp-debug
comp-verbose ,comp-verbose
--
2.20.1
next reply other threads:[~2021-01-15 18:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-15 18:19 Phil Brown [this message]
2021-01-16 12:40 ` bug#45900: 28.0.50; [PATCH] [native-comp] Improve backtraces from async workers Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANOp0OgfheBMAZBUpsp46YLAXOp3J1WxpaGncG-RO9FqJ81bBQ@mail.gmail.com \
--to=p.brown.phil@gmail.com \
--cc=45900@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).