From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Phil Brown Newsgroups: gmane.emacs.bugs Subject: bug#45900: 28.0.50; [PATCH] [native-comp] Improve backtraces from async workers Date: Fri, 15 Jan 2021 10:19:37 -0800 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000e2312f05b8f46a92" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17995"; mail-complaints-to="usenet@ciao.gmane.io" To: 45900@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jan 15 19:45:18 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l0U62-0004Ye-AE for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 15 Jan 2021 19:45:18 +0100 Original-Received: from localhost ([::1]:46602 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l0U61-0001q9-4c for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 15 Jan 2021 13:45:17 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57160) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l0Ty2-0005Yi-Lw for bug-gnu-emacs@gnu.org; Fri, 15 Jan 2021 13:37:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58423) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l0Ty2-00037d-El for bug-gnu-emacs@gnu.org; Fri, 15 Jan 2021 13:37:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l0Ty2-0002tc-AT for bug-gnu-emacs@gnu.org; Fri, 15 Jan 2021 13:37:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Phil Brown Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 15 Jan 2021 18:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 45900 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.161073578911087 (code B ref -1); Fri, 15 Jan 2021 18:37:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 15 Jan 2021 18:36:29 +0000 Original-Received: from localhost ([127.0.0.1]:41736 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l0TxS-0002si-H0 for submit@debbugs.gnu.org; Fri, 15 Jan 2021 13:36:28 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:34970) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l0ThR-0002Ss-6r for submit@debbugs.gnu.org; Fri, 15 Jan 2021 13:19:55 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53466) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l0ThQ-0003RI-TP for bug-gnu-emacs@gnu.org; Fri, 15 Jan 2021 13:19:52 -0500 Original-Received: from mail-pg1-x52a.google.com ([2607:f8b0:4864:20::52a]:36182) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l0ThO-0005gq-Su for bug-gnu-emacs@gnu.org; Fri, 15 Jan 2021 13:19:52 -0500 Original-Received: by mail-pg1-x52a.google.com with SMTP id c132so6535611pga.3 for ; Fri, 15 Jan 2021 10:19:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=tgUHFExg+Xbu8+KarBw2aT8hxRPB3nO+WSXIBX1dnrI=; b=fWt3tl/XNp2aukW1U7NPy22mZThWogXzKk3Zd+cFvJDBSaJYvW//CEuV4mUcqQGpi9 IZ6OCRvA3l4ONgscIHaprYyOHZM6MxofqOcUXGv3UoWrJ9RR/2g4jxp9WlEseZqpI085 3dYcfM/kahiJF+rQusOSJOJQ/teBxddirdPfOwuNZbmkUZDSBY9/7JJcZ1aNOkxCLN3d ElQHIQ98qYBZHCABFdTHQ7YPakRiHwWIiP9KmPL98pTcQAzU6tnmZZdaJHRBpkrCnrZN GEon+55n3pHIWGZGtYgjff5Mn+PBvLryFPJ7EToC3198XazPnIbTi4PRov78bq3mCr4F fjdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=tgUHFExg+Xbu8+KarBw2aT8hxRPB3nO+WSXIBX1dnrI=; b=sNGJ+V6eIbNEZRAUbTVdQVBfCou0VI39Sr7Rif38oeAkjDRnCcgDLvcYULVJYR12YN rFBrzMa4y56jMn7ISRGxg5bAI6n2v0ebxZL8tMq4BWXtHX4BHtKUJju5MlGvuxoHt3Hi IraZnLT7z+HY2f7wneH3MtSF3b8BKgB+ZUioQ/t5vCBNwB8uIoKRD07gttI7TfgJUEhh Mas7UTDhYDS1Gpztu6RqfyjuyCVH5LIHV5XF901PKb9gQNviNEt8xX8i/fJbamNJoJ4n sF2eWgi2R9bBAkD38v3jbidMUyBxVbJMXnFqPMDcI9Mp5GKIHexp+ya+V6byhUCvKH88 GmIQ== X-Gm-Message-State: AOAM530y4nQ7ARdoNiythVF/geDty4KYg9bGvvjLgaXBHh8s6EfW/c6n IKSMfMrWDMsWUK31Vw5Uz0hQGOjOBfjEnHOFcdCPweInKn8= X-Google-Smtp-Source: ABdhPJwdU80LhCMxeGtUSPSARFempAxpTCeF+VZWK/sJ2VnqQzmu41dsCZxfc+0cV3XOWx0rSyQUNylvzfzb/LZDAr4= X-Received: by 2002:a65:55ca:: with SMTP id k10mr13660936pgs.431.1610734788249; Fri, 15 Jan 2021 10:19:48 -0800 (PST) Received-SPF: pass client-ip=2607:f8b0:4864:20::52a; envelope-from=p.brown.phil@gmail.com; helo=mail-pg1-x52a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Fri, 15 Jan 2021 13:36:25 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:198000 Archived-At: --000000000000e2312f05b8f46a92 Content-Type: multipart/alternative; boundary="000000000000e2312c05b8f46a90" --000000000000e2312c05b8f46a90 Content-Type: text/plain; charset="UTF-8" Hi bug list, I've been happily using the native-comp branch and it works well. Attached is a tiny change to set `backtrace-line-length' in comp.el's async workers. I was debugging a few failed compilations and had run `(setq backtrace-line-length 0)` in an attempt to see the full path of the offending files (turned out to be autoloads). The setting was having no effect on the async compile errors and I realized the batch-mode worker processes weren't inheriting it. I haven't signed CA papers since this change is so small, but am happy to if that's needed. Thanks! -Phil In GNU Emacs 28.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.5, cairo version 1.16.0) of 2020-12-23 built on mars Repository revision: ffcd490cb49ba86d625288ea425d98e8cac22a05 Repository branch: feature/native-comp Windowing system distributor 'The X.Org Foundation', version 11.0.12004000 System Description: Debian GNU/Linux 10 (buster) Configured using: 'configure --prefix=/home/phil/local/emacs-28-snapshot-native-comp --with-nativecomp' --000000000000e2312c05b8f46a90 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi bug list,

I've been h= appily using the native-comp branch and it works well. Attached is a tiny c= hange to set `backtrace-line-length' in comp.el's async workers. I = was debugging a few failed compilations and had run `(setq backtrace-line-l= ength 0)` in an attempt to see the full path of the offending files (turned= out to be autoloads). The setting was having no effect on the async compil= e errors and I realized the batch-mode worker processes weren't inherit= ing it.

I haven't signed CA papers since this = change is so small, but am happy to if that's needed.

Thanks!
-Phil


In GNU E= macs 28.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.5, cairo vers= ion 1.16.0)
=C2=A0of 2020-12-23 built on mars
Repository revision: ff= cd490cb49ba86d625288ea425d98e8cac22a05
Repository branch: feature/native= -comp
Windowing system distributor 'The X.Org Foundation', versi= on 11.0.12004000
System Description: Debian GNU/Linux 10 (buster)
Configured using:
=C2=A0'configure --prefix=3D/home/phil/local/emac= s-28-snapshot-native-comp
=C2=A0--with-nativecomp'
--000000000000e2312c05b8f46a90-- --000000000000e2312f05b8f46a92 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Set-backtrace-line-length-in-async-worker-processes.patch" Content-Disposition: attachment; filename="0001-Set-backtrace-line-length-in-async-worker-processes.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kjykw9le0 RnJvbSAyNGRhMDNlMDk5MmUwMmEzYmFkOWFhYzc2NzA2YWQ4NGJhYjZiYWEwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXAgQnJvd24gPHBkYnJvd24uZ2l0QGdtYWlsLmNvbT4K RGF0ZTogRnJpLCAxNSBKYW4gMjAyMSAwMDozNTozNiAtMDgwMApTdWJqZWN0OiBbUEFUQ0hdIFNl dCBiYWNrdHJhY2UtbGluZS1sZW5ndGggaW4gYXN5bmMgd29ya2VyIHByb2Nlc3NlcwoKKiBsaXNw L2VtYWNzLWxpc3AvY29tcC5lbCAoY29tcC1ydW4tYXN5bmMtd29ya2Vycyk6IFNldApiYWNrdHJh Y2UtbGluZS1sZW5ndGggaW4gYXN5bmMgd29ya2VyIHByb2Nlc3Nlcy4KCkNvcHlyaWdodC1wYXBl cndvcmstZXhlbXB0OiB5ZXMKLS0tCiBsaXNwL2VtYWNzLWxpc3AvY29tcC5lbCB8IDIgKysKIDEg ZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9saXNwL2VtYWNzLWxp c3AvY29tcC5lbCBiL2xpc3AvZW1hY3MtbGlzcC9jb21wLmVsCmluZGV4IDg3NWYxNWFhNzUuLmM5 NzRhMDlmNmQgMTAwNjQ0Ci0tLSBhL2xpc3AvZW1hY3MtbGlzcC9jb21wLmVsCisrKyBiL2xpc3Av ZW1hY3MtbGlzcC9jb21wLmVsCkBAIC0zODAyLDYgKzM4MDIsOCBAQCBjb21wLXJ1bi1hc3luYy13 b3JrZXJzCiAgICAgICAgICAgICAgICAgICAgc291cmNlLWZpbGUgKGNvbXAtZWwtdG8tZWxuLWZp bGVuYW1lIHNvdXJjZS1maWxlKSkpCiAgICAgICAgICBkbyAobGV0KiAoKGV4cHIgYChwcm9nbgog ICAgICAgICAgICAgICAgICAgICAgICAgICAgIChyZXF1aXJlICdjb21wKQorICAgICAgICAgICAg ICAgICAgICAgICAgICAgICwod2hlbiAoYm91bmRwICdiYWNrdHJhY2UtbGluZS1sZW5ndGgpCisg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgYChzZXRxIGJhY2t0cmFjZS1saW5lLWxlbmd0 aCAsYmFja3RyYWNlLWxpbmUtbGVuZ3RoKSkKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAo c2V0ZiBjb21wLXNwZWVkICxjb21wLXNwZWVkCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgY29tcC1kZWJ1ZyAsY29tcC1kZWJ1ZwogICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIGNvbXAtdmVyYm9zZSAsY29tcC12ZXJib3NlCi0tIAoyLjIwLjEKCg== --000000000000e2312f05b8f46a92--