bug#70199: 30.0.50; Emacs Android ports serms not support SVG images, even with ImageMagick.

bug#70199: 30.0.50; Emacs Android ports serms not support SVG images, even with ImageMagick.

[Takesi Ayanokoji]

[-- Attachment #1: Type: text/plain, Size: 619 bytes --]

Hello,

When I use Emacs ports for Android with ImageMagick, (fancy-startup-screen)
doesn't show Emacs logo image, while logo displayed correctly without
ImageMagick.

I guess this is the result of commit
a66744021faeb2ce105b1001a380c4a46384c5f4 (because  afetr revert this
commit, startup screen shows logo correctly).

https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=a66744021faeb2ce105b1001a380c4a46384c5f4

But I have no idea how to fix this appropriately, because I don't have
enough knowledge SVG, ImageMagick, and this commit's background.

Please someone fix the problem in an appropriate way.

Regards,

[-- Attachment #2: Type: text/html, Size: 1067 bytes --]

bug#70199: 30.0.50; Emacs Android ports serms not support SVG images, even with ImageMagick.

[Takesi Ayanokoji]

[-- Attachment #1.1: Type: text/plain, Size: 1219 bytes --]

Hello, again.

I thought this and little Googling about this image format .

There will be the way to add additional condition that recognize types of
system(that is, 'system-type).

But I can't find the point of putting effort into displaying SVG images
when image type 'svg' isn't available, and when we can use other image
formats instead.

(for me, these splash.* images are almost looks same).

I attach the patch.
How about this?

Thanks,

2024年4月5日(金) 午前0:46 Takesi Ayanokoji <ayanokoji.takesi@gmail.com>:

> Hello,
>
> When I use Emacs ports for Android with ImageMagick,
> (fancy-startup-screen) doesn't show Emacs logo image, while logo displayed
> correctly without ImageMagick.
>
> I guess this is the result of commit
> a66744021faeb2ce105b1001a380c4a46384c5f4 (because  afetr revert this
> commit, startup screen shows logo correctly).
>
>
> https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=a66744021faeb2ce105b1001a380c4a46384c5f4
>
> But I have no idea how to fix this appropriately, because I don't have
> enough knowledge SVG, ImageMagick, and this commit's background.
>
> Please someone fix the problem in an appropriate way.
>
> Regards,
>

[-- Attachment #1.2: Type: text/html, Size: 2299 bytes --]

[-- Attachment #2: 0001-Tweak-startup-image-choice-logic.patch --]
[-- Type: application/octet-stream, Size: 1316 bytes --]

From a66744021faeb2ce105b1001a380c4a46384c5f4 Mon Sep 17 00:00:00 2001
From: Chong Yidong <cyd@gnu.org>
Date: Mon, 11 Jun 2012 23:55:32 +0800
Subject: [PATCH] Tweak startup image choice logic.

* startup.el (fancy-splash-head): Use splash.svg even if librsvg
is uninstalled, if imagemagick is installed.
---
 lisp/ChangeLog  | 5 +++++
 lisp/startup.el | 3 ++-
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index a251c45f323..39f5f8435d0 100644
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -1,3 +1,8 @@
+2012-06-11  Chong Yidong  <cyd@gnu.org>
+
+	* startup.el (fancy-splash-head): Use splash.svg even if librsvg
+	is uninstalled, if imagemagick is installed.
+
 2012-06-11  Stefan Monnier  <monnier@iro.umontreal.ca>
 
 	* emacs-lisp/cl-lib.el: Use lexical-binding.
diff --git a/lisp/startup.el b/lisp/startup.el
index 59d25626372..e71fe323066 100644
--- a/lisp/startup.el
+++ b/lisp/startup.el
@@ -1491,7 +1491,8 @@ a face or button specification."
 				   (if (image-type-available-p 'xpm)
 				       "splash.xpm"
 				     "splash.pbm"))
-				  ((image-type-available-p 'svg)
+				  ((or (image-type-available-p 'svg)
+				       (image-type-available-p 'imagemagick))
 				   "splash.svg")
 				  ((image-type-available-p 'png)
 				   "splash.png")
-- 
2.43.0