From: Gustavo Barros <gusbrs.2016@gmail.com>
To: Stefan Kangas <stefankangas@gmail.com>
Cc: Eli Zaretskii <eliz@gnu.org>, 58721@debbugs.gnu.org
Subject: bug#58721: 28.2; dired with delete-by-moving-to-trash can't trash directory twice
Date: Fri, 28 Oct 2022 13:06:14 -0300 [thread overview]
Message-ID: <CAM9ALR9wAhaQyFMAVzjYobk=xjVL1g8ixY+6YBV-ykwpi5tQUg@mail.gmail.com> (raw)
In-Reply-To: <CADwFkm=4KoGUa6B54zWt+4iWcXQcj20cuSBqQJ6BCPwOYzLt3Q@mail.gmail.com>
Hi Stefan,
On Fri, 28 Oct 2022 at 12:26, Stefan Kangas <stefankangas@gmail.com> wrote:
> I get the same result. But I think this is expected, as the
> `rename-file' docstring says:
>
> For NEWNAME to be recognized as a directory name, it should
> end in a slash.
>
> So this function seems to be working as documented.
Thanks for trying! I'm glad I'm not mad. :-)
I had missed this bit of the docstring, and you're right, of course.
So, it seems we are back to `move-file-to-trash', and how it calls
`rename-file'.
I've redefined `move-file-to-trash' to message `new-fn` right before
`rename-file' is being called. And tested both:
(move-file-to-trash "/path/to/orig/barbaz")
(move-file-to-trash "/path/to/orig/barbaz/")
And both cases output things like:
Back to top level
/home/<username>/.local/share/Trash/files/barbazOfwLav
Entering debugger...
Back to top level
/home/<username>/.local/share/Trash/files/barbazVICScf
Entering debugger...
Back to top level
/home/<username>/.local/share/Trash/files/barbazVd4241
Entering debugger...
Back to top level
/home/<username>/.local/share/Trash/files/barbaz04EjUm
Entering debugger...
Back to top level
That is, no end slash appended to the directory at
`move-file-to-trash'. So, it appears we have a good suspect. Why it
works when the filesystem is the same still beats me.
next prev parent reply other threads:[~2022-10-28 16:06 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-22 18:23 bug#58721: 28.2; dired with delete-by-moving-to-trash can't trash directory twice Gustavo Barros
2022-10-27 16:09 ` Eli Zaretskii
2022-10-27 17:07 ` Gustavo Barros
2022-10-27 17:22 ` Gustavo Barros
2022-10-27 17:30 ` Eli Zaretskii
2022-10-27 17:51 ` Gustavo Barros
2022-10-27 18:20 ` Eli Zaretskii
2022-10-27 18:41 ` Gustavo Barros
2022-10-27 19:04 ` Eli Zaretskii
2022-10-27 19:13 ` Gustavo Barros
2022-10-27 22:01 ` Gustavo Barros
2022-10-28 7:46 ` Eli Zaretskii
2022-10-28 10:43 ` Gustavo Barros
2022-10-28 11:44 ` Eli Zaretskii
2022-10-28 12:35 ` Gustavo Barros
2022-10-28 15:26 ` Stefan Kangas
2022-10-28 16:06 ` Gustavo Barros [this message]
2022-10-28 19:07 ` Gustavo Barros
2022-10-29 5:25 ` Mike Kupfer
2022-10-29 10:35 ` Gustavo Barros
2022-10-29 15:24 ` Mike Kupfer
2022-10-29 15:48 ` Eli Zaretskii
2022-10-29 16:32 ` Mike Kupfer
2022-10-29 16:56 ` Eli Zaretskii
2022-10-30 0:09 ` Mike Kupfer
2022-10-30 6:41 ` Eli Zaretskii
2022-10-30 17:40 ` Mike Kupfer
2022-10-30 18:02 ` Eli Zaretskii
2022-10-30 18:18 ` Mike Kupfer
2022-10-30 19:51 ` Eli Zaretskii
2022-10-30 22:20 ` Mike Kupfer
2022-10-30 23:10 ` Gustavo Barros
2022-10-31 0:01 ` Mike Kupfer
2022-10-31 0:23 ` Gustavo Barros
2022-10-31 12:49 ` Eli Zaretskii
2022-10-31 13:16 ` Gustavo Barros
2022-11-21 1:08 ` Mike Kupfer
2022-11-21 1:45 ` Gustavo Barros
2022-11-21 1:52 ` Mike Kupfer
2022-11-24 11:19 ` Eli Zaretskii
2022-11-24 11:28 ` Gustavo Barros
2022-10-27 19:07 ` Gustavo Barros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAM9ALR9wAhaQyFMAVzjYobk=xjVL1g8ixY+6YBV-ykwpi5tQUg@mail.gmail.com' \
--to=gusbrs.2016@gmail.com \
--cc=58721@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).