From: Eli Zaretskii <eliz@gnu.org>
To: Mike Kupfer <mkupfer@alum.berkeley.edu>
Cc: 58721@debbugs.gnu.org, gusbrs.2016@gmail.com
Subject: bug#58721: 28.2; dired with delete-by-moving-to-trash can't trash directory twice
Date: Sun, 30 Oct 2022 21:51:18 +0200 [thread overview]
Message-ID: <835yg1f5u1.fsf@gnu.org> (raw)
In-Reply-To: <21142.1667153909@alto> (message from Mike Kupfer on Sun, 30 Oct 2022 11:18:29 -0700)
> From: Mike Kupfer <mkupfer@alum.berkeley.edu>
> cc: 58721@debbugs.gnu.org, gusbrs.2016@gmail.com
> Date: Sun, 30 Oct 2022 11:18:29 -0700
>
> Eli Zaretskii wrote:
>
> > Looks good, but maybe add to the comment the reason _why_ we don't use
> > rename-file for directories. You explained _what_ we do, but not
> > _why_.
>
> Do you mean something like
>
> -----8<-----8<-----
> Fix cross-filesystem directory trashing (Bug#58721)
>
> * lisp/files.el (move-file-to-trash): When trashing a directory,
> copy it into the trash folder and then delete it, rather than
> using rename-file. rename-file can only be used when the
> to-be-trashed directory and the trashcan live in the same filesystem;
> this approach handles both that case and the different-filesystem case.
> ----->8----->8-----
I meant in the code, not the log message, and I meant to tell more
detail.
But never mind, I can always add it later myself.
next prev parent reply other threads:[~2022-10-30 19:51 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-22 18:23 bug#58721: 28.2; dired with delete-by-moving-to-trash can't trash directory twice Gustavo Barros
2022-10-27 16:09 ` Eli Zaretskii
2022-10-27 17:07 ` Gustavo Barros
2022-10-27 17:22 ` Gustavo Barros
2022-10-27 17:30 ` Eli Zaretskii
2022-10-27 17:51 ` Gustavo Barros
2022-10-27 18:20 ` Eli Zaretskii
2022-10-27 18:41 ` Gustavo Barros
2022-10-27 19:04 ` Eli Zaretskii
2022-10-27 19:13 ` Gustavo Barros
2022-10-27 22:01 ` Gustavo Barros
2022-10-28 7:46 ` Eli Zaretskii
2022-10-28 10:43 ` Gustavo Barros
2022-10-28 11:44 ` Eli Zaretskii
2022-10-28 12:35 ` Gustavo Barros
2022-10-28 15:26 ` Stefan Kangas
2022-10-28 16:06 ` Gustavo Barros
2022-10-28 19:07 ` Gustavo Barros
2022-10-29 5:25 ` Mike Kupfer
2022-10-29 10:35 ` Gustavo Barros
2022-10-29 15:24 ` Mike Kupfer
2022-10-29 15:48 ` Eli Zaretskii
2022-10-29 16:32 ` Mike Kupfer
2022-10-29 16:56 ` Eli Zaretskii
2022-10-30 0:09 ` Mike Kupfer
2022-10-30 6:41 ` Eli Zaretskii
2022-10-30 17:40 ` Mike Kupfer
2022-10-30 18:02 ` Eli Zaretskii
2022-10-30 18:18 ` Mike Kupfer
2022-10-30 19:51 ` Eli Zaretskii [this message]
2022-10-30 22:20 ` Mike Kupfer
2022-10-30 23:10 ` Gustavo Barros
2022-10-31 0:01 ` Mike Kupfer
2022-10-31 0:23 ` Gustavo Barros
2022-10-31 12:49 ` Eli Zaretskii
2022-10-31 13:16 ` Gustavo Barros
2022-11-21 1:08 ` Mike Kupfer
2022-11-21 1:45 ` Gustavo Barros
2022-11-21 1:52 ` Mike Kupfer
2022-11-24 11:19 ` Eli Zaretskii
2022-11-24 11:28 ` Gustavo Barros
2022-10-27 19:07 ` Gustavo Barros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=835yg1f5u1.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=58721@debbugs.gnu.org \
--cc=gusbrs.2016@gmail.com \
--cc=mkupfer@alum.berkeley.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).